Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 0/7] crypto: add CRYPTO_ALG_ALLOCATES_MEMORY
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        Eric Biggers <ebiggers@kernel.org>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc:     mpatocka@redhat.com, linux-crypto@vger.kernel.org,
        dm-devel@redhat.com,
        =?UTF-8?Q?Horia_Geant=c4=83?= <horia.geanta@nxp.com>,
        Silvano Di Ninno <silvano.dininno@nxp.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        Franck LENORMAND <franck.lenormand@nxp.com>
References: <20200716115538.GA31461@gondor.apana.org.au>
 <8eefed8b-5ad5-424b-ab32-85e0cbac0a15@nxp.com>
 <20200722072932.GA27544@gondor.apana.org.au>
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
Message-ID: <71b6f739-d4a8-8b26-bf78-ce9acf9a0f99@nxp.com>
Date:   Thu, 19 Nov 2020 20:29:10 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.2
In-Reply-To: <20200722072932.GA27544@gondor.apana.org.au>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.1.5] (188.26.141.79) by AM4PR0501CA0055.eurprd05.prod.outlook.com (2603:10a6:200:68::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20 via Frontend Transport; Thu, 19 Nov 2020 18:29:13 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 5f9095ab-e9de-482f-8572-08d88cb9053d
X-MS-TrafficTypeDiagnostic: VI1PR04MB5501:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR04MB5501B8607750C285604AFE1C8CE00@VI1PR04MB5501.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: TKQqSWdp+lAJcOXKtrhEdABIV2QRaeie4U8n+1RT6vmG8rQAcqQ0YZxUePcq4TyoQbhkmsH7bo9aToYNF+FzSlv3wfftRZ6clmGLp1Y9j7wYlSmyOgN1vaY7lA/aFjA4TOSZnKcGhBhmnhMZK9waDbBtH21+eYNTT4LVbzMWO2PYvPFGqp+JSgEMCq+3YBTSVN7BBK3pIdCVPAZeWzaRHS1D0EajjNoJ4MyinLCtl2f1iP8aFaOZt+ghvEoyTUlSQtWbdQEik3u5tTGkgk3ru/FtCpZuW5RDkQYzntgKCmn4hHc672FfRtBat8ZrotCWKCBaLhYVBPshYE8kPQqV5e4lcY4KmnkQ4OG610jJfXkfK5NAkdWrRAELXzEGmPiuDQGYeYozoyCgNU3e5zfvXWHFha9H047juRiDcgEWVo6IUgVG0pTtI6p5nebzQBkCjCUEvPNvwefFNqfrh2HGuw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0402MB3712.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(136003)(39860400002)(396003)(346002)(366004)(966005)(31686004)(36756003)(31696002)(4326008)(6486002)(26005)(956004)(2616005)(66946007)(478600001)(66476007)(54906003)(8936002)(2906002)(66556008)(86362001)(45080400002)(186003)(8676002)(52116002)(16526019)(83380400001)(16576012)(110136005)(44832011)(5660300002)(316002)(53546011)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: EauyW3szrujTVUeRhdgIdiKACJVweluW6JsVl4Xp0doXL53wEhoBdl57o7JoVuQMqOvbu9oaq54YcydESSR8zgPnaBYcF8Fp6k9Kv6gVLkEeP5+qlIdotHFkg8l7qawxJFoU4L+CNeGRQukPTi3qZPAtdSObo4v6nk5xUB1W27Pmxn4gbsTRWxsa25QcA+uQl/re7KFHpB3z+Dt4MtPXztMb0ZzXX5l6caS5BhLTcam3rm6luD3YWVoAXIlOwsoJ8HjY74AMmq/TrZPTNWDM3gQFVYcebG6ISR/mBhSsIV6Wc49c7WevGjV9CiJimZfkq5puNKbWevCDJF7CVCMag7QH8dWaHHjU8Ryp5QBmtdEkHRFxGNAezYOgRw73G92PkcgckrxVXvmURojGUr2nzSrQ5O7Ajw/CZQt0Bt8NM19gS4QAAFPDM2aPfEUEkYvY4nJujo9jMTBvj2n19C3hOIMi7Fv8KtPv+gd+SAvC0DjbLFnWu6pvIFfc9cZc67DZshTj/HvMN1rfxiMXqOJHOsTFJaTkgvY3POuieOQDu7YO/DSTvm6Li7MvvSacAQrNrQ2i4knUtRzq/aSl+DziaSZFdkXcwYctwwz3ipg0jIPnmueVDnRvGDmilKCGABk0877g9M88wIM+Ij44Xb4PBqzHm+dCgMlB7JtzoLGRJ0C+xLJetSBEueEXVERpT1MKsgq6xNW2Yl39CWnkwkBoqgTRvQ/7iBXKXfMfRW0isKlpPwdMkHFJtmBDev/chbAohqOhOERa1eRKLYeIPAW8mEVN4dC2/XpfosKy8LsW+T5DTH0L1QCvlCXbQXUC/YHAEQG2QnfqP5FzF+nQ1WTppe3e25FlmpHuWZab+iLn9rMqbsvHqoSPhks74bbakv3IvdOEKBFixF1dvbD2/Nawow==
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f9095ab-e9de-482f-8572-08d88cb9053d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3712.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2020 18:29:16.0010
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b5zIgxluNjMLbFKacYbyrVRvAT8bj4Eleeo8N4PIgbaH7rWOFwyJruuIRs0eDvDrIGkODi1oy0qLia6t+G5hFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5501
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org


Hi Herbert,

On 7/22/2020 10:29 AM, Herbert Xu wrote:
> On Fri, Jul 17, 2020 at 05:42:43PM +0300, Horia Geantă wrote:
>>
>> Looks like there's no mention of a limit on src, dst scatterlists size
>> that crypto implementations could use when pre-allocating memory
>> and crypto users needing CRYPTO_ALG_ALLOCATES_MEMORY should be aware of
>> (for the contract to be honoured):
>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flinux-crypto%2F780cb500-2241-61bc-eb44-6f872ad567d3%40nxp.com&amp;data=02%7C01%7Ciuliana.prodan%40nxp.com%7Ca077782ce45c4ad3458b08d82e1100ac%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637309997855351100&amp;sdata=T9RLjA%2B4l3zpxUSkFUGTxGQFu4kWfghQAKGyfUco%2Fb8%3D&amp;reserved=0
> 
> Good point.  I think we should limit this flag only to the cases
> applicable to dm-crypt, which seems to be 4 entries maximum.
> 
> Anything else should be allowed to allocate extra memory as needed.

I'm working on removing the CRYPTO_ALG_ALLOCATES_MEMORY flag from CAAM.
For memory allocation I want to use the crypto request object and set 
the size needed in reqsize (as suggested by you 
https://lore.kernel.org/linux-crypto/20200610010450.GA6449@gondor.apana.org.au/).
But CAAM needs DMA-able memory and the current mechanism doesn't allow it.

I want to use Horia's solution from a couple of years ago 
(https://lore.kernel.org/linux-crypto/1426266882-31626-1-git-send-email-horia.geanta@freescale.com/), 
but modify request object allocation only in Crypto API.

What do you think?

Thanks,
Iulia