Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp1105164pxb; Fri, 20 Nov 2020 00:56:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJyCqhp4cWFM37e+Z4z5LVCcUSca9NskegUc0E4g42P3Otdcpd6RVjcr+cTdgZknrSlP95/K X-Received: by 2002:a17:906:86cc:: with SMTP id j12mr20982966ejy.174.1605862579798; Fri, 20 Nov 2020 00:56:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605862579; cv=none; d=google.com; s=arc-20160816; b=U6+3KRrXBHSPpf6tHpBnckQ/RY8V02sMO3pFg4kM6uYhdOp/mh7Xj3XYgH2X0t1F2y fAkAgs2gGKP/IN1FQHZdXDaHBrEn/JlskUj6J4umnioSRo1r+rlh0LNSB4Bf5JECRylE FKIXLUB+xMKEhC3UVuo1pJmmMUvn6F8HCUzFJJQ9RibnE1h/COL0gKTasWvXL+CMYf9c 1fwqu0cG8rP84F//kprxzmPDAM9tQZNaFakyqZBcb0WggdGpSw1OfsaxzEYewNRz6CEZ t0aK5a8gyYw5ix1gYNBiHVTZAmkWOrVRMif7etE1KEVH5le7WfrN9KUt9DDwkhgyul1C iSpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=e8nn6AgEofGqyuAf1BSX1B7XgheU9u2AReV9paY/Rb4=; b=VysArwF1u8TVWMjlv6N2Ai9MbuUTUCdPi2N/LQG/q/UpAFBMuuwwVGijz0vO/U9j8k txb8n0FYGpYkV4uuXJRCrxioYm2QXjK+IHonUABjbL6PPKx4TuJa8b/0ApT49tBaPept lUwZIS53sUtnrn856yPkdvzMw4wTjkDtbmFPWoe2raAdlDu57KfXZO18U2RlAdcovoNf NhgDSZhVp5aa0hnp5MSJjKm/6EX5TtkDozAFb2CMzE00kE9H3qovmoYgAkQVOPJ7oJqu C0G2L9TYuDMtGHiw8it9xZNQUrel5X7eq6DX0nxQWCfITvnJQrpA13yrFqEsb2usEPoT L7zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ft+sc814; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ly13si1318776ejb.61.2020.11.20.00.55.47; Fri, 20 Nov 2020 00:56:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ft+sc814; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725952AbgKTIza (ORCPT + 99 others); Fri, 20 Nov 2020 03:55:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725789AbgKTIza (ORCPT ); Fri, 20 Nov 2020 03:55:30 -0500 Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2899BC0613CF for ; Fri, 20 Nov 2020 00:55:30 -0800 (PST) Received: by mail-ed1-x544.google.com with SMTP id y4so8712489edy.5 for ; Fri, 20 Nov 2020 00:55:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=e8nn6AgEofGqyuAf1BSX1B7XgheU9u2AReV9paY/Rb4=; b=Ft+sc814RunH7OADrLDO4oLYun8FoYeHajFkFgbGHT81Q7zs/pcB9r4iHsnv/65T9e RuAqKzYax8v31XlCkBcYVISmL33cjsYPOwFYiY4GBAHr8j3G+r7XfOjhHKaGsiuVDjVk elOUPsuzHiweFlURhLzAohN+AKOAOTDMr+J0UXdXjH6EJdi5maWunnxxgsrlbzF1nO4P 0CgQvAKp6n6+fbintWSe/gSwemleu6Tj05apR1iZk+/Ka+kNfEW8ogCYcZj4omh9Vg/P TnARcBOQIK5Jt5Q2P/yDLPh6b57pamG7+q48bXL5pBRaGO74/tmUTbx8Wca4wqNlzz+t 2icQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=e8nn6AgEofGqyuAf1BSX1B7XgheU9u2AReV9paY/Rb4=; b=TqQqCaEVJcxse5XcvgAdsEsSV6lLRYjObbL1TbIfMM7MLoEz0FyYTq9BawU3v5Z5ca MCjgelbjveOSeuWm3b8XhNCOkOu3Iph85N8qXvJYd1lczgnCTcDzHLu6CiGUGZXoH+Xp gH3HYsaPmta5IblSax2H2z6ulGwRn0oUYHgbhXdlPsH2MHU8EqHbl5iR9N00Lzrl1SlD zEhSKdXxuP/hsSQMloGtg+1bnu5Uy62Lge6ZLMEUtW3Hf3d+N8DSI7zuM5TJJmATMs4C UlxV3/rSvl6BnVAWWSi1vys6GhRvdhvC8upL5VYBVvaBgZKS4tX9KpoJquQ7WRWwC+Ew eNww== X-Gm-Message-State: AOAM530hcAoRc8pIKN9cnNUSrW3jpphrOna7NZBF/Bmheu0p2XiGEpaS 89KKciTrjQ11Xf+luqdXEU0vt3vUgwBBbNt3q8YF1rBOX6k= X-Received: by 2002:aa7:cc14:: with SMTP id q20mr10076827edt.140.1605862528929; Fri, 20 Nov 2020 00:55:28 -0800 (PST) MIME-Version: 1.0 References: <20201117133214.29114-1-ardb@kernel.org> <20201117133214.29114-5-ardb@kernel.org> In-Reply-To: <20201117133214.29114-5-ardb@kernel.org> From: =?UTF-8?B?T25kcmVqIE1vc27DocSNZWs=?= Date: Fri, 20 Nov 2020 09:55:18 +0100 Message-ID: Subject: Re: [PATCH v3 4/4] crypto: aegis128 - expose SIMD code path as separate driver To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org, Herbert Xu , linux-arm-kernel@lists.infradead.org, Eric Biggers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org ut 17. 11. 2020 o 14:32 Ard Biesheuvel nap=C3=ADsal(a): > Wiring the SIMD code into the generic driver has the unfortunate side > effect that the tcrypt testing code cannot distinguish them, and will > therefore not use the latter to fuzz test the former, as it does for > other algorithms. > > So let's refactor the code a bit so we can register two implementations: > aegis128-generic and aegis128-simd. > > Signed-off-by: Ard Biesheuvel Reviewed-by: Ondrej Mosnacek