Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp374826pxu; Sun, 22 Nov 2020 11:14:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJys8hXTSH5GJaCQxdKrU9sIATAWru6TiLz5iajIo4dvL5w161v/rH82u0oklZXFnvbEUL/Y X-Received: by 2002:a17:906:d96e:: with SMTP id rp14mr20829856ejb.214.1606072459388; Sun, 22 Nov 2020 11:14:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606072459; cv=none; d=google.com; s=arc-20160816; b=udOTLcnkUqAoUvZeY6geIVSCpKpgPFVA7wISNNgHawUfyN63aDqDq9EeCzd7t0AnJK F99hBEy4CWfpHfk01GOeoO0CmD0WWExPHGulSO8YBZAN8VzBAg2MxCSTs9fi5+75IM9y m13tCzfMqZmeO6iAORnwJG84v7PPdiii+j3eoP7ax6aiDFrLz9fhlwM17WbIaeHYIzf0 M+7mQWuLjD8kLf8RRRSYxuLPSVXETiq23tCAdokAT3gbloeEglTmifjL3fmLSyDeZhOv XmrqhqW9+qdlVM5tKbzI2Mf3GtXdyGWUkT7FIZm5y+Cj1mGaHK+Y0swECcWdJb7kjvfc OHbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature:dkim-signature; bh=3hxjM4ExBjozSsk/4rZZboxwxXlJbRWL+DEVHm4wB2s=; b=Sbw+kZZtSuueS6oCPWB+VmFE5cYZItfBwx4JQRBXH4si1Ke6eQNeTM/I9WABurYRK6 vybJe5K/YaeT/12ebdH6wJnfvdUm5XfpzM1kyzVWOqyMiMNKijz/trrkyhuTLHm+R9XI h9rAFxdkA7xkkbpYNbRo73sxKTLD4VcIqnZUBzsKoV+7j7Xy9TN+mRYHyEK9lTILK353 RQuSdbdTeXFX0mJNMRzSQpFcNusQnGm+a0TeHfJPTlGaJzlobMBrsBavzNhZaVkfDEBq bqwQRYE213xa677ms+vRfe/sdygwPeFC/M8Wtaamx4ok2WaUDHSHjP5mSQ2C+Y3C0MJS +2fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@hansenpartnership.com header.s=20151216 header.b=cqs+SSmh; dkim=pass header.i=@hansenpartnership.com header.s=20151216 header.b=cqs+SSmh; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=hansenpartnership.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d17si5250372ejh.451.2020.11.22.11.13.45; Sun, 22 Nov 2020 11:14:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@hansenpartnership.com header.s=20151216 header.b=cqs+SSmh; dkim=pass header.i=@hansenpartnership.com header.s=20151216 header.b=cqs+SSmh; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=hansenpartnership.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728058AbgKVTMg (ORCPT + 99 others); Sun, 22 Nov 2020 14:12:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727888AbgKVTMf (ORCPT ); Sun, 22 Nov 2020 14:12:35 -0500 Received: from bedivere.hansenpartnership.com (bedivere.hansenpartnership.com [IPv6:2607:fcd0:100:8a00::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22262C0613CF; Sun, 22 Nov 2020 11:12:35 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id 9270E1280149; Sun, 22 Nov 2020 11:12:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hansenpartnership.com; s=20151216; t=1606072354; bh=RkMkP78xnGMXpQYwW6B64FZnxQgTZZOXvlSf0xxLQvs=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References:From; b=cqs+SSmhVi1ZEA6KYpGlCOCKLLv9H3tmiNoTpcFF7F+1vb1QgbekNgnLlgvfKOfrE OZFKROCwJ+4Dh9AKsWr2ZhTbG6lfWTbk5QBrrreOMOUbINEmr9+ncDNzytUg1VYukU VtKrfA4fWPJSjG94bNM6AxKG7W4waC4yzJNdPcng= Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5iSAU90NoN49; Sun, 22 Nov 2020 11:12:34 -0800 (PST) Received: from jarvis.int.hansenpartnership.com (unknown [IPv6:2601:600:8280:66d1::527]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id D7CFF128010B; Sun, 22 Nov 2020 11:12:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hansenpartnership.com; s=20151216; t=1606072354; bh=RkMkP78xnGMXpQYwW6B64FZnxQgTZZOXvlSf0xxLQvs=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References:From; b=cqs+SSmhVi1ZEA6KYpGlCOCKLLv9H3tmiNoTpcFF7F+1vb1QgbekNgnLlgvfKOfrE OZFKROCwJ+4Dh9AKsWr2ZhTbG6lfWTbk5QBrrreOMOUbINEmr9+ncDNzytUg1VYukU VtKrfA4fWPJSjG94bNM6AxKG7W4waC4yzJNdPcng= Message-ID: <0147972a72bc13f3629de8a32dee6f1f308994b5.camel@HansenPartnership.com> Subject: Re: [PATCH 000/141] Fix fall-through warnings for Clang From: James Bottomley To: Joe Perches , Kees Cook , Jakub Kicinski Cc: "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, amd-gfx@lists.freedesktop.org, bridge@lists.linux-foundation.org, ceph-devel@vger.kernel.org, cluster-devel@redhat.com, coreteam@netfilter.org, devel@driverdev.osuosl.org, dm-devel@redhat.com, drbd-dev@lists.linbit.com, dri-devel@lists.freedesktop.org, GR-everest-linux-l2@marvell.com, GR-Linux-NIC-Dev@marvell.com, intel-gfx@lists.freedesktop.org, intel-wired-lan@lists.osuosl.org, keyrings@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-acpi@vger.kernel.org, linux-afs@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-atm-general@lists.sourceforge.net, linux-block@vger.kernel.org, linux-can@vger.kernel.org, linux-cifs@vger.kernel.org, linux-crypto@vger.kernel.org, linux-decnet-user@lists.sourceforge.net, linux-ext4@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-geode@lists.infradead.org, linux-gpio@vger.kernel.org, linux-hams@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, linux-ide@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-integrity@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sctp@vger.kernel.org, linux-security-module@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, nouveau@lists.freedesktop.org, op-tee@lists.trustedfirmware.org, oss-drivers@netronome.com, patches@opensource.cirrus.com, rds-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, samba-technical@lists.samba.org, selinux@vger.kernel.org, target-devel@vger.kernel.org, tipc-discussion@lists.sourceforge.net, usb-storage@lists.one-eyed-alien.net, virtualization@lists.linux-foundation.org, wcn36xx@lists.infradead.org, x86@kernel.org, xen-devel@lists.xenproject.org, linux-hardening@vger.kernel.org, Nick Desaulniers , Nathan Chancellor , Miguel Ojeda Date: Sun, 22 Nov 2020 11:12:30 -0800 In-Reply-To: References: <20201120105344.4345c14e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <202011201129.B13FDB3C@keescook> <20201120115142.292999b2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <202011220816.8B6591A@keescook> <9b57fd4914b46f38d54087d75e072d6e947cb56d.camel@HansenPartnership.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, 2020-11-22 at 10:25 -0800, Joe Perches wrote: > On Sun, 2020-11-22 at 10:21 -0800, James Bottomley wrote: > > Please tell me our reward for all this effort isn't a single > > missing error print. > > There were quite literally dozens of logical defects found > by the fallthrough additions. Very few were logging only. So can you give us the best examples (or indeed all of them if someone is keeping score)? hopefully this isn't a US election situation ... James