Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp46758pxu; Tue, 24 Nov 2020 18:09:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQzo6sQMUAqCLb/CvVPyNdR4YDg3hlgQ8ClvEMW+D0DCy9tfH+uRdCFi/QPRmT/544sK/F X-Received: by 2002:a17:906:b2cf:: with SMTP id cf15mr1179957ejb.525.1606270194170; Tue, 24 Nov 2020 18:09:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606270194; cv=none; d=google.com; s=arc-20160816; b=qvqXbxMd9/VuTguYLxR9BOuZR4FBoAWpf6bLGNofyX58YT7A+IKt+LCsx9h4AVBARs fSdUzm85PReW3pgJS2SnWhNE/24u3rk/R+dwTDujx0rTkPDiT4jqYWtfUxDj4mKIIsNU U4PxJAegauTjUmzpPNvN0YKklp16maCeICO6C9bZIUrT4/ui1f4WEuBO2BAnyvFBUr/r 4ufqVE+IP288CJ+dzge8kLH7rsRr8hUQ3t6j804WspPj0LbLg7yeVon6rwMBGGiBGbdJ 6DKsYoJJZqLA3QfLW3EehGmzDjPEhELDeiJniz3y/++EscqJ9F6Lel9ntliLvAlWzYBO 4Huw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=kW5ukZ+4XieOrj46zD/jIyOr6boy+rCZW7xgzBGe2c4=; b=FrQVGzMCGoW4d5EweO4cio7/kbmBWCO/CYhd9IpiX4WYolXmhOcO8opDRejMshkWlj Ezt4A7N6RdYuTvaGB44nNHxan396mQvrDOiFo1F0XsxcNPomj146/n8JmZJ9+FfPLjon 6aNbLYr1dABA64Ck7uTZ3uJVsU8GxmjGLESCa2TZbcxPszseFaqJAW4OZl+clpAZMYrn cyEPaSVDXKpPqLHfE6wfUAj/d8Wz+7/7XCONtfmwMAifyNE09Veu6xygk4PSIwFOSwoZ ro9n1FO0pQD/MU0PPnILEJxAjQOX/KrhGaNAkG0dMmzzmqNlpRec8DlKG4RvNSgPRRjL irsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oJOu74+D; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bq27si433643ejb.231.2020.11.24.18.09.22; Tue, 24 Nov 2020 18:09:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oJOu74+D; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727105AbgKYCFz (ORCPT + 99 others); Tue, 24 Nov 2020 21:05:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:36930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726155AbgKYCFy (ORCPT ); Tue, 24 Nov 2020 21:05:54 -0500 Received: from kernel.org (unknown [104.132.1.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 00E362067D; Wed, 25 Nov 2020 02:05:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606269954; bh=kW5ukZ+4XieOrj46zD/jIyOr6boy+rCZW7xgzBGe2c4=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=oJOu74+DecM/01avMUTCuX57S/ltJTnA/Lz5zCj818jNWFf16nVmM8iFzV2d9gwQ0 8N6XwIDI8zZrr6Bl4ObCcqYhCoAZk1lDYUqEwVeBPhQAJBIciIHQqNJeowl3w1eqRZ fO4n9Vhmiuq1zdDFLdfz66TScKxg3+inSBi8kngE= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20201119155233.3974286-5-thara.gopinath@linaro.org> References: <20201119155233.3974286-1-thara.gopinath@linaro.org> <20201119155233.3974286-5-thara.gopinath@linaro.org> Subject: Re: [Patch v2 4/6] drivers: crypto: qce: Fix SHA result buffer corruption issues. From: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org To: Thara Gopinath , agross@kernel.org, bjorn.andersson@linaro.org, davem@davemloft.net, herbert@gondor.apana.org.au, mturquette@baylibre.com, robh+dt@kernel.org Date: Tue, 24 Nov 2020 18:05:52 -0800 Message-ID: <160626995264.2717324.12789219183680216256@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Quoting Thara Gopinath (2020-11-19 07:52:31) > Partial hash was being copied into the final result buffer without the > entire message block processed. Depending on how the end user processes > this result buffer, errors vary from result buffer corruption to result > buffer poisoing. Fix this issue by ensuring that only the final hash value > is copied into the result buffer. >=20 > Reviewed-by: Bjorn Andersson > Signed-off-by: Thara Gopinath > --- Any Fixes tag?