Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH 0/4] crypto: add CRYPTO_TFM_REQ_DMA flag
To:     Ard Biesheuvel <ardb@kernel.org>,
        "Iuliana Prodan (OSS)" <iuliana.prodan@oss.nxp.com>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        "David S. Miller" <davem@davemloft.net>,
        Horia Geanta <horia.geanta@nxp.com>,
        Aymen Sghaier <aymen.sghaier@nxp.com>,
        Silvano Di Ninno <silvano.dininno@nxp.com>,
        Franck Lenormand <franck.lenormand@nxp.com>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-imx <linux-imx@nxp.com>
References: <20201125211311.2179-1-iuliana.prodan@oss.nxp.com>
 <CAMj1kXH=gyCz7NQXaAoNC4cf37t9E8znngyLFVPv+dO79=Z9oQ@mail.gmail.com>
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
Message-ID: <20b1493d-bfb6-d0bc-3b73-740b216db5f2@nxp.com>
Date:   Wed, 25 Nov 2020 23:39:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
In-Reply-To: <CAMj1kXH=gyCz7NQXaAoNC4cf37t9E8znngyLFVPv+dO79=Z9oQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.1.5] (188.26.141.79) by PR0P264CA0062.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.20 via Frontend Transport; Wed, 25 Nov 2020 21:39:24 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 6cbc35f8-8428-4a4f-318e-08d8918a94ba
X-MS-TrafficTypeDiagnostic: VI1PR04MB6941:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR04MB6941FC0F9AC341BA512BBEC08CFA0@VI1PR04MB6941.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: yY6awcMngtbp69XJLvLzIhpJ6dK5osz8O6ajRSmfekGxzGnkSRFGkXjmnxVm/q6i1/xR7/hCRSo31Z/JxGDa1rTRk/k8tlqvfjYslXsh7vrnX1V5x/Cp63TYo55OgYBtQUG/0Zzoh/jlzinjL8XFSUAUFZCO/WvqmitwjOJJlZP73LuJmmkLfrE0uJI9nRb5hm/mNnBzoVitiTBtme7nX41s7jt4Tjdx90afMUGT7s/KpX3IlmnZYXuedF5aHg5tcmTwR4YTcdaNk/KSR7P0fGyheTvC8MTHRKb+uOsRd+8JIz4/uj0WKxkz9vBNtgfm8KsKJXhVEGECbPfEynYfFSGZN9WY+OMI8iErz0u/s1UcClTuHN6/IJPVitrADACl/4v8oLHIuNVFi8zfoPcGAvEmMIf5w/hcNb2RGaWRh++XSi28nGHBGsQw+Nqf1LNtY3fub/6t5ODYRIwwbnpbhw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0402MB3712.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39860400002)(136003)(376002)(366004)(396003)(316002)(86362001)(5660300002)(16576012)(66476007)(66556008)(186003)(52116002)(66946007)(31686004)(110136005)(26005)(2906002)(8676002)(6486002)(54906003)(16526019)(4326008)(36756003)(44832011)(31696002)(83380400001)(8936002)(478600001)(53546011)(966005)(2616005)(956004)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?L2xncDNWWU5qSjdBemwwTTZDSUJrMHArVmExay8yUTByeTBrRnpwL1d6VnFE?=
 =?utf-8?B?dEtUMXBUWnY5bFBNSC96bDVYVnB4aUVycGE0MDluTERHT1lPWmFQaXZvWWRK?=
 =?utf-8?B?eDBIL0hQaU1oYVBmVXNPaXVZK3dHam9qcDNCWElSNmVWWHFFeSt3cGRqRzVy?=
 =?utf-8?B?M213Z2ZYU1RnaGZYTXF1cVN5Q0U2WG1Ha1cxZ242cWxDMEZKNWZZeWZaWXM5?=
 =?utf-8?B?MEg2MEpTMENERTNTcmFJK0JtUjRIYzVQYndlclhGNlZrLzdyMXBuTVUwMkFU?=
 =?utf-8?B?TkNHeVhMZ21HS2V1YWpuSCtGbEthcFBlcS9xTzFKM0tuRldQelpuYUw2dFBq?=
 =?utf-8?B?Kzloa3Zsa2NoR2RIcHRoWU91ZHlZMHNFaVZ2QklWWkgrbUVwK05PbXQ0SWN3?=
 =?utf-8?B?dVJPaytLK2cxQTVnMENVMG5BZXRPT0c4ZWpvM0hlMGJ3N1REdWlnVy9TcU8x?=
 =?utf-8?B?d255ZlIyTEFDcXZxT0VxUjBMNHZPanNZdGJYRm5SNXNvaFI2TDhmK3BWK1Uz?=
 =?utf-8?B?ZEZnaGVlVW41VU5BL2oyeUl1ZFhta3RxMHBCU3FhaXROMTI2VzZxbklqVnVo?=
 =?utf-8?B?VTRhc3o4SUlTcUZqQ0VzM3NVdlZJUkN1anluNlJuRjRxdkowYWpKUnVzTGli?=
 =?utf-8?B?dGl4dE1sRzF5MDFUQ1E2M2RtVzcvbG5lZ0kyOGJUekd3emxKSGtWZWFjTlpq?=
 =?utf-8?B?MXpPSHVpcjJrUkZUb2E1S1FiaGl4Q1orL04vRzRnZzJQeHp5MDFhRTdkU2V3?=
 =?utf-8?B?Q2FjMzBxN2gxRGRHRkRTYlZhUW96ZGx2emFKUDI5WFRPUVpIdUNLalB6bGRD?=
 =?utf-8?B?MFZheTMwbUJCQ1h5RWNWa2JZN1U1WEJsS2YxQlZIcGl1b0ZpcndpQ3pYTmNR?=
 =?utf-8?B?SDdDTXo0KzFIWXNXcW5xK1pyc3pwTHEwUkU3U3JwSW14Uy8vMFcyRnZpbEpn?=
 =?utf-8?B?Nmo1c25sSWkrMENzTzNwOHZYR0FteEZ3dWZ0QXRZbllXOGVOcFRLbk54RXBj?=
 =?utf-8?B?R0lpK25vQ0dLdEtoNld3dU1rMGhhR3FjNUFaY2xmeGhPUUtKMzdWaUo3UUJO?=
 =?utf-8?B?aHgybE81a25LUkxNSGhMYmtiWlVnVlRNYVE1dnVrMWFvUDllOHBrTzFJV0I4?=
 =?utf-8?B?V1RVUjdsSEk3WE9RVy8yY0I0RTJ0OHB2YmpyNnRlWS9iY3FFaGhnQkMrdksv?=
 =?utf-8?B?ejhUNjkycXpBUmdVYTVnK0VXQ0NaQzNVelNiTnJNN3FKMlJ3UlJRNTk5Ykta?=
 =?utf-8?B?UDRjQ1g2aVFnZWg0NkZKSTE3eE9ocmtMM0ltRk53UW5NUk54K1dma014ODhD?=
 =?utf-8?Q?yeK5RvUw3aVLxPW8qn44mz5IwvMUYByIMy?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cbc35f8-8428-4a4f-318e-08d8918a94ba
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3712.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2020 21:39:26.1658
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DsoPVE3fCzm7XXcKn3Sh9LspBmbAAlRK34JDElzxl3bV1JBELPGaTr5V4zHkIGe/lBY24aQzNCIANoPHvVRs0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6941
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 11/25/2020 11:16 PM, Ard Biesheuvel wrote:
> On Wed, 25 Nov 2020 at 22:14, Iuliana Prodan (OSS)
> <iuliana.prodan@oss.nxp.com> wrote:
>>
>> From: Iuliana Prodan <iuliana.prodan@nxp.com>
>>
>> Add the option to allocate the crypto request object plus any extra space
>> needed by the driver into a DMA-able memory.
>>
>> Add CRYPTO_TFM_REQ_DMA flag to be used by backend implementations to
>> indicate to crypto API the need to allocate GFP_DMA memory
>> for private contexts of the crypto requests.
>>
> 
> These are always directional DMA mappings, right? So why can't we use
> bounce buffering here?
> 
The idea was to avoid allocating any memory in crypto drivers.
We want to be able to use dm-crypt with CAAM, which needs DMA-able 
memory and increasing reqsize is not enough.
It started from here 
https://lore.kernel.org/linux-crypto/71b6f739-d4a8-8b26-bf78-ce9acf9a0f99@nxp.com/T/#m39684173a2f0f4b83d8bcbec223e98169273d1e4

>> For IPsec use cases, CRYPTO_TFM_REQ_DMA flag is also checked in
>> esp_alloc_tmp() function for IPv4 and IPv6.
>>
>> This series includes an example of how a driver can use
>> CRYPTO_TFM_REQ_DMA flag while setting reqsize to a larger value
>> to avoid allocating memory at crypto request runtime.
>> The extra size needed by the driver is added to the reqsize field
>> that indicates how much memory could be needed per request.
>>
>> Iuliana Prodan (4):
>>    crypto: add CRYPTO_TFM_REQ_DMA flag
>>    net: esp: check CRYPTO_TFM_REQ_DMA flag when allocating crypto request
>>    crypto: caam - avoid allocating memory at crypto request runtime for
>>      skcipher
>>    crypto: caam - avoid allocating memory at crypto request runtime for
>>      aead
>>
>>   drivers/crypto/caam/caamalg.c | 130 +++++++++++++++++++++++++---------
>>   include/crypto/aead.h         |   4 ++
>>   include/crypto/akcipher.h     |  21 ++++++
>>   include/crypto/hash.h         |   4 ++
>>   include/crypto/skcipher.h     |   4 ++
>>   include/linux/crypto.h        |   1 +
>>   net/ipv4/esp4.c               |   7 +-
>>   net/ipv6/esp6.c               |   7 +-
>>   8 files changed, 144 insertions(+), 34 deletions(-)
>>
>> --
>> 2.17.1
>>