Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp498521pxu; Thu, 26 Nov 2020 04:17:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJxibReqQhBJFOXAikIJX+r0cuK9cWdCkGIsFPL4PN4fMVtxtDjBxM7F/zn3B06A2D2GYQCr X-Received: by 2002:a17:906:e254:: with SMTP id gq20mr2354110ejb.520.1606393039777; Thu, 26 Nov 2020 04:17:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606393039; cv=none; d=google.com; s=arc-20160816; b=kMjrPniP3QdYnK/7BhNMK3ubHJuorMdN6QKqP1soz2lK/wT4XDNvAp7J2Oo1wIJJwO rt3eTewLynrfm1k9fziNgmwe0t7WedryMTr64LD5+C3rJojrJfhoUVRMfrzQIy3uw/o5 ghLt5yLQASoZjvat0cYl6lNp1l/vaQGzyl6PpZXpkM05KgWljYJ5sYrYTRQznNdl02Yk JIh9HEnUKEhs5W7T/jR9wFGCvkC1Jth5mg17mQesxB+glY8b28K8wP1P0QULXKS9DAf5 cOHHr/aYd5FO3z+W8BCxzj+e1L3R3DXxG5XaAeq9RW3nKU0nhGeKCy8CuSDqZBygR64/ HU5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:ironport-sdr :ironport-sdr; bh=FECcQFJ5w+sAp8lODrQ+R2QyWvX5qFF8nmMdicl0fqE=; b=Jh/pXPAk8jciT35blEMinZSzWmtLmNmOfOB/fn7EV5M3I2+7LmG+PTjiwcPxo8DMDz nk33opaQgTXSA0mjtm1sv4/9XcoE460dWHcOREORSYeuuDm1NcxUDA/6dg65Gq24YFPu Tfha/AKiwHYq37cH4gVpxPFLdAoxOJqUJ2az4j/RaJ4GfAXVd4Y6jQfKsiX7FOjyIcYH YZePqL5gBsNIzQk2ngzQBBMc35/Ijrlr/44KWRo2o243wuWcc5qgTWg+Xn+0YI5q8jHx QNbZcd6W3NWJ+d0GSkGgjGWhuuoMS8WaO2hyhk9d4zkNIPbah/nmRPCdFbKCnjB5T70i A5zA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y23si2965333eds.334.2020.11.26.04.16.56; Thu, 26 Nov 2020 04:17:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388375AbgKZMET (ORCPT + 99 others); Thu, 26 Nov 2020 07:04:19 -0500 Received: from mga06.intel.com ([134.134.136.31]:7769 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726321AbgKZMET (ORCPT ); Thu, 26 Nov 2020 07:04:19 -0500 IronPort-SDR: Ay13JN+vTm1NrpwxE71aBO18W8gPPl+V7BtBwxn+rqqjk3PUBhjhotMr8VaneGRdhjJucG5Dd1 MfXmtS0NVh/A== X-IronPort-AV: E=McAfee;i="6000,8403,9816"; a="233881451" X-IronPort-AV: E=Sophos;i="5.78,372,1599548400"; d="scan'208";a="233881451" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2020 04:04:18 -0800 IronPort-SDR: Rdr0vgWgv4OAA1iUSSQd7PXQpUoWlTqP4uRbIuN5+eKpIQrJVZMMV8hzIQOpdbf1xDp+Jwonm5 lY8Az+ZW/xOg== X-IronPort-AV: E=Sophos;i="5.78,372,1599548400"; d="scan'208";a="333354621" Received: from silpixa00400314.ir.intel.com (HELO silpixa00400314) ([10.237.222.51]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2020 04:04:16 -0800 Date: Thu, 26 Nov 2020 12:04:08 +0000 From: Giovanni Cabiddu To: Christophe JAILLET Cc: "herbert@gondor.apana.org.au" , "davem@davemloft.net" , "andriy.shevchenko@linux.intel.com" , "Trahe, Fiona" , "Ziemba, Wojciech" , "Chiappero, Marco" , qat-linux , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH] crypto: qat - Use dma_set_mask_and_coherent to simplify code Message-ID: <20201126120408.GA21666@silpixa00400314> References: <20201121071359.1320167-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201121071359.1320167-1-christophe.jaillet@wanadoo.fr> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi Christophe, On Sat, Nov 21, 2020 at 07:13:59AM +0000, Christophe JAILLET wrote: > 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by > an equivalent 'dma_set_mask_and_coherent()' which is much less verbose. > > While at it, also remove some unless extra () in the 32 bits case. > > Signed-off-by: Christophe JAILLET > --- > Instead of returning -EFAULT, we could also propagate the error returned > by dma_set_mask_and_coherent() I'm going to re-submit implementing the comment above and also including qat_4xxx. Regards, -- Giovanni