Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1160286pxu; Fri, 27 Nov 2020 00:50:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJxeRxY5Bcy43ZedNrg/J7EBHvTztxT7t838Ut10/H8uqpmAEGFpVQGnNrZICNHfcFFaLt7A X-Received: by 2002:a17:906:971a:: with SMTP id k26mr5242700ejx.279.1606467000784; Fri, 27 Nov 2020 00:50:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606467000; cv=none; d=google.com; s=arc-20160816; b=mForENY2wqM5IQUElsJ63zaGtKhxM6gyZVLfBGoJTU5NtuHyuxDTivbzr+KxP/e1mc 4aJdm/PdUHUOqswWBBOtDyRgfjc36phFDqF0OLm2b7H8TFdIhBJuSqEiN2i4cGzXI1+A ZG9Ei4AaEy8KxzvGVED9X7KZWjSXBMTzyB3aqPVPoh1Tbcd6gO56k50EacN+qYN0IwHt 1v6BAdqUsu2MjG6EJALayknIAuhmcNn58rtzu2JbMyaP6CB0jHlZEt8yBXdtRoWapsgN Ix8Z0AFDyr8oLI5afb82BSJTRDk2/TPTOig1TlGe6LEj4aLof+xWupO4gR2jI/dpgQbc nZhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=ggaTD4frhQjKwfC0Yp4ApsfqMFQSejURHj152VJ6+yE=; b=CwK6J62zD0rfo16wzACtPgEaxfKjvTf4ou0ugBhNnzGV1zt2wKROv4CczcqzRWpNnt THrJTuOjgSYNPa30RtOrE0m42cYHzpwrMwyMdCENG3lt+E+c4eScoAY8hdmPE3yTLQiB Y2l0ft/gVqryqzC0MmJ9KIwlj6pYh121mPswVOCtb/2l0xLGdVkD01ErZwo7XfUasGlJ kjpQSGQbZ+mYK3bEIRM4Xv5rX7d+/wywHImCkbo8LoNzJzrdynr0BgYVIRbHOHJYVXgy Ao3+A6tD76XjPjd9bPXkASiia4if1t8RDD0//JbMNFfNQ5Xcr2apkj7LLFltf6LwVGxf juHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u17si4702355edv.131.2020.11.27.00.49.37; Fri, 27 Nov 2020 00:50:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392517AbgK0F5f (ORCPT + 99 others); Fri, 27 Nov 2020 00:57:35 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:33338 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392514AbgK0F5f (ORCPT ); Fri, 27 Nov 2020 00:57:35 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kiWkp-0000gM-Kk; Fri, 27 Nov 2020 16:57:12 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 27 Nov 2020 16:57:11 +1100 Date: Fri, 27 Nov 2020 16:57:11 +1100 From: Herbert Xu To: Corentin Labbe Cc: arnd@arndb.de, davem@davemloft.net, jernej.skrabec@siol.net, mripard@kernel.org, wens@csie.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v3 6/7] crypto: sun4i-ss: enabled stats via debugfs Message-ID: <20201127055711.GA29694@gondor.apana.org.au> References: <20201116135345.11834-1-clabbe@baylibre.com> <20201116135345.11834-7-clabbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201116135345.11834-7-clabbe@baylibre.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Nov 16, 2020 at 01:53:44PM +0000, Corentin Labbe wrote: > > +#ifdef CONFIG_CRYPTO_DEV_SUN4I_SS_DEBUG > + /* Ignore error of debugfs */ > + ss->dbgfs_dir = debugfs_create_dir("sun4i-ss", NULL); > + ss->dbgfs_stats = debugfs_create_file("stats", 0444, ss->dbgfs_dir, ss, > + &sun4i_ss_debugfs_fops); > +#endif Since you didn't use ifdefs in the struct, there is no need to use ifdefs here either. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt