Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Qinglang Miao <miaoqinglang@huawei.com>
Cc:     "Krzysztof Kozlowski" <krzk@kernel.org>,
        <linux-samsung-soc@vger.kernel.org>,
        <linux-crypto@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwrng: exynos - fix reference leak in exynos_trng_probe
Date:   Fri, 27 Nov 2020 15:26:22 +0100
In-Reply-To: <20201127094446.121277-1-miaoqinglang@huawei.com> (Qinglang
        Miao's message of "Fri, 27 Nov 2020 17:44:46 +0800")
Message-ID: <dleftjlfemg9kh.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <20201127094446.121277-1-miaoqinglang@huawei.com>
        <CGME20201127142637eucas1p1746be156c43e789b48b5b78b9b212a33@eucas1p1.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2020-11-27 pi=C4=85 17:44>, when Qinglang Miao wrote:
> pm_runtime_get_sync will increment pm usage counter even it
> failed. Forgetting to putting operation will result in a
> reference leak here.
>
> A new function pm_runtime_resume_and_get is introduced in
> [0] to keep usage counter balanced. So We fix the reference
> leak by replacing it with new funtion.
>
> [0] dd8088d5a896 ("PM: runtime: Add  pm_runtime_resume_and_get to deal wi=
th usage counter")
>
> Fixes: 6cd225cc5d8a ("hwrng: exynos - add Samsung Exynos True RNG driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
>  drivers/char/hw_random/exynos-trng.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_rando=
m/exynos-trng.c
> index 8e1fe3f8d..666246bc8 100644
> --- a/drivers/char/hw_random/exynos-trng.c
> +++ b/drivers/char/hw_random/exynos-trng.c
> @@ -132,7 +132,7 @@ static int exynos_trng_probe(struct platform_device *=
pdev)
>  		return PTR_ERR(trng->mem);
>=20=20
>  	pm_runtime_enable(&pdev->dev);
> -	ret =3D pm_runtime_get_sync(&pdev->dev);
> +	ret =3D pm_runtime_resume_and_get(&pdev->dev);
>  	if (ret < 0) {
>  		dev_err(&pdev->dev, "Could not get runtime PM.\n");
>  		goto err_pm_get;

Thanks. I suppose you may use the new function exynos_trng_resume(),
remove everything and leave only

return pm_runtime_resume_and_get(dev);

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAl/BDI4ACgkQsK4enJil
gBC84gf/RQRlC16akSq8M1l6MzThboXOhm8hf0nf1eIQQEJAzjURHJHDaSZNe7cn
M8Mi5zZ88C/MJ8on3YAQLTiS2i2Qpo8CZmFkKwMJT8TKYAeagn8noM6b72A1TROO
Ph0TxTTguS1i0p8dI2JjnF+yQ7Yt82HqfF0hGEUujkHqnI+PuAICRE9GBEoHOlDj
1hBXKMntWIUt6uhrKmaeZUN8FMaSMb75FckWyqImxtFGR590hfElOzxbTV7JQOkQ
WEASOak/L0qvvl7CWB/QTOjdlI2I/HfzfNCARiUaT5oah65joBCs6cYKKRA4jDXQ
rsf1EmUv1wEjI3zQfhJzILCWJ0YKuQ==
=mR4q
-----END PGP SIGNATURE-----
--=-=-=--