Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201117133214.29114-1-ardb@kernel.org> <CAMuHMdUzFLk=oYo1aK80d0H-qZ1_1BcdSULkYCxBnLWT_qUR2A@mail.gmail.com>
In-Reply-To: <CAMuHMdUzFLk=oYo1aK80d0H-qZ1_1BcdSULkYCxBnLWT_qUR2A@mail.gmail.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Mon, 30 Nov 2020 10:43:37 +0100
Message-ID: <CAMj1kXGuxuB2iv-k60PCSkmec-=_+kKRnE3XSXeqNLihqrH9vQ@mail.gmail.com>
Subject: Re: [PATCH v3 0/4] crypto: aegis128 enhancements
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        Eric Biggers <ebiggers@kernel.org>,
        Ondrej Mosnacek <omosnacek@gmail.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux-Next <linux-next@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 30 Nov 2020 at 10:37, Geert Uytterhoeven <geert@linux-m68k.org> wro=
te:
>
> Hi Ard,
>
> On Tue, Nov 17, 2020 at 2:38 PM Ard Biesheuvel <ardb@kernel.org> wrote:
> > This series supersedes [0] '[PATCH] crypto: aegis128/neon - optimize ta=
il
> > block handling', which is included as patch #3 here, but hasn't been
> > modified substantially.
> >
> > Patch #1 should probably go to -stable, even though aegis128 does not a=
ppear
> > to be widely used.
> >
> > Patches #2 and #3 improve the SIMD code paths.
> >
> > Patch #4 enables fuzz testing for the SIMD code by registering the gene=
ric
> > code as a separate driver if the SIMD code path is enabled.
> >
> > Changes since v2:
> > - add Ondrej's ack to #1
> > - fix an issue spotted by Ondrej in #4 where the generic code path woul=
d still
> >   use some of the SIMD helpers
> >
> > Cc: Ondrej Mosnacek <omosnacek@gmail.com>
> > Cc: Eric Biggers <ebiggers@kernel.org>
> >
> > [0] https://lore.kernel.org/linux-crypto/20201107195516.13952-1-ardb@ke=
rnel.org/
> >
> > Ard Biesheuvel (4):
> >   crypto: aegis128 - wipe plaintext and tag if decryption fails
> >   crypto: aegis128/neon - optimize tail block handling
> >   crypto: aegis128/neon - move final tag check to SIMD domain
>
> crypto/aegis128-core.c: In function =E2=80=98crypto_aegis128_decrypt=E2=
=80=99:
> crypto/aegis128-core.c:454:40: error: passing argument 2 of
> =E2=80=98crypto_aegis128_process_crypt=E2=80=99 from incompatible pointer=
 type
> [-Werror=3Dincompatible-pointer-types]
>   454 |    crypto_aegis128_process_crypt(NULL, req, &walk,
>       |                                        ^~~
>       |                                        |
>       |                                        struct aead_request *
> crypto/aegis128-core.c:335:29: note: expected =E2=80=98struct skcipher_wa=
lk *=E2=80=99
> but argument is of type =E2=80=98struct aead_request *=E2=80=99
>   335 |       struct skcipher_walk *walk,
>       |       ~~~~~~~~~~~~~~~~~~~~~~^~~~
> crypto/aegis128-core.c:454:45: error: passing argument 3 of
> =E2=80=98crypto_aegis128_process_crypt=E2=80=99 from incompatible pointer=
 type
> [-Werror=3Dincompatible-pointer-types]
>   454 |    crypto_aegis128_process_crypt(NULL, req, &walk,
>       |                                             ^~~~~
>       |                                             |
>       |                                             struct skcipher_walk =
*
> crypto/aegis128-core.c:336:14: note: expected =E2=80=98void (*)(struct
> aegis_state *, u8 *, const u8 *, unsigned int)=E2=80=99 {aka =E2=80=98voi=
d (*)(struct
> aegis_state *, unsigned char *, const unsigned char *, unsigned int)=E2=
=80=99}
> but argument is of type =E2=80=98struct skcipher_walk *=E2=80=99
>   336 |       void (*crypt)(struct aegis_state *state,
>       |       ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   337 |              u8 *dst, const u8 *src,
>       |              ~~~~~~~~~~~~~~~~~~~~~~~
>   338 |              unsigned int size))
>       |              ~~~~~~~~~~~~~~~~~~
> crypto/aegis128-core.c:454:4: error: too many arguments to function
> =E2=80=98crypto_aegis128_process_crypt=E2=80=99
>   454 |    crypto_aegis128_process_crypt(NULL, req, &walk,
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> crypto/aegis128-core.c:334:5: note: declared here
>   334 | int crypto_aegis128_process_crypt(struct aegis_state *state,
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[1]: *** [scripts/Makefile.build:283: crypto/aegis128-core.o] Error 1
>
> >   crypto: aegis128 - expose SIMD code path as separate driver
>
> Fixes the above, but causes
>
> ERROR: modpost: "crypto_aegis128_update_simd" [crypto/aegis128.ko] undefi=
ned!
>
> as reported by noreply@ellerman.id.au for m68k/defconfig and
> m68k/sun3_defconfig.
> (neon depends on arm).
>

Thanks for the report.

It seems like GCC is not optimizing away calls to routines that are
unreachable. Which GCC version are you using?