Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201015110241.89676-1-tianjia.zhang@linux.alibaba.com>
 <20201015120504.GA12976@gondor.apana.org.au> <f6d98764-dde8-6f40-c0e7-9eb5b087d713@linux.alibaba.com>
 <20201130022422.GA21049@gondor.apana.org.au> <df22e694-0a2e-811a-412e-269303c5d27d@linux.alibaba.com>
In-Reply-To: <df22e694-0a2e-811a-412e-269303c5d27d@linux.alibaba.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Tue, 1 Dec 2020 09:37:02 +0100
Message-ID: <CAMj1kXFUG8Q8YB4M1GBsjcehrSMH8DYcPu4dFebxVAiZdew2gA@mail.gmail.com>
Subject: Re: [PATCH] crypto: ecrdsa - use subsys_initcall instead of module_init
To:     Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        Vitaly Chikunov <vt@altlinux.org>,
        "David S. Miller" <davem@davemloft.net>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 30 Nov 2020 at 07:58, Tianjia Zhang
<tianjia.zhang@linux.alibaba.com> wrote:
>
>
>
> On 11/30/20 10:24 AM, Herbert Xu wrote:
> > On Mon, Nov 30, 2020 at 10:21:56AM +0800, Tianjia Zhang wrote:
> >>
> >>> That is true only if there are non-generic implementations of
> >>> the algorithms, which is not the case here.  Please explain the
> >>> real reason why this is needed.
> >>
> >> This is a generic algorithm, the author Vitaly Chikunov has also confi=
rmed
> >> it, please consider this patch again.
> >
> > As I said, the generic algorithm only needs to be loaded early *if*
> > there are non-generic implementations.
> >
> > Cheers,
> >
>
> For ecrdsa, there is no reason to advance the initialization to
> subsys_init, this is just to make code clean up to have algorithm
> initialization uniform with other implementations.
>
> It=E2=80=99s just that I think that in the commit c4741b230597 ("crypto: =
run
> initcalls for generic implementations earlier"), the modification to
> ecrdsa happened to be omitted, because from the point of commit time, it
> was submitted at the same time as the ecrdsa commits, and it may happen
> to be omitted for ecrdsa.
>

Whether or not it is a generic algorithm is irrelevant.

What is relevant is whether any other implementations exist of the
same algorithm, because in this case, the generic implementation must
be available earlier, so that it can be used for testing the other
implementation.

This concern does not apply for ecrdsa, so this patch is unnecessary.