Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Qinglang Miao <miaoqinglang@huawei.com>
Cc:     "Krzysztof Kozlowski" <krzk@kernel.org>,
        <linux-samsung-soc@vger.kernel.org>,
        <linux-crypto@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] hwrng: exynos - fix reference leak in
 exynos_trng_probe
Date:   Wed, 02 Dec 2020 11:14:10 +0100
In-Reply-To: <20201130130118.51339-1-miaoqinglang@huawei.com> (Qinglang
        Miao's message of "Mon, 30 Nov 2020 21:01:18 +0800")
Message-ID: <dleftjczzsecr1.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <20201130130118.51339-1-miaoqinglang@huawei.com>
        <CGME20201202101424eucas1p103b713a5fe6faae36ce32180570c46c4@eucas1p1.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2020-11-30 pon 21:01>, when Qinglang Miao wrote:
> pm_runtime_get_sync will increment pm usage counter even
> failed. Forgetting to putting operation will result in a
> reference leak here.
>
> Replace it with pm_runtime_resume_and_get to keep usage
> counter balanced. I remove err_clock label at the same.
>
> Fixes: 6cd225cc5d8a ("hwrng: exynos - add Samsung Exynos True RNG driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Suggested-by: Lukasz Stelmach <l.stelmach@samsung.com>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
>  v2: remobe useless label as Lukasz suggested.

That is good too, but I meant using pm_runtime_resume_and_get() in
exynos_trng_resume() too. Please take a look at that function.

>
>  drivers/char/hw_random/exynos-trng.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_rando=
m/exynos-trng.c
> index 8e1fe3f8d..ffebb72e4 100644
> --- a/drivers/char/hw_random/exynos-trng.c
> +++ b/drivers/char/hw_random/exynos-trng.c
> @@ -132,7 +132,7 @@ static int exynos_trng_probe(struct platform_device *=
pdev)
>  		return PTR_ERR(trng->mem);
>=20=20
>  	pm_runtime_enable(&pdev->dev);
> -	ret =3D pm_runtime_get_sync(&pdev->dev);
> +	ret =3D pm_runtime_resume_and_get(&pdev->dev);
>  	if (ret < 0) {
>  		dev_err(&pdev->dev, "Could not get runtime PM.\n");
>  		goto err_pm_get;
> @@ -142,13 +142,13 @@ static int exynos_trng_probe(struct platform_device=
 *pdev)
>  	if (IS_ERR(trng->clk)) {
>  		ret =3D PTR_ERR(trng->clk);
>  		dev_err(&pdev->dev, "Could not get clock.\n");
> -		goto err_clock;
> +		goto err_pm_get;
>  	}
>=20=20
>  	ret =3D clk_prepare_enable(trng->clk);
>  	if (ret) {
>  		dev_err(&pdev->dev, "Could not enable the clk.\n");
> -		goto err_clock;
> +		goto err_pm_get;
>  	}
>=20=20
>  	ret =3D devm_hwrng_register(&pdev->dev, &trng->rng);
> @@ -164,9 +164,6 @@ static int exynos_trng_probe(struct platform_device *=
pdev)
>  err_register:
>  	clk_disable_unprepare(trng->clk);
>=20=20
> -err_clock:
> -	pm_runtime_put_sync(&pdev->dev);
> -
>  err_pm_get:
>  	pm_runtime_disable(&pdev->dev);

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAl/HaPIACgkQsK4enJil
gBD+uQf8D9x1XK5zm+GHPDtFS0L7rBggFvKmJhqXqVoDhLFX4QFJZO9M7MsDwUPT
FqPOYA5nmHr0m/YfqEFGhKnF89eJv9us+PkBGfm0YjAHUmbwBeb5Mp1TH6zJ2v2n
FWsHenglG6gRY6I4V1p1caRBtbtzgxadequIluMDBlZqM7bdbhGD1WDZ+P+y92wP
nBO/FECD2S6S5m0St7pUEsK+ZpXtvn2bo9UgvNx2ZCKe9T4yNwJCpdLyeQSKxdnZ
RYesge7F9MeJiex6/BrUMYlYXmWSu+SzDHBgGJdHUm3egHN86SR0NkWxRwSxcyux
uRWLL7UcmConTpEac3QaCN1mlB0pYw==
=IU3L
-----END PGP SIGNATURE-----
--=-=-=--