Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp158713pxu; Thu, 3 Dec 2020 23:17:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJzw47vnicZUQOLSjj98LubiQrnHNp3w++mjQyScf4dy/QJIR/w/DY2aTP2RQk0QKFJ6IpsB X-Received: by 2002:a17:906:a85:: with SMTP id y5mr5803102ejf.296.1607066262726; Thu, 03 Dec 2020 23:17:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607066262; cv=none; d=google.com; s=arc-20160816; b=jp2yuJRDWT6gskNK7KliBFnzhs8yFZEbQ09XiUkubAQVGU4xIAZoEee0otEo9m1gUK ibkQoUX8URV+PLJHCXEkghFbuwWnyNA7+T43uesNDwCZZ2E5Pm7qt0W5deJ8Fw9Z/MuQ fNgpRa+uyzABtmnx39yHHOk0wzF9V01SiBUwNqgJar4z5QbXWgppp+uZIx4G5A70G1JL lnSTwK/KfqgeHL4+WrgBmTtqxd7mcooScJr0fP3K0eiketAm6c5lAhSNp6yARY3iyoRc QxNm8u0kYHhOISYrdvnSek+YJaQW9KJ2I2DzwNKNTQX14p8uFZaDjKpBEqsZ305CAv4+ x2rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=x2P9QLoyRlwGAOWdQJ25oJv2u5E2m6I0R922DYs3PNA=; b=ZwEY9B/k5Qm3gPZ6aBVipBvoKqJm1eGssa0vi6lKO6eConX/53XzPL5z+J1b+23Wpd w4r4b7xQ6v6bcJxt1oZ/QT+3U13QOjmGIXnxkEByUxn1W0UbM2uw731I1lI5eMe5GB4L 44Kl4JmXPh6evpQM/62WX1amydSf9t6jMix8pfBoqUcJwgQ+sTtODGKxOCyFX1kJn2ZK QMC8nekrv5cKZunuDogaYro+1yguwbUref88wHQCdX2rqnZTGHgcr9rivhi5rcpqOKYd HN8wzN1knl793sFhI/fUW1zHiHfeq3TP6FdbmAoUK4fu/CEjOb66NOHRgTm9mz+xkZv0 jthA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d7si845361ejk.78.2020.12.03.23.17.20; Thu, 03 Dec 2020 23:17:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727939AbgLDHQd (ORCPT + 99 others); Fri, 4 Dec 2020 02:16:33 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:60990 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727892AbgLDHQd (ORCPT ); Fri, 4 Dec 2020 02:16:33 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kl5Jh-0006dS-L3; Fri, 04 Dec 2020 18:15:46 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 04 Dec 2020 18:15:45 +1100 Date: Fri, 4 Dec 2020 18:15:45 +1100 From: Herbert Xu To: Uros Bizjak Cc: linux-crypto@vger.kernel.org, x86@kernel.org, Borislav Petkov , "H. Peter Anvin" Subject: Re: [PATCH] crypto: x86/sha512-intel: Use TEST %reg,%reg instead of CMP $0,%reg Message-ID: <20201204071545.GD31775@gondor.apana.org.au> References: <20201127095943.62292-1-ubizjak@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201127095943.62292-1-ubizjak@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Nov 27, 2020 at 10:59:43AM +0100, Uros Bizjak wrote: > CMP $0,%reg can't set overflow flag, so we can use shorter TEST %reg,%reg > instruction when only zero and sign flags are checked (E,L,LE,G,GE conditions). > > Signed-off-by: Uros Bizjak > Cc: Herbert Xu > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > --- > arch/x86/crypto/sha512-avx-asm.S | 2 +- > arch/x86/crypto/sha512-ssse3-asm.S | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt