Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp158997pxu; Thu, 3 Dec 2020 23:18:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJxqpIAOU143RZ1E7ICuGjshYj6IIvAHOR95zu51jun4eYQuodSMA0zi1sk11cjH8G9mDXJT X-Received: by 2002:a50:ee97:: with SMTP id f23mr6046621edr.311.1607066300833; Thu, 03 Dec 2020 23:18:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607066300; cv=none; d=google.com; s=arc-20160816; b=x8f2zACydrrC06aNw7rzyfi3Vm50HWh1v8xfGJXpNppMgjADPxAlWFlL2dr1+/oHDI r+ZujtVtTVczZByuxDEeZmEoRYPhMMyOnXISrpAN/fT5p28WsEmJ9tomV7vPze4ucqN4 AArbP8ASOiNjZzpt6Whk8J7H+UUxn1WpLsp+jFP63k+1nEvTvymDfHXNLmiFxD1+uVkK RFB6XT95GCc9UcP/Q/C28h7oxKQdjNnkBbXvYAfKdwITiVJ5Dy3KPOZ2xuxCQRoes+q1 CnFtePzr8bP1YRxtb1BKD9em5bdHjRA9faCDuRqU9BIaarnXzix21T+C+a/srvJWCIlV bsLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=HF2+jMBLT4fpHWtsvqBgVogvpymheccYnGge4C56cbA=; b=eKDY8Kj6JRr2aHao8u8+Bgx5VNMGFBB5qlq2bUdIxGcgSKCMwYwkzt4kMdA4IP/vhI nAmy5fYw694fupq9K/axFeUdDlYX1mixytvkTztYD6tFdRDjHMmtXVNc/KLMF3/ZtJGb wNYXiv0P8hjwMBBQy9dwFyqlX7BQBoIPgE7UjBzTEBHEvY1CHZtaaVpTRYjzuJyOleL0 p9s8knzWVfsEbeAPmBRHXq5dFhRftEZmGCPC0inMURynnkG36lns5OsFLzRXSfziwkwg yAdHlV33GT8MxCcG47U6O2T3vNB4YgLUF6wYkLAI6nW/0URUpraIS2HaQu6r3fRZuakp vm/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d7si845361ejk.78.2020.12.03.23.17.58; Thu, 03 Dec 2020 23:18:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728206AbgLDHQi (ORCPT + 99 others); Fri, 4 Dec 2020 02:16:38 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:60998 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727892AbgLDHQi (ORCPT ); Fri, 4 Dec 2020 02:16:38 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kl5Jm-0006fF-W5; Fri, 04 Dec 2020 18:15:52 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 04 Dec 2020 18:15:50 +1100 Date: Fri, 4 Dec 2020 18:15:50 +1100 From: Herbert Xu To: Uros Bizjak Cc: linux-crypto@vger.kernel.org, x86@kernel.org, Borislav Petkov , "H. Peter Anvin" Subject: Re: [PATCH] crypto: x86/poly1305-intel: Use TEST %reg,%reg instead of CMP $0,%reg Message-ID: <20201204071550.GE31775@gondor.apana.org.au> References: <20201127101812.72787-1-ubizjak@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201127101812.72787-1-ubizjak@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Nov 27, 2020 at 11:18:12AM +0100, Uros Bizjak wrote: > CMP $0,%reg can't set overflow flag, so we can use shorter TEST %reg,%reg > instruction when only zero and sign flags are checked (E,L,LE,G,GE conditions). > > Signed-off-by: Uros Bizjak > Cc: Herbert Xu > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > --- > arch/x86/crypto/poly1305-x86_64-cryptogams.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt