Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp159183pxu; Thu, 3 Dec 2020 23:18:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJw+8D3GPAciu3b8lzfBKRkaXd1s8PzDIYwZSzcV5gm73lLnPVG3ZmqyzNW/SVww8Udb0knN X-Received: by 2002:a17:906:6c2:: with SMTP id v2mr5895747ejb.387.1607066320081; Thu, 03 Dec 2020 23:18:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607066320; cv=none; d=google.com; s=arc-20160816; b=lBPkKPkyFzFYFjzmL1vP/0UgrGZMptP8Tv8KtUV9R6kOdGzHcmcrdQWiZJ2Pm8QNrt tjnwMPOekoZ3uLrlY61Ma6U77yDZFSlR4eZdvqg9zscZFtwsKGkaqUq5nC4fEPBO0dvp Q++gh+X8ifVTiGtzdkGz8XRhrTtvhIe8nOzxRLLDCadaeh2bFVI4bMI1ZDVTQq8WXcxn SNovDh+vKPCUcYkuX+msPiLPtKRBV0BwaHxQtE7iC81bdOtI1wZM3c8mmqGqEtUrr/On NSwZJBJ6qyCqvjS37szygKIV0e2YM6rIlL9GsYwvGJ+DtlaBGck0rP8rDNd+aNR7oqiG e1Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=gOm18pfANt7T5bXac8+ciT3OUHzehmroeNBNJnOMh1E=; b=qkN8uw46SifBlbwqFMdhzaJqkzgOZstyvWU0m+YO0jIfxxXfrd6bQfHvuMZ8J7XNOR qgCEnTttdPMSm/zlH+qKkUPm186HzE74nmFKyZib3Gla3BPhFOclemshXSqF1ML8/SrZ UYD0XMo/q6MhlQ00Q32O3aBPaa0jel1caz0TdHj3CZbmrYaC2qZDJVrYHbL/2sBAYqXl 8coRZNdhqLXRkzIe6gRkds0+HJjnDPfBqQGC6ylyJs35M+mY0hLF40YaoBqkCwXAEGRx 3lELhWQBBX1mpCIZAFt8UYOluSJ3HyKVK7HIo9hYVvgvmiZu2mkUfQ3naly8hNRaBQju DghQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hr14si879424ejc.396.2020.12.03.23.18.17; Thu, 03 Dec 2020 23:18:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728588AbgLDHQZ (ORCPT + 99 others); Fri, 4 Dec 2020 02:16:25 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:60982 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728462AbgLDHQY (ORCPT ); Fri, 4 Dec 2020 02:16:24 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kl5Jc-0006dM-UF; Fri, 04 Dec 2020 18:15:42 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 04 Dec 2020 18:15:40 +1100 Date: Fri, 4 Dec 2020 18:15:40 +1100 From: Herbert Xu To: Uros Bizjak Cc: linux-crypto@vger.kernel.org, x86@kernel.org, Borislav Petkov , "H. Peter Anvin" Subject: Re: [PATCH] crypto: x86/aesni-intel: Use TEST %reg,%reg instead of CMP $0,%reg Message-ID: <20201204071540.GC31775@gondor.apana.org.au> References: <20201127094452.7721-1-ubizjak@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201127094452.7721-1-ubizjak@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Nov 27, 2020 at 10:44:52AM +0100, Uros Bizjak wrote: > CMP $0,%reg can't set overflow flag, so we can use shorter TEST %reg,%reg > instruction when only zero and sign flags are checked (E,L,LE,G,GE conditions). > > Signed-off-by: Uros Bizjak > Cc: Herbert Xu > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > --- > arch/x86/crypto/aesni-intel_asm.S | 20 ++++++++++---------- > arch/x86/crypto/aesni-intel_avx-x86_64.S | 20 ++++++++++---------- > 2 files changed, 20 insertions(+), 20 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt