Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2841798pxu; Mon, 14 Dec 2020 12:11:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJwYOK/AlGindLteJ4ufcn/yYb8wPaNtZI0ACRpNHDGXyjr67pr167kgX9xvIgb3depXg6pH X-Received: by 2002:a05:6402:158:: with SMTP id s24mr27458325edu.19.1607976666602; Mon, 14 Dec 2020 12:11:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607976666; cv=none; d=google.com; s=arc-20160816; b=jejB68SQnCluR3h1rmOAABK/XNyjEg9Zx6R9VsgpcgZH761zvS3qPs3k7KRmxLFAwb SJRn32m2qByQrbO5PsKsAj5qqh6mulGtQ0JSvzfq/1N3iJ5Qql4aRJ0vYbl3gLFMDZEA m1zaDb4S/t/Eu2tRD6x/0fU30KgDy3B4XINn3o4Qp8DnnaPzdo4vNGoH8VqQJtbpPOY9 zY/T/cp+XDttu1A4mkLOd3h2iG9nJ9tTjS/5PYs81w9OS8P+mI49QH3rWEEmYFEm+bc2 mADnVbUEUkr3sqbOhJSo7Cs5t63lULl6z9BY+z+p7mhXRfloSPQSektwh043msC6dlG5 DLVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=K1Ybs+hT1nPIORP2XwYBCL9D0EZYSmN/d5S7S6dnsio=; b=xX6tPjQGn5tiyRdx6D7thc+WOwKxvUaBmBaJtoRMHTAQz+wuTMMCJscAKYVPB4xY7E FZqYGWAIGdXV/AXHT6EOa5HVh9Zfg4z2Y+iYxtSO40L134IImUukzXPW6tryOTZS0QRH aslV1937Gk/tezeC/KxKKrzI+cgxDmcXFxZyWT52vY3ozmwGbRYRAYC9pSd0kJTgrS1r /UY1j/hTi4Af/Bzkr3l7QS5/Yt8I/MxByxkd54mkTdCSfyNeGgLHX4kJyEP8Hg2NuUGg US8vWJd/pRCTootvEl3DU2PQ7Qj00S/UP4MLb84RGkoejjdqsA0+XBKCpexTPaJHit8c Lv/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=g+LNnNxB; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y23si10874893ejr.725.2020.12.14.12.10.43; Mon, 14 Dec 2020 12:11:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=g+LNnNxB; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728276AbgLNUIc (ORCPT + 99 others); Mon, 14 Dec 2020 15:08:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2502978AbgLNUEU (ORCPT ); Mon, 14 Dec 2020 15:04:20 -0500 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1544BC061257 for ; Mon, 14 Dec 2020 12:03:17 -0800 (PST) Received: by mail-pj1-x1043.google.com with SMTP id l23so7345210pjg.1 for ; Mon, 14 Dec 2020 12:03:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=K1Ybs+hT1nPIORP2XwYBCL9D0EZYSmN/d5S7S6dnsio=; b=g+LNnNxBUNpU7QpFrxNKjl6txTsOOQHzwo1n74/ZGkW1xYEo3ghMx8d8gv17is0vfB /IiG6hqy3cl9DDBeK3tJoosmjJiEUDmGeI9BfcZbvS9vg8ZrqrSvMuA9bIc7L2mQY/o6 CdXgXVvBNUVQu/zEl9PQ+rLiGCdTsRfSZR52IaaLGfGTOISRWVt1+jkbs+JNOZBX23tA 5Sto69xFCyXCsr4u6S399effMuJiVAZjrI/5TnEaIiwyNXQ8RqImDBA2lMySSN9cfYRX AnHuYTIZDQmEFTkoaVN51W2xitoRo9Fbag24kZ/eNeQ0BX70JVm31nDLPaOJZqPhPdZj iGjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=K1Ybs+hT1nPIORP2XwYBCL9D0EZYSmN/d5S7S6dnsio=; b=ToDQalodZ880xQxnoCwVGeRzyJNnZZ6SBKOJ7i9xCGnD1GQqoTP82fEpzNdsGJnzsl vQuw+PbHiZuWzErOwJG3b1yQqaR038Y4y/XS3yySATzhcrPz3fePx9M3CPJSr1lw/EO3 qaLeU/fMw20TSN8qPHl24bEew/NKvKSwW1AaVqwoM2ohXOrS5Ym5YIbrWPiAbUlq8dJW cG+f2ZQV8VHpOO5GWFRQlG+fvczV3/sxFvspX6cQ3TsBg6sVIME1LlhwRJSxEMZsbIai Q3z8/jD57bSb17++C3qoGo5MTUD8yiwKjb/DHpglbBkinV086XVoOhMAIH1sB93dRJHf bGEg== X-Gm-Message-State: AOAM531vZKAIifCdZElInI3bp+fimFN3YjXkY4TTdcDSdScS1iej2XYx Buu+hHQQyHqqCm9snlrBdtATnA== X-Received: by 2002:a17:90a:a58f:: with SMTP id b15mr19829282pjq.17.1607976196699; Mon, 14 Dec 2020 12:03:16 -0800 (PST) Received: from localhost.localdomain ([163.172.76.58]) by smtp.googlemail.com with ESMTPSA id js9sm22434109pjb.2.2020.12.14.12.03.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Dec 2020 12:03:16 -0800 (PST) From: Corentin Labbe To: arnd@arndb.de, davem@davemloft.net, herbert@gondor.apana.org.au, jernej.skrabec@siol.net, mripard@kernel.org, wens@csie.org Cc: linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Corentin Labbe , stable@vger.kernel.org Subject: [PATCH v4 4/8] crypto: sun4i-ss: handle BigEndian for cipher Date: Mon, 14 Dec 2020 20:02:28 +0000 Message-Id: <20201214200232.17357-5-clabbe@baylibre.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201214200232.17357-1-clabbe@baylibre.com> References: <20201214200232.17357-1-clabbe@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Ciphers produce invalid results on BE. Key and IV need to be written in LE. Fixes: 6298e948215f2 ("crypto: sunxi-ss - Add Allwinner Security System crypto accelerator") Cc: Signed-off-by: Corentin Labbe --- drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c index c7bf731dad7b..e097f4c3e68f 100644 --- a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c +++ b/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-cipher.c @@ -52,13 +52,13 @@ static int noinline_for_stack sun4i_ss_opti_poll(struct skcipher_request *areq) spin_lock_irqsave(&ss->slock, flags); - for (i = 0; i < op->keylen; i += 4) - writel(*(op->key + i / 4), ss->base + SS_KEY0 + i); + for (i = 0; i < op->keylen / 4; i++) + writesl(ss->base + SS_KEY0 + i * 4, &op->key[i], 1); if (areq->iv) { for (i = 0; i < 4 && i < ivsize / 4; i++) { v = *(u32 *)(areq->iv + i * 4); - writel(v, ss->base + SS_IV0 + i * 4); + writesl(ss->base + SS_IV0 + i * 4, &v, 1); } } writel(mode, ss->base + SS_CTL); @@ -223,13 +223,13 @@ static int sun4i_ss_cipher_poll(struct skcipher_request *areq) spin_lock_irqsave(&ss->slock, flags); - for (i = 0; i < op->keylen; i += 4) - writel(*(op->key + i / 4), ss->base + SS_KEY0 + i); + for (i = 0; i < op->keylen / 4; i++) + writesl(ss->base + SS_KEY0 + i * 4, &op->key[i], 1); if (areq->iv) { for (i = 0; i < 4 && i < ivsize / 4; i++) { v = *(u32 *)(areq->iv + i * 4); - writel(v, ss->base + SS_IV0 + i * 4); + writesl(ss->base + SS_IV0 + i * 4, &v, 1); } } writel(mode, ss->base + SS_CTL); -- 2.26.2