Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1993184pxu; Fri, 18 Dec 2020 02:59:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQXRHrssphbFFBgzsOR0pO/qJ/K4qOc9OPxzbV/uX6fSzrJo4JAgkMx1nfaCL/Ro+a/TgX X-Received: by 2002:a05:6402:1a30:: with SMTP id be16mr3895376edb.124.1608289163685; Fri, 18 Dec 2020 02:59:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608289163; cv=none; d=google.com; s=arc-20160816; b=rowo5aVG2vQobvMct33e43Cg3G/NRuNecQTlDP2Pjr6lKh5xtt+YFWDdxIsoAzsEo/ FL/XsbK5+6BQyLsRUogKXYx5vPMmZ1fjaSZxWsHyHEk/QQvKfSk0B8eJQSy0s3lKTgJw d3o0PyI+kHPIeWsqPEUR65IaU9dIODbshjgfNpPG98vBs6EYzDlpwUn8uysyPHNAP4z/ /Oq55k9bpUNlHvsWnJSVBWkRLxS3mKdYA9M2If7DWGipdlVFfWrpov6AQWZ9DIaL0CzV h5g3jI5l0c7AJmvSaLC2iKroci5eoMsexdYrSjJ+D1UKloQif3f6j/ghQPw3WEu2xXWa pgTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=inN/ENjRUPl/kogCO1cGmSNGsSK5ZhXNVqKOhUHnFwM=; b=E4BH6vSh4kPg5bdte4UkY7fz0KnNP2wGlscmuyEh/UC2tDvi2jf595xm4hFQkV7rE4 1Ezn38t9zWjnkMAoIfiL/qM7uCju3ISkTAEI79fNvzlZ6rJP729aAeKdFbZ+QodjBIZg GWDg+IABmkg7f2dEKKGaxEQJH2p9Cj17BVXbObLi9mQai/hSVAEwceXabLy9RoA809D7 zx4NfUiIx37ySIwEXc24FV72degUXH+Qb7VeSXysF66Zno/DkClpq7Urolr1dki/kgKf Eqt3UgBucmikaXqFZWr46S2xWSXG7DtJhh9nrSctqIx6YxUVngZLiZJCkMokykU7JJ5S HQ6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v24si6141646edy.573.2020.12.18.02.59.04; Fri, 18 Dec 2020 02:59:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728249AbgLRK54 (ORCPT + 99 others); Fri, 18 Dec 2020 05:57:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:41276 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725897AbgLRK54 (ORCPT ); Fri, 18 Dec 2020 05:57:56 -0500 From: matthias.bgg@kernel.org Authentication-Results: mail.kernel.org; dkim=permerror (bad message/signature format) To: mpm@selenic.com, herbert@gondor.apana.org.au, rjui@broadcom.com, sbranden@broadcom.com, f.fainelli@gmail.com Cc: linux-kernel@vger.kernel.org, Julia.Lawall@inria.fr, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, nsaenzjulienne@suse.de, linux-crypto@vger.kernel.org, Matthias Brugger Subject: [PATCH v2 1/2] hwrng: iproc-rng200: Fix disable of the block. Date: Fri, 18 Dec 2020 11:57:07 +0100 Message-Id: <20201218105708.28480-1-matthias.bgg@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org From: Matthias Brugger When trying to disable the block we bitwise or the control register with value zero. This is confusing as using bitwise or with value zero doesn't have any effect at all. Drop this as we already set the enable bit to zero by appling inverted RNG_RBGEN_MASK. Signed-off-by: Matthias Brugger --- Changes in v2: - fix commit message, dropping Fixes tag - drop inverted RNT_RBGEN_ENABLE in disable case drivers/char/hw_random/iproc-rng200.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/char/hw_random/iproc-rng200.c b/drivers/char/hw_random/iproc-rng200.c index 01583faf9893..70cd818a0f31 100644 --- a/drivers/char/hw_random/iproc-rng200.c +++ b/drivers/char/hw_random/iproc-rng200.c @@ -28,7 +28,6 @@ #define RNG_CTRL_OFFSET 0x00 #define RNG_CTRL_RNG_RBGEN_MASK 0x00001FFF #define RNG_CTRL_RNG_RBGEN_ENABLE 0x00000001 -#define RNG_CTRL_RNG_RBGEN_DISABLE 0x00000000 #define RNG_SOFT_RESET_OFFSET 0x04 #define RNG_SOFT_RESET 0x00000001 @@ -61,7 +60,6 @@ static void iproc_rng200_restart(void __iomem *rng_base) /* Disable RBG */ val = ioread32(rng_base + RNG_CTRL_OFFSET); val &= ~RNG_CTRL_RNG_RBGEN_MASK; - val |= RNG_CTRL_RNG_RBGEN_DISABLE; iowrite32(val, rng_base + RNG_CTRL_OFFSET); /* Clear all interrupt status */ @@ -174,7 +172,6 @@ static void iproc_rng200_cleanup(struct hwrng *rng) /* Disable RNG hardware */ val = ioread32(priv->base + RNG_CTRL_OFFSET); val &= ~RNG_CTRL_RNG_RBGEN_MASK; - val |= RNG_CTRL_RNG_RBGEN_DISABLE; iowrite32(val, priv->base + RNG_CTRL_OFFSET); } -- 2.29.2