Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1607946280-42445-1-git-send-email-tiantao6@hisilicon.com>
References: <1607946280-42445-1-git-send-email-tiantao6@hisilicon.com>
Subject: Re: [PATCH] crypto: inside-secure - fix platform_get_irq.cocci warnings
Cc:     linux-crypto@vger.kernel.org
From:   Antoine Tenart <atenart@kernel.org>
To:     Tian Tao <tiantao6@hisilicon.com>, davem@davemloft.net,
        herbert@gondor.apana.org.au
Message-ID: <160864537192.1448242.7324361895608959161@kwain.local>
Date:   Tue, 22 Dec 2020 14:56:12 +0100
Precedence: bulk

Hello,

Quoting Tian Tao (2020-12-14 12:44:40)
> Remove dev_err() messages after platform_get_irq*() failures.
> drivers/crypto/inside-secure/safexcel.c: line 1161 is redundant
> because platform_get_irq() already prints an error
>=20
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>=20
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>

Acked-by: Antoine Tenart <atenart@kernel.org>

Thanks!
Antoine

> ---
>  drivers/crypto/inside-secure/safexcel.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>=20
> diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/ins=
ide-secure/safexcel.c
> index 2e15621..efabc44bf 100644
> --- a/drivers/crypto/inside-secure/safexcel.c
> +++ b/drivers/crypto/inside-secure/safexcel.c
> @@ -1166,11 +1166,8 @@ static int safexcel_request_ring_irq(void *pdev, i=
nt irqid,
>                 dev =3D &plf_pdev->dev;
>                 irq =3D platform_get_irq_byname(plf_pdev, irq_name);
> =20
> -               if (irq < 0) {
> -                       dev_err(dev, "unable to get IRQ '%s' (err %d)\n",
> -                               irq_name, irq);
> +               if (irq < 0)
>                         return irq;
> -               }
>         } else {
>                 return -ENXIO;
>         }
> --=20
> 2.7.4
>=20