Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp12838243pxu; Sat, 2 Jan 2021 13:31:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJzZ4I+XFEc3GPOBbCLajsGlKvWcJG8/gt8qSNmY157tnQ0ABw45/TgIECQ5ijhHWncQSBcV X-Received: by 2002:a17:906:810:: with SMTP id e16mr56593383ejd.34.1609623115155; Sat, 02 Jan 2021 13:31:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1609623115; cv=none; d=google.com; s=arc-20160816; b=OoqIpe9XDzmnFwFUMOQS1Sq6OlEMFEy5MGfpaNHIos8jsizY5tRdd6inifu0IHtMdg dgVP38R+5weEoD7XbJ/w77hIh3+FbsDVtes3Sx97nyx6oWWhLufJvU4aiz/DZ5v8SBQR F6cZtHsGG8EC84kVr7W5BD/fho/CKxGGRsirCHlCezYpp/rk7z9cBq2gW7QnW0Wlx7T/ ZhEOPB1ZSn94Yz87D0J/7MVrTi2UwqEU3E70wmSXGVgUbMufYMGTJsekBhRI10Z6B8gq P6AIlnsKcfd7j6eX2Grb5/vH62xGrKFhfKlIuThZ3IrSKMIYRIU06WGkQSTN7j94wycg o/bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=i7FGnXtV886aj2mDRmHSO8anO1l3JUfD3p5ir3rysEo=; b=YYyjajlPLqHgrePDjVPW4rlW42VYwxAuAYjOyrDZDAErkDOD15W2iYX2FV76s44RuA iSDW+v4+UDvl1cyAOeQ5L8YliG1QAjHhfn5imH0b8PAVzNwrnmnDQEugDENDh3FbnmUt 3E5P8u1DqHvnEqjZvSKoB3cg7lbEtRaBN1/hh2RnvOkHeWu91W23+WDzvYlm2S0tnuqf HAhJZ6hwqkfzgJ4DvbRYtmL3hs5KNk/YK8FQedUVQT4p+UbDYyfMJjriVyhMaAYbw2zj 5CbiQLSALZwQLGP0BdoAoTpD0xLE+JqEt/b7NzuhifRtQ7VWYEprHmFrtrFZbhv0E0MD BcoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qp17si27411168ejb.516.2021.01.02.13.31.36; Sat, 02 Jan 2021 13:31:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726687AbhABVai (ORCPT + 99 others); Sat, 2 Jan 2021 16:30:38 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:37142 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726670AbhABVah (ORCPT ); Sat, 2 Jan 2021 16:30:37 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kvoSn-0000Bp-Qs; Sun, 03 Jan 2021 08:29:30 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Sun, 03 Jan 2021 08:29:29 +1100 Date: Sun, 3 Jan 2021 08:29:29 +1100 From: Herbert Xu To: Meng Yu Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, xuzaibo@huawei.com, wangzhou1@hisilicon.com, linux-kernel@vger.kernel.org, Daniele Alessandrelli , Mark Gross , Prabhjot Khurana , Elena Reshetova Subject: Re: [PATCH v5 3/5] crypto: expose elliptic curve parameters as Crypto APIs Message-ID: <20210102212929.GA1996@gondor.apana.org.au> References: <1608790107-32617-1-git-send-email-yumeng18@huawei.com> <1608790107-32617-4-git-send-email-yumeng18@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1608790107-32617-4-git-send-email-yumeng18@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Dec 24, 2020 at 02:08:25PM +0800, Meng Yu wrote: > Move elliptic curves definition to 'include/crypto/ecc_curve_defs.h', > so all can use it, > > Signed-off-by: Meng Yu > Reviewed-by: Zaibo Xu > --- > crypto/ecc.c | 1 - > crypto/ecc.h | 37 +---------------- > crypto/ecc_curve_defs.h | 57 ------------------------- > crypto/ecrdsa_defs.h | 2 +- > include/crypto/ecc_curve_defs.h | 92 +++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 95 insertions(+), 94 deletions(-) > delete mode 100644 crypto/ecc_curve_defs.h > create mode 100644 include/crypto/ecc_curve_defs.h This conflicts with https://patchwork.kernel.org/project/linux-crypto/patch/20201217172101.381772-3-daniele.alessandrelli@linux.intel.com/ Please discuss with each other on how you would like to proceed. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt