Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp283284pxb; Wed, 13 Jan 2021 03:38:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJzvx4DpiCQbRW0tvvOWZy9MkDPeMh9orVEIEvKfFYWCDC/ct9dfvRy4G7STh1r+C7onzHa2 X-Received: by 2002:a05:6402:ca1:: with SMTP id cn1mr1435767edb.128.1610537891775; Wed, 13 Jan 2021 03:38:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610537891; cv=none; d=google.com; s=arc-20160816; b=VM6kRE81jVZEXt6fSyAc9LMIDyVNNgOEBJ/o/OK+o4TN8aXW0W3qkplYRWN3zsbg/L rZu2gJAr9y54gKKGCh6STNC+P6x4I0rAfwBQflyuw6TEXhZ7wOChId2aSo2d4yGEFqCY IOZI5NkQAARlDWYndbatbtmQoqFxsb3c2zvwV2aCjU1WAYySecIEWjQQAVuPotoyQY13 58gcYOMERyCYpThqBfNPylpcVQAfPpBdbqD3f+MT/biyD6aGlLbZDf0RHgCJcRn4j7H3 JQcMGHWZkDCL9OpDgoZ4pRUBvjsDO2b7hoCe3oOz1lKaySXeuI7z/iDs/Ni6kD+gtvZ+ dlLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=pQcSb6CyS4Rcj5w1L4KFo4VX77Uj3QkqX6PSofKeGPI=; b=VT8GZkP1OAIDKFoR95J2OJTf9bStXtrLVGRrBpiTyEDWEmA/Kkyp2jZwviR5aq5qp/ 4488mpLEagCN+5LCHIE1zqpvUkKik8ZMcw4QGhPjse/ouZv+1Dj2qTd+LxKLadXIUktl qAV7iUhe6DQVgQiNoE9Slv6XEVKnS1bLEIjYpL6XTNYo9ieOek6+HEGebk5diR4xUmuj Xa3zMdtWzyp5EEhJUtjiC8c5JmApEDtyHxiFnXBFtYDPgfcGR6tLCqOGOhB/2Ekmj7xt LVJaRGhcVek7hAwpsavhBInj9O+TI0OJDioqABOjhoMGosM/Ba57ZYpL2CG/jlZQTOAV fVTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FevGkXsN; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id pk20si216789ejb.103.2021.01.13.03.37.52; Wed, 13 Jan 2021 03:38:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FevGkXsN; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727145AbhAMLhi (ORCPT + 99 others); Wed, 13 Jan 2021 06:37:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36774 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728272AbhAMLhh (ORCPT ); Wed, 13 Jan 2021 06:37:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610537771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pQcSb6CyS4Rcj5w1L4KFo4VX77Uj3QkqX6PSofKeGPI=; b=FevGkXsNuJvSV0XZ71icVHZMER0FsTiOoaCgJ5v3jm157yIowC0VCGjNCCbos/NvOCqCie j82nrJhZ9i6KPqrzpxAUdNXjKYCFFSaP52Z8iwUtyQm5hGFZkdX+o4SkB8l9yj9JAGyx7W QGRBlaGs2HouzRr2AQbqHUT5qz5RD/I= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-499-qMw66yCFOyi4LNGe5lO7nw-1; Wed, 13 Jan 2021 06:36:09 -0500 X-MC-Unique: qMw66yCFOyi4LNGe5lO7nw-1 Received: by mail-wm1-f70.google.com with SMTP id f18so707141wmq.1 for ; Wed, 13 Jan 2021 03:36:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=pQcSb6CyS4Rcj5w1L4KFo4VX77Uj3QkqX6PSofKeGPI=; b=AhsCvQto/FWYyGdMAtZzkG/1ynTisNIS66acU3qoVe1ytxZRt7jLY3Vj9Bk1uLlHZf qzVX8UTgd+m19REaQYSI1tPOelMs+yDV3Q4fP8t9apl/DH6NddOz6FdTQBnOTRT3nxzH ekjjTyVbsZxxaB3gw7svf2xCPNEWSv+TvoG7aX7onkZbhnJ4mAT8IZkP6TMyCUAFI7yE K54CF28UlndRupnSLnBMd/SsY36C06peZz6w/rPAJI/7EnfKh3F6lbiVsvOPk4Nh5TgJ 8PIs3yWPMfRAyI/Aq8iLhPG8uFd9QJXeDHe7xwH1Bl+/sxc0t1BG25Wl0duHh8XpkYUQ qIhQ== X-Gm-Message-State: AOAM5331st9n55RN4soVb58n7lj8aHnEWBAimXmF9sTNcO1iauPL6uet 30Sb+kEerWOFygwu+9sc/i8kzj9d17/NwGXc7GSQhyHdqgzkHMmKXqdH1hZC8a2QkugeeUNyiP3 dODDVg6rkFrk9Pmviyys2Vpv3 X-Received: by 2002:a1c:a5d4:: with SMTP id o203mr1795405wme.41.1610537768794; Wed, 13 Jan 2021 03:36:08 -0800 (PST) X-Received: by 2002:a1c:a5d4:: with SMTP id o203mr1795384wme.41.1610537768581; Wed, 13 Jan 2021 03:36:08 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id r20sm2460567wmh.15.2021.01.13.03.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jan 2021 03:36:08 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id A504C18032B; Wed, 13 Jan 2021 12:36:07 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: David Howells Cc: dhowells@redhat.com, Herbert Xu , "David S. Miller" , Tianjia Zhang , Gilad Ben-Yossef , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] crypto: public_key: check that pkey_algo is non-NULL before passing it to strcmp() In-Reply-To: <2648795.1610536273@warthog.procyon.org.uk> References: <20210112161044.3101-1-toke@redhat.com> <2648795.1610536273@warthog.procyon.org.uk> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 13 Jan 2021 12:36:07 +0100 Message-ID: <875z419ihk.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org David Howells writes: > I'm intending to use Tianjia's patch. Yeah, sorry for missing that. > Would you like to add a Reviewed-by? Sure: Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen and also, if you like: Tested-by: Toke H=C3=B8iland-J=C3=B8rgensen