Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp331517pxb; Wed, 13 Jan 2021 05:00:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJy4dxaV8PIfJSKtDlC8nB52WgCRCpK5to2gmOK9YGApxgemwvG3a9s1xR5b9sChohHN7Q4Y X-Received: by 2002:a17:906:edd1:: with SMTP id sb17mr1469611ejb.118.1610542803387; Wed, 13 Jan 2021 05:00:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610542803; cv=none; d=google.com; s=arc-20160816; b=mQ1Wz7R0A9lhWSUc4i8D5LzGFiDG9u2w7IP/Wo87cMlAg7X/qqAHN1CbbA/8AYimse jj03pbQlBmqu1VJxunAtyohBBewLGgjogh51gBWBpDfbvmPME3ZRiG/b/tf7QC7JWN/U dPIxuDjbwCrv7Ji7kVaMTJj1W2ptBN4mU+Q0oiU6mMW99U+cfDWCkzuk641UDpv2rKPX WPHUW2kwspDFWhom2P49WSrjtJbFNQ1we9QZiv1dyffomavR7VDD0+0B2BZo3OhknPM+ J5l4PVYIVSdVxM+1jf/bbHPincE2d2VkGlCY+uKeXwzRhkqHR6ZE+iRj7claQY4woiIs CKYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-transfer-encoding :mime-version:subject:cc:to:references:in-reply-to:from:organization :dkim-signature; bh=mAPeX5/ZEkCepmyGIJNpQYxJzy5jX84g3ceqEJc7zVU=; b=XJ4oK3OAEklSRIr3UTjbP2wYLepru560qlJOCwg1UbSkRnQg1hfu2073yBPyI8feas Dn9q25IQ0qVKEovN9phqKeS5wbRjwyUiEEY9WbSIUia3zkW856zRpAdFd/GjEgJGVBl1 C04LHW7tAOHHfjz3FSuBphAHFsl8aypeNnm9IT2VWTXxCa/ZlymKRXZpmhQK4AojBAad PPGlSOxl626mdBoKo//3PAijrixHcCtOpMGGjqSSWggsq1qQBNRAm80upfs6ZlFFkbM/ Wllo5rfTUd1930QzMe7CIlSShyULRu9shYzIKd/plwbagUDxGEQ74qIa9jkHpjsGbjaL DWtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=X43FhAYK; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f17si911880edx.585.2021.01.13.04.59.42; Wed, 13 Jan 2021 05:00:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=X43FhAYK; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725858AbhAMM7d (ORCPT + 99 others); Wed, 13 Jan 2021 07:59:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:54190 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725801AbhAMM7d (ORCPT ); Wed, 13 Jan 2021 07:59:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610542687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mAPeX5/ZEkCepmyGIJNpQYxJzy5jX84g3ceqEJc7zVU=; b=X43FhAYKKzwbzamiKlKNiq5eTiYVeCXUDyto2LUZYohd+lQW2F+lPYU8mf3DexSxVt9k+E lA3g6VJ4nRL4TOtUKebw+BkDH9eoMB8Smizq/U544oJUrtpAhfh0AQ3e+enVKyHq54G6J2 A7NIR1XGfT4e5S773wGUhwHtUEcfn/A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-588--Sv83cdvNIWJZIXoVRqY1A-1; Wed, 13 Jan 2021 07:58:06 -0500 X-MC-Unique: -Sv83cdvNIWJZIXoVRqY1A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B71168066E4; Wed, 13 Jan 2021 12:58:04 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-8.rdu2.redhat.com [10.10.112.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A2255D6A8; Wed, 13 Jan 2021 12:58:00 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <875z419ihk.fsf@toke.dk> References: <875z419ihk.fsf@toke.dk> <20210112161044.3101-1-toke@redhat.com> <2648795.1610536273@warthog.procyon.org.uk> To: Toke =?us-ascii?Q?=3D=3Futf-8=3FQ=3FH=3DC3=3DB8iland-J=3DC3=3DB8rgense?= =?us-ascii?Q?n=3F=3D?= Cc: dhowells@redhat.com, Herbert Xu , "David S. Miller" , Tianjia Zhang , Gilad Ben-Yossef , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] crypto: public_key: check that pkey_algo is non-NULL before passing it to strcmp() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 13 Jan 2021 12:57:59 +0000 Message-ID: <2656681.1610542679@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Toke H=C3=B8iland-J=C3=B8rgensen wrote: > Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen >=20 > and also, if you like: >=20 > Tested-by: Toke H=C3=B8iland-J=C3=B8rgensen Thanks! David