Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 14 Jan 2021 17:42:28 +1100
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Srujana Challa <schalla@marvell.com>
Cc:     davem@davemloft.net, linux-crypto@vger.kernel.org,
        pathreya@marvell.com, jerinj@marvell.com,
        Suheil Chandran <schandran@marvell.com>,
        Lukasz Bartosik <lbartosik@marvell.com>
Subject: Re: [PATCH 4/9] crypto: octeontx2: load microcode and create engine
 groups
Message-ID: <20210114064228.GA3411@gondor.apana.org.au>
References: <20210106104223.6182-1-schalla@marvell.com>
 <20210106104223.6182-5-schalla@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210106104223.6182-5-schalla@marvell.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Wed, Jan 06, 2021 at 04:12:18PM +0530, Srujana Challa wrote:
>
> +static int cpt_ucode_load_fw(struct pci_dev *pdev, struct fw_info_t *fw_info)
> +{
> +	char filename[OTX2_CPT_NAME_LENGTH];
> +	char eng_type[8] = {0};
> +	int ret, e, i;
> +
> +	INIT_LIST_HEAD(&fw_info->ucodes);
> +
> +	for (e = 1; e < OTX2_CPT_MAX_ENG_TYPES; e++) {
> +		strncpy(eng_type, get_eng_type_str(e), 2);

This triggers a compiler warning:

../drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c: In function ‘cpt_ucode_load_fw’:
../drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c:408:3: warning: ‘strncpy’ output may be truncated copying 2 bytes from a string of length 2 [-Wstringop-truncation]
   strncpy(eng_type, get_eng_type_str(e), 2);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Please fix.  Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt