Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp44589pxb; Wed, 13 Jan 2021 22:48:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJzHdqXbx2g66sN526uOeXrj+CMLsjDZ7BMgFT375ISsJh1nEEzsI+B9lcvTqlVUJkKUn51h X-Received: by 2002:a50:e848:: with SMTP id k8mr4633640edn.77.1610606887528; Wed, 13 Jan 2021 22:48:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610606887; cv=none; d=google.com; s=arc-20160816; b=hKBvB4W1SCKxXBhMgt94WK7VaPOvhZBjZLwKMPFEgEOJABnGAOKZT8LJRDECkFBP7l lkvvjVN/5C8JCwloys9rJ9TsUR6jlhDHQ6GJBo96SlYP0Wx2z2j6L03HBsC/aiOrffc4 uIJefC/agpeLqMFqr+qYUw08eU45Pa7oVnQ4kogYxSgjEWH37sNP0yNdpeD68hNv+21L Ozzujx3+eWzZMapDoSf1Nwr0SVsjzgPDZqnzx/2K5f3nI8lje3Zq6rX3dhrjuPkCtC5K jY3v92taLGIzuJz0ZhXMq6CypEg5RqiwtQRztAmiLzCsTgUFdIpp9PUVsOFA5nUlmpz1 +sVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=nY8fXM/9N5M6FmzknoYJB3s0fH5MBK/0pMh7WHfEJqU=; b=rzWmCnM6O9j6p3QeEnVX8aOoNcb9L1SHmI+dXtlV7ZpLqCWxdCaOUYGPzWB6eCKbkV 0DYPGFwjgoqUdurx0FkFxccH9LZwYQebrz7w0JPmH07eHY9nRSzuJiXqs1+JQVf7aDY7 w4lfd8IksdJV82GEVWIe10pJc8vY9qgLJYbrU75ayMZMgt1jOh6dWz7gH4jPNfVFq0It 4TcnPp/VOPn/RT2gTy3A/5Z0I0WKh0r2HADftxjThOxlmHa5uHmqzxPKsjwcq3WLudng FiVtjCWBQWpR9z4kTZUfZ5H791o9m7amixxOiA0QIGKfgMQHBmPDNfZlFyzaZ/LXabXl Cznw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u25si2232511edv.571.2021.01.13.22.47.48; Wed, 13 Jan 2021 22:48:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726117AbhANGrQ (ORCPT + 99 others); Thu, 14 Jan 2021 01:47:16 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:42168 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725989AbhANGrQ (ORCPT ); Thu, 14 Jan 2021 01:47:16 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kzwOv-00087c-Ru; Thu, 14 Jan 2021 17:46:35 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 14 Jan 2021 17:46:33 +1100 Date: Thu, 14 Jan 2021 17:46:33 +1100 From: Herbert Xu To: Giovanni Cabiddu Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com, Wojciech Ziemba Subject: Re: [PATCH] crypto: qat - configure arbiter mapping based on engines enabled Message-ID: <20210114064633.GC12584@gondor.apana.org.au> References: <20210104165546.6686-1-giovanni.cabiddu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210104165546.6686-1-giovanni.cabiddu@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Jan 04, 2021 at 04:55:46PM +0000, Giovanni Cabiddu wrote: > From: Wojciech Ziemba > > The hardware specific function adf_get_arbiter_mapping() modifies > the static array thrd_to_arb_map to disable mappings for AEs > that are disabled. This static array is used for each device > of the same type. If the ae mask is not identical for all devices > of the same type then the arbiter mapping returned by > adf_get_arbiter_mapping() may be wrong. > > This patch fixes this problem by ensuring the static arbiter > mapping is unchanged and the device arbiter mapping is re-calculated > each time based on the static mapping. > > Signed-off-by: Wojciech Ziemba > Reviewed-by: Giovanni Cabiddu > Signed-off-by: Giovanni Cabiddu > --- > .../crypto/qat/qat_4xxx/adf_4xxx_hw_data.c | 14 ++-------- > .../crypto/qat/qat_c3xxx/adf_c3xxx_hw_data.c | 17 +++-------- > .../crypto/qat/qat_c62x/adf_c62x_hw_data.c | 27 ++++-------------- > .../crypto/qat/qat_common/adf_accel_devices.h | 3 +- > .../crypto/qat/qat_common/adf_hw_arbiter.c | 8 ++---- > .../qat/qat_dh895xcc/adf_dh895xcc_hw_data.c | 28 +++---------------- > 6 files changed, 20 insertions(+), 77 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt