Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210115171743.1559595-1-Jason@zx2c4.com>
In-Reply-To: <20210115171743.1559595-1-Jason@zx2c4.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Fri, 15 Jan 2021 18:25:09 +0100
Message-ID: <CAMj1kXGKVvxrwo_rsT7ZhZk6AzTHiCR5spq7SFK-uak6r2FeXA@mail.gmail.com>
Subject: Re: [PATCH] crypto: lib/chacha20poly1305 - define empty module exit function
To:     "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc:     Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        John Donnelly <john.p.donnelly@oracle.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 15 Jan 2021 at 18:17, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> With no mod_exit function, users are unable to load the module after
> use. I'm not aware of any reason why module unloading should be
> prohibited for this one, so this commit simply adds an empty exit
> function.
>
> Reported-by: John Donnelly <john.p.donnelly@oracle.com>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  lib/crypto/chacha20poly1305.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/lib/crypto/chacha20poly1305.c b/lib/crypto/chacha20poly1305.c
> index 5850f3b87359..c2fcdb98cc02 100644
> --- a/lib/crypto/chacha20poly1305.c
> +++ b/lib/crypto/chacha20poly1305.c
> @@ -362,7 +362,12 @@ static int __init mod_init(void)
>         return 0;
>  }
>
> +static void __exit mod_exit(void)
> +{
> +}
> +
>  module_init(mod_init);
> +module_exit(mod_exit);
>  MODULE_LICENSE("GPL v2");
>  MODULE_DESCRIPTION("ChaCha20Poly1305 AEAD construction");
>  MODULE_AUTHOR("Jason A. Donenfeld <Jason@zx2c4.com>");
> --
> 2.30.0
>