Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Subject: Re: [PATCH] crypto: lib/chacha20poly1305 - define empty module exit
 function
From:   John Donnelly <john.p.donnelly@oracle.com>
In-Reply-To: <20210115171743.1559595-1-Jason@zx2c4.com>
Date:   Fri, 15 Jan 2021 12:06:34 -0600
Cc:     linux-crypto@vger.kernel.org, ardb@kernel.org,
        herbert@gondor.apana.org.au
Content-Transfer-Encoding: 7bit
Message-Id: <6F8CD748-33AA-48C7-90A4-D42F9C037F77@oracle.com>
References: <20210115171743.1559595-1-Jason@zx2c4.com>
To:     "Jason A. Donenfeld" <Jason@zx2c4.com>
Precedence: bulk


> On Jan 15, 2021, at 11:17 AM, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> 
> With no mod_exit function, users are unable to load the module after
> use. I'm not aware of any reason why module unloading should be
> prohibited for this one, so this commit simply adds an empty exit
> function.
> 
> Reported-by: John Donnelly <john.p.donnelly@oracle.com>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---


Hi ,

 Verified 

 Please add 


  Test-by: John Donnelly <john.p.donnelly@oracle.com>


> lib/crypto/chacha20poly1305.c | 5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/lib/crypto/chacha20poly1305.c b/lib/crypto/chacha20poly1305.c
> index 5850f3b87359..c2fcdb98cc02 100644
> --- a/lib/crypto/chacha20poly1305.c
> +++ b/lib/crypto/chacha20poly1305.c
> @@ -362,7 +362,12 @@ static int __init mod_init(void)
> 	return 0;
> }
> 
> +static void __exit mod_exit(void)
> +{
> +}
> +
> module_init(mod_init);
> +module_exit(mod_exit);
> MODULE_LICENSE("GPL v2");
> MODULE_DESCRIPTION("ChaCha20Poly1305 AEAD construction");
> MODULE_AUTHOR("Jason A. Donenfeld <Jason@zx2c4.com>");
> -- 
> 2.30.0
>