Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp395790pxb; Fri, 15 Jan 2021 16:35:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJyF1PbN/08YWPytWlGeifQdhH29KcR+UK/FaDRP3K2xKFSPvk+85vjtpcNVweDorxTsP+AD X-Received: by 2002:a17:906:b093:: with SMTP id x19mr5963532ejy.432.1610757312052; Fri, 15 Jan 2021 16:35:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610757312; cv=none; d=google.com; s=arc-20160816; b=STvtedr3maZBLwK0oScZUE+pxReGKCV1nKFjz0jgV/R7zlqNSl1ruY/PIidrFogrV1 +kqoRetHAPy2AZrU1fDz4pTI08NdTXOz3XXUoKI1c2ImohPV7DXBNr+FuE/xyNtmtJ80 eHfhHS1tfQD8+jR9JSEdRAm+iSASYl8kb9zFpioMVYg/Y0kCHOGRTcSQ5Npd74iSSflc UHKY/fkYwPP9Ub/eBuDrtlxjXlR1ZzCyndqeLPWzlPl2GS78EmGrQBgDmum2NfnxeVU8 y2IRRoq3D89/8n3Fr6hIdRfpD1DGEtSk+PejiB2vro8WRkRtG9Yl7lITJZlnj7eo8O2L UGrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=n8iZPICWYsO+RYtUEO2xzdAJtVxcHhgNAS7/3a61bNc=; b=PSKH2UShFt6akrvZnCVNFWGYvm9vUcyIaf1OCHHOx/0GTGQKF0j2lzQfolZTFCaCV6 SQKjJgqGrgTao5pVlB81SezQjiKvrm1xV7Qidu9LQCjYbJdDRSfjIbCHAxLo/dUvlDX9 V8oII5w2Dw/pHQJzs2tCSuF3W4awT7uv5bYcJOqGvNlYkbpyYFOvXZ86jFTYBfqx0OYo ifKjTYI+69jff6yFlLTsIiE8Jx+cZy7IriropU1VHOvmRqTSQVLxDvj49XtMPXOhALQC TPlwkmFAMh1z4zmqKpNxWJApATPcn5771vNm+RfwujOQ3/h4zkc4Jc/TKSxElxy+KWMb ugBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=hqXeTJOa; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t5si4477905ejy.497.2021.01.15.16.34.52; Fri, 15 Jan 2021 16:35:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=hqXeTJOa; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726472AbhAPAcc (ORCPT + 99 others); Fri, 15 Jan 2021 19:32:32 -0500 Received: from mail.zx2c4.com ([167.71.246.149]:43924 "EHLO mail.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726224AbhAPAcc (ORCPT ); Fri, 15 Jan 2021 19:32:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1610757107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n8iZPICWYsO+RYtUEO2xzdAJtVxcHhgNAS7/3a61bNc=; b=hqXeTJOab5lSqGizo5Goq1JXQwiFXKNrkojE/Y2VllC0XhsfQ5WpIaQJlGTvnppYR6SLlX 02WtezXaeM56GtwvPSFV2SRWEoFmq2S021S0AGYyDV/tH1TUHb1PfHTzVwzrTDDXeZZd8a U7CHyb9nhZsZgAqrb7T7gXOu/uqe8sE= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id b9f0ebe2 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Sat, 16 Jan 2021 00:31:47 +0000 (UTC) Received: by mail-yb1-f172.google.com with SMTP id x78so2220653ybe.11 for ; Fri, 15 Jan 2021 16:31:47 -0800 (PST) X-Gm-Message-State: AOAM532lZvttp6iHs+Fq1AGGmmHTnEopwGeIfgbyJMiBcE1hZhzyaQWc rgenI1x61wUgQG0UqNQD8u45k26+L3WGcjUv5Ss= X-Received: by 2002:a25:c7d0:: with SMTP id w199mr18970424ybe.279.1610757106864; Fri, 15 Jan 2021 16:31:46 -0800 (PST) MIME-Version: 1.0 References: <20210115171743.1559595-1-Jason@zx2c4.com> <20210115193012.3059929-1-Jason@zx2c4.com> <7628A3E4-B5AB-4C3C-9328-9E7F788E2928@oracle.com> In-Reply-To: <7628A3E4-B5AB-4C3C-9328-9E7F788E2928@oracle.com> From: "Jason A. Donenfeld" Date: Sat, 16 Jan 2021 01:31:36 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] crypto: lib/chacha20poly1305 - define empty module exit function To: John Donnelly Cc: Linux Crypto Mailing List , Ard Biesheuvel , Herbert Xu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Jan 16, 2021 at 1:30 AM John Donnelly wrote: > > > > > On Jan 15, 2021, at 1:30 PM, Jason A. Donenfeld wrote: > > > > With no mod_exit function, users are unable to unload the module after > > use. I'm not aware of any reason why module unloading should be > > prohibited for this one, so this commit simply adds an empty exit > > function. > > > > Reported-and-tested-by: John Donnelly > > Acked-by: Ard Biesheuvel > > Signed-off-by: Jason A. Donenfeld > > Thanks! > > Would someone be kind enough to remind when this appears and I will apply it to our product ? We like to use published commits when possible. > > JD It'll show up in one of these two repos in a week or two: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git/ https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/