Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 14/19] crypto: qat: convert tasklets to use new
 tasklet_setup() API
To:     Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
        Allen Pais <allen.lkml@gmail.com>
Cc:     herbert@gondor.apana.org.au, davem@davemloft.net,
        nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
        ludovic.desroches@microchip.com, jesper.nilsson@axis.com,
        lars.persson@axis.com, horia.geanta@nxp.com, aymen.sghaier@nxp.com,
        gcherian@marvell.com, thomas.lendacky@amd.com, john.allen@amd.com,
        gilad@benyossef.com, bbrezillon@kernel.org, arno@natisbad.org,
        schalla@marvell.com, matthias.bgg@gmail.com, jamie@jamieiles.com,
        heiko@sntech.de, krzk@kernel.org, vz@mleia.com,
        k.konieczny@samsung.com, linux-crypto@vger.kernel.org,
        linux-mediatek@lists.infradead.org, qat-linux@intel.com,
        linux-rockchip@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org,
        Romain Perier <romain.perier@gmail.com>
References: <20210112014650.10887-1-allen.lkml@gmail.com>
 <20210112014650.10887-15-allen.lkml@gmail.com>
 <20210114175109.GA8629@silpixa00400314>
From:   Allen Pais <apais@linux.microsoft.com>
Message-ID: <94926b18-2e1e-0b85-41b2-a7e894d21998@linux.microsoft.com>
Date:   Mon, 18 Jan 2021 12:41:36 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210114175109.GA8629@silpixa00400314>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


>>
>> In preparation for unconditionally passing the
>> struct tasklet_struct pointer to all tasklet
>> callbacks, switch to using the new tasklet_setup()
>> and from_tasklet() to pass the tasklet pointer explicitly.
> 
> I have two minor comments:
>    * Patches to the qat driver have the following headline
>          crypto: qat -
>    * Checkpatch reports two alignment checks when it is run with --strict:
>          CHECK: Alignment should match open parenthesis
>          #33: FILE: drivers/crypto/qat/qat_common/adf_isr.c:248:
>          +               tasklet_setup(&priv_data->banks[i].resp_handler,
>          +                            adf_response_handler);
> 
>          CHECK: Alignment should match open parenthesis
>          #62: FILE: drivers/crypto/qat/qat_common/adf_sriov.c:57:
>          +               tasklet_setup(&vf_info->vf2pf_bh_tasklet,
>          +                            adf_vf2pf_bh_handler);
> 
>          total: 0 errors, 0 warnings, 2 checks, 83 lines checked
> 
> If you prefer I can resubmit this patch with these two changes.

Thank you. I will fix them and re-submit.