Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp798433pxb; Thu, 21 Jan 2021 22:23:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJw+u5RYopKm9gcdw45Tkib7Bc9GHIgNXk+CFJ7y7qVt/+ELRWny2OgE/oEYNPzB86we5uf1 X-Received: by 2002:aa7:d919:: with SMTP id a25mr2031593edr.243.1611296607294; Thu, 21 Jan 2021 22:23:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611296607; cv=none; d=google.com; s=arc-20160816; b=lgbChhxhBvcGdl/BDCRqurb4M8Q++1Q4yn0imQyT6cLQlNupqif16Pfhs6TH5ObIKQ 96hXiB9rH/+sKcsXdiEhTEre1BmnZU5DE+GPfb0XmaN2XhjiAXqWYvnZiS1Y3nVcPnYJ BLYuUVwSIBrRz0AwP4gGjXdIaDeGqOatyWaa+QKRQfYLLDWWj4J2ryUcBjVEHX8coafY BOkpDhQyRqUEZ0X/glfqTT2DA13iEUT/+nOPSL0MjuTTfJEAzEPpGOVXBnbXjQwLVzhp QGuInkocWrKIPrtN5ByuimUyEs1KWfh4VATZoYWaJqnSANEgZVMARcDZ3smRX3FpZl8G CKEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=kAJyS2Fak9trc+2u/lvmjlSDs88znRcz/ePTZfZrgDI=; b=U65ZhrYY57zdxmbeFRGBGrR0y8K9n0BfhYL6RzFqgZsy4Bh2U67htpp/dP/cUXHKhE 1/nFaDbN+O7Td76Fz5OjqDMNgzMAqAIENKBrIVmTbXLu614+cvnc0RdMoZmLk/ieVjEp Ec5Me4iFzk0bxZcsVS0pIPxZwcCiH9dMrQWFGTB79DALJiinoGBqqJGvRcFN7CiOLpjl Emg8jQFLPqDcpaAwiCZkketYBOvAub6rFmY0pgLCOeh+6JfFliFcEc2H2LthYdnFSryM bANlpnVGjwg+Aep2gUHimU0PFXGvxdbA1LHoCaGCF1Z1PaHbnfn6xHKYWQcSvagyAGAx m3Og== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i26si2540445ejg.670.2021.01.21.22.23.04; Thu, 21 Jan 2021 22:23:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725771AbhAVGWC (ORCPT + 99 others); Fri, 22 Jan 2021 01:22:02 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:54128 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726021AbhAVGWB (ORCPT ); Fri, 22 Jan 2021 01:22:01 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1l2pom-00021u-IN; Fri, 22 Jan 2021 17:21:13 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 22 Jan 2021 17:21:12 +1100 Date: Fri, 22 Jan 2021 17:21:12 +1100 From: Herbert Xu To: "Jason A. Donenfeld" Cc: linux-crypto@vger.kernel.org, ardb@kernel.org, John Donnelly Subject: Re: [PATCH v2] crypto: lib/chacha20poly1305 - define empty module exit function Message-ID: <20210122062112.GD1217@gondor.apana.org.au> References: <20210115171743.1559595-1-Jason@zx2c4.com> <20210115193012.3059929-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210115193012.3059929-1-Jason@zx2c4.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Jan 15, 2021 at 08:30:12PM +0100, Jason A. Donenfeld wrote: > With no mod_exit function, users are unable to unload the module after > use. I'm not aware of any reason why module unloading should be > prohibited for this one, so this commit simply adds an empty exit > function. > > Reported-and-tested-by: John Donnelly > Acked-by: Ard Biesheuvel > Signed-off-by: Jason A. Donenfeld > --- > v1->v2: > - Fix typo in commit message. > > lib/crypto/chacha20poly1305.c | 5 +++++ > 1 file changed, 5 insertions(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt