Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1616178pxb; Fri, 22 Jan 2021 23:31:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJwbLCbBiI0tkDfCt9Bo9LlFoJP6vLw3A5f2pRJzp9rlDW39HgXhcM9RJCIBul2P3J5OFXPa X-Received: by 2002:a17:906:f98e:: with SMTP id li14mr5461671ejb.415.1611387081080; Fri, 22 Jan 2021 23:31:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611387081; cv=none; d=google.com; s=arc-20160816; b=r0IR5z8hN+LqXtzW6iU6BgKi5h/MW4K5nz9K0eqET9I07Rpf2a4hBc7McxVF4lWph7 Rv8LXBB31nUKwSnwQydwOJ6uGZxTxfq5onegk7sJ4aQLjFHOMJu0pKZhQ8lK7HH8J4pI bpXCl9fcuUQRAV6pykWEX7KrrzX4CrUyPmqxMTKqncjMIyOPcTZoAKMqUddoqBs4AtxE rWUMo4yJcocwJ7J5wjlAx0ZX4hdDsB6mEeUJ1HURzVjG8yAEjZPjpy7AMGQfCIpdRfSy uQBCcIL7SPAfb8CKmDa3ZkVqr/qRNHKwnGIgQkZLKiXWB1ghKZlt/y/fEciImJX4/7dZ PWmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:ironport-sdr:ironport-sdr; bh=RjzDwcrAosyPH7CsrCzwPRr/SkJPRjpNIawrN4rgisY=; b=C0dGxkEZYB6XyEDVD7qxw+McBOp+E8qDS0GVpoJnaNjbvq7ed+vk11Sf/wxIbBJVI3 OzatXmgQEi2XYRuOqYomlSswygm/1g+Dyd6A+7ljEliKcf3c/IJgaUmK3AXjz3g4jF+O 8Hpld6JnF/rRW5Ss1cnWyPJ3cG5xC17t2rnsluIdfAEOwdX+f/lKAYuGTfUklqELMatb QLP4In7PAm4r/md7Zz5GP2VM5z8BkURUJCvuMA6J4qbV5PUKPCu863VVKlpJbulY7yWS IXzICkZ5RNaDk8oNtoPbWVeNt1ddKjWY6z4lEZdN0nFwXdYXOwnarWIITmFGSvel2Jt7 caXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i8si1609669edj.556.2021.01.22.23.30.47; Fri, 22 Jan 2021 23:31:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726653AbhAWHad (ORCPT + 99 others); Sat, 23 Jan 2021 02:30:33 -0500 Received: from mga12.intel.com ([192.55.52.136]:5181 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726554AbhAWHa1 (ORCPT ); Sat, 23 Jan 2021 02:30:27 -0500 IronPort-SDR: LNvGXDreA2bx0O1SB96cJdPzCrkZM5nlFHABVkeCYwWojiaJobq8DOjt5pLI9CquYx7CdpqLIh Be3R4cdMxZjA== X-IronPort-AV: E=McAfee;i="6000,8403,9872"; a="158731937" X-IronPort-AV: E=Sophos;i="5.79,368,1602572400"; d="scan'208";a="158731937" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 23:29:46 -0800 IronPort-SDR: jweNwgZwbiHJEwpumDYufN77NgHYXIBtWVHVmvtsfymjvenUBXGQk8pLFBIZIdvuC2kLKK2f2Z XnEvXOjhYXgw== X-IronPort-AV: E=Sophos;i="5.79,368,1602572400"; d="scan'208";a="468448073" Received: from megha-z97x-ud7-th.sc.intel.com ([143.183.85.154]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 22 Jan 2021 23:29:46 -0800 From: Megha Dey To: linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net Cc: ravi.v.shankar@intel.com, tim.c.chen@intel.com, andi.kleen@intel.com, dave.hansen@intel.com, megha.dey@intel.com, greg.b.tucker@intel.com, robert.a.kasten@intel.com, rajendrakumar.chinnaiyan@intel.com, tomasz.kantecki@intel.com, ryan.d.saffores@intel.com, ilya.albrekht@intel.com, kyung.min.park@intel.com, tony.luck@intel.com, ira.weiny@intel.com, ebiggers@kernel.org, ardb@kernel.org Subject: [RFC V2 1/5] crypto: aesni - fix coding style for if/else block Date: Fri, 22 Jan 2021 23:28:36 -0800 Message-Id: <1611386920-28579-2-git-send-email-megha.dey@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1611386920-28579-1-git-send-email-megha.dey@intel.com> References: <1611386920-28579-1-git-send-email-megha.dey@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The if-else block in aesni_init does not follow required coding conventions. If other conditionals are added to the block, it becomes very difficult to parse. Use the correct coding style instead. Reviewed-by: Ira Weiny Signed-off-by: Megha Dey --- arch/x86/crypto/aesni-intel_glue.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/x86/crypto/aesni-intel_glue.c b/arch/x86/crypto/aesni-intel_glue.c index 2144e54..e2aae07 100644 --- a/arch/x86/crypto/aesni-intel_glue.c +++ b/arch/x86/crypto/aesni-intel_glue.c @@ -1146,8 +1146,7 @@ static int __init aesni_init(void) pr_info("AVX2 version of gcm_enc/dec engaged.\n"); static_branch_enable(&gcm_use_avx); static_branch_enable(&gcm_use_avx2); - } else - if (boot_cpu_has(X86_FEATURE_AVX)) { + } else if (boot_cpu_has(X86_FEATURE_AVX)) { pr_info("AVX version of gcm_enc/dec engaged.\n"); static_branch_enable(&gcm_use_avx); } else { -- 2.7.4