Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp132242pxb; Wed, 27 Jan 2021 04:08:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJy8oCm0zdaK3mFCHHpFZlH70oc0uPxdma7YbGcpyoTUAXuvLYwjEK5//w67gesArl/ddOi+ X-Received: by 2002:a17:906:2755:: with SMTP id a21mr6653728ejd.374.1611749338176; Wed, 27 Jan 2021 04:08:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1611749338; cv=none; d=google.com; s=arc-20160816; b=m69cEbJpkfRdi4Fue2NK4y++0GGT7X2zJfhbf5fD+yRv3rHbQixxrGoiNBuN3fKS/9 QX9TSdmtRZMmwfjM+wAY48heNkIEG1iwQ7pWpX++6FR6iLF5+lNupMkQqqwn1ftPoBF+ e3rBIuoYOwQRaJVY7OPEB5JjIDk3KTBcwR88qRr5l4k0xEhaC4rKaSW9Jbg8zxJ8MK8j GDobdvbEOUXLFdMjVueKQXpFKicq10ASSwrqOvoVwgjSlr0jiBdKAEO7my631d92ybB6 sSCuK0/PHWnYIPECEGxobmbIfMCZMR5Kbo9nw853O4TibD3JdviNqsU/Hhv9F+yKGGtU l9tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8sDysVSBeFV7ZYdo/eK8xteoDfHwwf+DqJhW85+zkyY=; b=z3OmZMYqfOUKs/c+q6Tybm1oBmeULuQYlsHVndTPFWrCbEC8Eqv9L8IGVcarIQiPFJ NIuv1vSaOTq/loD1Kwsb7Q6LNsl4aLNYanr2fx3eRumsW+ipyzKWt/qyB5fnT9OhP8eY mGYUmgF4RHh2OG7tLtGF2T9McGcOBge+wmJkv1wbfX5NA9Epwj38QUMiOZUyh8kCH7/c 2e9aem+9aKKMbDmq+1yrGymEeM9alV3fSUHTcxI2wrz/jh6bRTP5MbPs/kVYydgs22Bp eG3JLeKzbQlCUreNF/IYkCTrDlDH5r7Dgy4PoSA8B1Uq1+WlGIvEmshikfbhBSgd7OwW HBSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=M8giB4OR; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bt2si909195edb.89.2021.01.27.04.08.26; Wed, 27 Jan 2021 04:08:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=M8giB4OR; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237580AbhA0MGb (ORCPT + 99 others); Wed, 27 Jan 2021 07:06:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:41492 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237582AbhA0MDx (ORCPT ); Wed, 27 Jan 2021 07:03:53 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1227220773; Wed, 27 Jan 2021 12:03:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611748991; bh=s9FyWRqQBYLlzUUdBkv3FZQxudbP70KKsuwRkeHWHEI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M8giB4ORvL3mx55LaDcj1/tIi+BhFJb4mO4m9pyBQqvZIwgP2vqkgkDOQ4I1vn8HH U8aP648RT1pUgCmU92gSCKiLyN0XGWtBCyfjACVz8RiJzgpFsPQ6OWW77wlJfo28NM bwp9LYhhA6QMhnElnHGF3hN0OdPBasyFUrm9T7kg= Date: Wed, 27 Jan 2021 13:03:08 +0100 From: Greg Kroah-Hartman To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Russell King , Matt Mackall , Herbert Xu , Vinod Koul , Dan Williams , Eric Anholt , David Airlie , Daniel Vetter , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Dmitry Torokhov , Vladimir Zapolskiy , Krzysztof Kozlowski , Ulf Hansson , Alessandro Zummo , Alexandre Belloni , Mark Brown , Jiri Slaby , Eric Auger , Alex Williamson , Cornelia Huck , Wim Van Sebroeck , Guenter Roeck , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, kernel@pengutronix.de, Mike Leach , Leo Yan , Arnd Bergmann , linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-i2c@vger.kernel.org, linux-input@vger.kernel.org, linux-mmc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-spi@vger.kernel.org, linux-serial@vger.kernel.org, kvm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-watchdog@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v3 4/5] amba: Make the remove callback return void Message-ID: References: <20210126165835.687514-1-u.kleine-koenig@pengutronix.de> <20210126165835.687514-5-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210126165835.687514-5-u.kleine-koenig@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jan 26, 2021 at 05:58:34PM +0100, Uwe Kleine-K?nig wrote: > All amba drivers return 0 in their remove callback. Together with the > driver core ignoring the return value anyhow, it doesn't make sense to > return a value here. > > Change the remove prototype to return void, which makes it explicit that > returning an error value doesn't work as expected. This simplifies changing > the core remove callback to return void, too. > > Reviewed-by: Ulf Hansson > Reviewed-by: Arnd Bergmann > Acked-by: Alexandre Belloni > Acked-by: Dmitry Torokhov > Acked-by: Krzysztof Kozlowski # for drivers/memory > Acked-by: Mark Brown > Acked-by: Dmitry Torokhov > Acked-by: Linus Walleij > Signed-off-by: Uwe Kleine-K?nig Acked-by: Greg Kroah-Hartman