Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v6 2/4] x509: Detect sm2 keys by their parameters OID
To:     Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
        keyrings@vger.kernel.org, linux-crypto@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, patrick@puiterwijk.org,
        linux-integrity@vger.kernel.org,
        David Howells <dhowells@redhat.com>
References: <20210131233301.1301787-1-stefanb@linux.ibm.com>
 <20210131233301.1301787-3-stefanb@linux.ibm.com>
 <75a8ff37-3c23-6cf1-f844-cf692eb8adfc@linux.alibaba.com>
From:   Stefan Berger <stefanb@linux.ibm.com>
Message-ID: <ace09744-e6c9-32da-27d8-accadd5d0252@linux.ibm.com>
Date:   Mon, 1 Feb 2021 08:02:21 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <75a8ff37-3c23-6cf1-f844-cf692eb8adfc@linux.alibaba.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

On 2/1/21 5:39 AM, Tianjia Zhang wrote:
>
>> index f7ad43f28579..508e0b34b5f0 100644
>> --- a/lib/oid_registry.c
>> +++ b/lib/oid_registry.c
>> @@ -11,6 +11,7 @@
>>   #include <linux/kernel.h>
>>   #include <linux/errno.h>
>>   #include <linux/bug.h>
>> +#include <linux/asn1.h>
>>   #include "oid_registry_data.c"
>>     MODULE_DESCRIPTION("OID Registry");
>> @@ -92,6 +93,18 @@ enum OID look_up_OID(const void *data, size_t 
>> datasize)
>>   }
>>   EXPORT_SYMBOL_GPL(look_up_OID);
>>   +int parse_OID(const void *data, size_t datasize, enum OID *oid)
>> +{
>> +    const unsigned char *v = data;
>> +
>> +    if (datasize < 2 || v[0] != ASN1_OID || v[1] != datasize - 2)
>> +        return -EBADMSG;
>> +
>> +    *oid = look_up_OID(data + 2, datasize - 2);
>> +    return 0;
>> +}
>> +EXPORT_SYMBOL_GPL(parse_OID);
>> +
>>   /*
>>    * sprint_OID - Print an Object Identifier into a buffer
>>    * @data: The encoded OID to print
>>
>
> Great job, I'm just curious why we need to add a new function, this 
> seems unnecessary, if possible, please add


Thanks. I call this function in two places now. I thought it was 'worth it'.


>
> Reviewed-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
>
> Best regards,
> Tianjia