Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp3808470pxb; Mon, 1 Feb 2021 05:25:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJyKIz/EjlFc2FB97R6/3Bw982qCGKnh07VtQu83amA5N+N0uBjYu86aTLVhBzqZ9dZfkEml X-Received: by 2002:a05:6402:95a:: with SMTP id h26mr18298175edz.288.1612185939295; Mon, 01 Feb 2021 05:25:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612185939; cv=none; d=google.com; s=arc-20160816; b=ApqqeOsvoHJ/EkRvnTYQT9fPkp0Dxx2G0tl3/E91My3NDEcKjyxe9UAog5gROMpXtf 317YvgVUEsg8QFqjbiB5opdOF+zYmNEJBpm4GTegUh/7dvCo2OFGw2QCErKHpRhHAHSB LKxEtXsEuwn+r8y6W/wsrrC4KEoZXMsXrjUWaAZwJ0p3EXnTkYdXxsuUw2h5KUNLLGxa W2tAmCvNlV+4cJaulYu32yZD9xaRhi4bNfub153xXHI5BhTljszIBxpqAcsxYNLHHlKB r2e940eu4IM08rxr1yq8xWRenSRxUkCq1ppCjzKcNCIAJ1/+atHwEnr9SFkPQzgOLUDx t8UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=rQ/8somOMzVQ3Ad0/BqJlYP8xwKLNGrctlhtSE/sB/I=; b=JzXo6kbY6O4Dd7tSiYZ2LCyiGgSVJ5HMDcbSV9GezNbtzme47AqEXgvrWKpy9F5g9W QO3AQR5gksjIjaNWphJTeJc0/bpED/FW28ghu8e373cYk2FnLKKZXrl0RWym7/vZ4O++ gDVLl0eXwv+YuS4OW6s52nVc4Nyp0Ph3CvssvLpIHv9p+Q9LztYI7jAL9HUTC7WtmOso M24FH7rDRYBNiBkgDB3u0NIFj+cAUlXbVVilnyRxQ/xvsr3fZDmvhx8WbpcvJpP1bIlP 2Z2wtBsTsurm/rFB/8bjBWyCNZI1mQKB4fGsbD9VQI48yxgVcEzZpivpmJa/2USs2eUS 1Gqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LhkXtSfX; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m6si13460273ejl.643.2021.02.01.05.25.09; Mon, 01 Feb 2021 05:25:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LhkXtSfX; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231657AbhBANY6 (ORCPT + 99 others); Mon, 1 Feb 2021 08:24:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:57467 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231594AbhBANY4 (ORCPT ); Mon, 1 Feb 2021 08:24:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612185809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rQ/8somOMzVQ3Ad0/BqJlYP8xwKLNGrctlhtSE/sB/I=; b=LhkXtSfXOYajsDHK5G6TAdzvT+BsgG74Y36NJog0uZP49b3/ldGjPrXjGFInsiKJoLnD17 vUb3oatpp6d/gD29EZCHnAUNkTP93tTGVfR+ABpf82nGECZ5CQtmfuaMeHtppPxeTMYEs5 PG1jDxgGGw2oZXkuDhjNUdcY4iOqIoQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-64-LohhxNHYM92gXIkYNSwnsw-1; Mon, 01 Feb 2021 08:23:25 -0500 X-MC-Unique: LohhxNHYM92gXIkYNSwnsw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F4119802B47; Mon, 1 Feb 2021 13:23:23 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-115-23.rdu2.redhat.com [10.10.115.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 957D210016DB; Mon, 1 Feb 2021 13:23:22 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210129150355.850093-3-stefanb@linux.vnet.ibm.com> References: <20210129150355.850093-3-stefanb@linux.vnet.ibm.com> <20210129150355.850093-1-stefanb@linux.vnet.ibm.com> To: Stefan Berger Cc: dhowells@redhat.com, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, patrick@puiterwijk.org, linux-integrity@vger.kernel.org, Stefan Berger Subject: Re: [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4162800.1612185801.1@warthog.procyon.org.uk> Date: Mon, 01 Feb 2021 13:23:21 +0000 Message-ID: <4162801.1612185801@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Stefan Berger wrote: > From: Stefan Berger > > Detect whether a key is an sm2 type of key by its OID in the parameters > array rather than assuming that everything under OID_id_ecPublicKey > is sm2, which is not the case. > > Signed-off-by: Stefan Berger > Cc: David Howells > Cc: keyrings@vger.kernel.org I presume these cc's are intentionally not on the first patch or the cover (if there is one)? Do you have a branch you want me to pull or did you want me to take just patches 2-4? David