Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     linux-crypto@vger.kernel.org
Cc:     antoine.tenart@bootlin.com, pascalvanl@gmail.com,
        =?UTF-8?Q?Piotr_Kr=c3=b3l?= <piotr.krol@3mdeb.com>
From:   Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
Subject: safexcel driver for EIP197 and mini firmware features
Message-ID: <d90956cf-5340-cbe4-1254-771c18b7e46d@3mdeb.com>
Date:   Mon, 1 Feb 2021 19:52:42 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

Hello,

I am interested in using the EIP197 crypto accelerator. I am aware that 
it requires an NDA
to obtain the firmware for it, but I found out that there is some kind 
of "minifw" as well
in the linux-firmware tree [3]. I found no description of it - I would 
like to learn what
are the features and limitations of this "minifw".

I started with using it on the Debian image from board vendor [2]. The 
kernel here is
5.1.0. The firmware is loaded, but the ALG tests are all failing:

[14785.750246] crypto-safexcel f2800000.crypto: firmware: direct-loading 
firmware inside-secure/eip197b/ifpp.bin
[14785.762765] crypto-safexcel f2800000.crypto: firmware: direct-loading 
firmware inside-secure/eip197b/ipue.bin
[14785.777978] alg: skcipher: safexcel-cbc-des encryption test failed 
(wrong output IV) on test vector 0, cfg="in-place"
[14785.788661] 00000000: fe dc ba 98 76 54 32 10
[14785.800606] alg: skcipher: safexcel-cbc-des3_ede encryption test 
failed (wrong output IV) on test vector 0, cfg="in-place"
[14785.811720] 00000000: 7d 33 88 93 0f 93 b2 42
[14785.823734] alg: skcipher: safexcel-cbc-aes encryption test failed 
(wrong output IV) on test vector 0, cfg="in-place"
[14785.834439] 00000000: 3d af ba 42 9d 9e b4 30 b4 22 da 80 2c 9f ac 41
[14785.884568] alg: hash: safexcel-hmac-sha224 test failed (wrong 
result) on test vector 3, cfg="init+update+update+final two even splits"
[14785.901836] alg: hash: safexcel-hmac-sha256 test failed (wrong 
result) on test vector 2, cfg="import/export"
[14785.926693] alg: aead: safexcel-authenc-hmac-sha1-cbc-aes encryption 
test failed (wrong result) on test vector 0, cfg="misaligned splits 
crossing pages, inplace"
[14785.944430] alg: No test for authenc(hmac(sha224),cbc(aes)) 
(safexcel-authenc-hmac-sha224-cbc-aes)
[14785.956978] alg: aead: safexcel-authenc-hmac-sha256-cbc-aes 
encryption test failed (wrong result) on test vector 0, cfg="two even 
aligned splits"
[14785.973472] alg: No test for authenc(hmac(sha384),cbc(aes)) 
(safexcel-authenc-hmac-sha384-cbc-aes)
[14785.986103] alg: aead: safexcel-authenc-hmac-sha512-cbc-aes 
encryption test failed (wrong result) on test vector 0, cfg="two even 
aligned splits"


I am going to test it with more recent, mainline kernel as well, but it 
would be still nice to learn
a little bit more about this "minifw", it's features, and what could be 
possibly achieved on this
board without proprietary (and behind NDA) crypto firmware.

Thank you,


[1] 
https://www.solid-run.com/embedded-networking/marvell-armada-family/clearfog-gt-8k/
[2] https://images.solid-build.xyz/8040/Debian/
[3] 
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/inside-secure/eip197_minifw/ifpp.bin?id=eefb5f7410150c00d0ab5c41c5d817ae9bf449b3

-- 
Maciej Pijanowski
Embedded Systems Engineer
GPG: 9963C36AAC3B2B46
https://3mdeb.com | @3mdeb_com