Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 15/20] crypto: caam: caamalg_qi2: Supply a couple of
 'fallback' related descriptions
To:     Lee Jones <lee.jones@linaro.org>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Aymen Sghaier <aymen.sghaier@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
References: <20210204111000.2800436-1-lee.jones@linaro.org>
 <20210204111000.2800436-16-lee.jones@linaro.org>
From:   =?UTF-8?Q?Horia_Geant=c4=83?= <horia.geanta@nxp.com>
Message-ID: <963b9e57-8077-5392-1d91-a5971e8d8ac5@nxp.com>
Date:   Mon, 8 Feb 2021 21:49:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
In-Reply-To: <20210204111000.2800436-16-lee.jones@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.0.129] (78.97.206.147) by AM0PR10CA0010.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:17c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.19 via Frontend Transport; Mon, 8 Feb 2021 19:49:25 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: f07ead86-9c4a-4939-28a9-08d8cc6aa42c
X-MS-TrafficTypeDiagnostic: VI1PR04MB5040:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR04MB5040FE090E2C5695F8BF44D5988F9@VI1PR04MB5040.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: LDEAhFaVcbxUauiCVqI1tsN5HIKYjeP5rJubBWsYjJXR9t84/adivz3gcilOj7VH3z2veVIfvkxRgCmnTnRE5tsGtIuCtFKSXx5GtJgQe0b4RHkLsUtwsXAxuF+qGjpIrPuB5WybTPLXR4fgiISo8g7tWa/HjdG/XsCm6xsU+doe9KW/O1gBEgIJk/KXrNoQvgVZBI1xgLZrA8iGeIe25EPbgy7C41IU82rfZKjLVwNufjs67Z5nynDqr7ijtaEesOQ4sEQcP8ku0i1YWwXkRxd6FOWi4jdH3xlNDkeEMCNKGL3MQdpDaLeAIt95BVfAcLOSGq/ZXU4/gymod2NmQx1pyxz/nFEH15VoxC8uoFMbCUFdeL4speOmhyFuBC9LHjz9kfhJ9lbYD5nsW6qWJA83fjas/yT3fTegE8hjRwUVh5vKUT4EfCp+sObNh4PQXegkGSa5Th7gatjVpuSVUEWeQLK8o3enoTv3anudRV8cbOR6I++ngG0KGW9u6nczbnzHhA42BElesKGh0AWNOs/pzcMkxUZhkjc6OySF0xmh9GUOoTIzONWty2yU+lm239fJR5Jms2TdD4vJKklh23BpD+sjwozbfFLZR1HleP8=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB4046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(376002)(366004)(346002)(136003)(54906003)(6486002)(2616005)(31686004)(2906002)(5660300002)(66476007)(66946007)(4326008)(8676002)(16576012)(66556008)(6916009)(53546011)(83380400001)(8936002)(16526019)(186003)(26005)(956004)(86362001)(31696002)(316002)(478600001)(52116002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?YzNMblhCb1F3b0E2Rzgxd0hwRU9LQTlzUzFid1ZnbFJsZ2xnNUwwTHBJU2l1?=
 =?utf-8?B?YlZVeis0Myt5Wm4wQmtSVm53ZDk3Y0J6Qjg2Y0lhQVFFb0ZocFl1WTdpU05y?=
 =?utf-8?B?VkI3anhzQXEzLzlJd21KZEpyK3ZFbVNIM3dMeVdxZzBqM1ZEWld4UnJIK2pP?=
 =?utf-8?B?QW93U1gzdksxZlJTckhQUXVlVGE3ckZqdEFMZ3dZVWovT0NQWXlOWG9mUVN2?=
 =?utf-8?B?UERmMkRBMXk4M2ZJTnhQTUwwVUZyVjRTSlRVVkF3TS9PamJLNXlYUzE5bU9p?=
 =?utf-8?B?THllUkV6V0lucW5qcHF2LzVqY3JENUp1VDdWc0dDR3ZpQ0hiM2RVTjE3WWRw?=
 =?utf-8?B?eWszRHVaTk1CeWxaTVNpdnU2SGprYXhXVnpSQVFhOVhaS3ZqV1VnUjBudmVV?=
 =?utf-8?B?NEVUS2FVbnZ3YmVNRnM2NGY1S2NqNWhobW44L3BqNHQzZ1hzTHBBUEhta2g3?=
 =?utf-8?B?SURRMEJOVmtlcVhXSUZ4MkZRK0dBL2UxT3FkOHVFZ1VhNDF2blNRc2FMT0tB?=
 =?utf-8?B?cWN2NlZBOUZXczRYZ2toODlpSVZaMTB6ZVIybmpFZEpsWWJTb05wRlVia0c4?=
 =?utf-8?B?TlN6SUM5cWZja0ZXZ3RuRGhibTNONHU4a21lOWg5VS8yN0VWTXhGc0ZZNnlS?=
 =?utf-8?B?dzEwRXlHNVNTQzZtVjJyTVZYcmx4YjF3OVpWYzJaTTZ3L1BPdEtLZ2JmWjha?=
 =?utf-8?B?MUFtYklOTWgyYnNYN3RQQnN1NFpjejhiUEJmaVRMRXovTnQzWk9venhlNjlM?=
 =?utf-8?B?STFSeGVVRWNTTDlrdTMrMGh1VExNNm9PVFRmRS9iZDZMVWxpT2lTR2E4WlZ4?=
 =?utf-8?B?S1pvY2J0L0NtRjcwbkFDejJQemRmNGEzZ05xQWZZVkZRSWpUMWRsZ002cjFW?=
 =?utf-8?B?N2EvNk9qNi9HL08rUWZhaFV3ZnlzTTVqa0M4dlJxakJDV0F3N3NDZlp3aDFT?=
 =?utf-8?B?SFdRTVRyZ0RkdHB3cTNaUEFpakc0VTl0VDVTV25iczJIazVIbzR0YldCNHRo?=
 =?utf-8?B?bzdBYVZ5ZmlwK2gxL2tBWlkxd3Y3L0d0QWFBL3pjT3p2a1U1UEtqemRsTkVZ?=
 =?utf-8?B?QmtDbDB1aUMxOWlTdXcxRDFJTkFUOE1WNlFGVHVuSG1nK2R6TnNUcHpWWm5H?=
 =?utf-8?B?eFZMaEc3SVVxaVlVZVBTcEZacFBHSHlndGt6TG56SlRRUlZqMFVqZWpGZkVC?=
 =?utf-8?B?ZnB1WFY3dlVSTmp2dUtKSzZoZGtLWkc1bFA0NmY5dVFEZEg5UVhpZGViTFFZ?=
 =?utf-8?B?Njk0RERxSlZHZXdDOXVDVlM2dTVoekpidmcxZGVVKyt4OEVPamVHY3NOdXIw?=
 =?utf-8?B?c1hlRndxL1h0SnkzeUlDL2dGaGlHWUUzQ1RBU05TN2IwbkQ4L1ViZ3RmNnNp?=
 =?utf-8?B?ekJrdThpZlFzY0dRb2pEdnJOanZMZUVxQWZodG05Q0NxWCtHRFNoUGp6cEtT?=
 =?utf-8?B?UE9SdktPNHhPUk1QWkkxZWE0Rm04cTF2UmNUTk9IUXhsWlJtMUxla1RlUHMy?=
 =?utf-8?B?SlZxejVaNkFleXhJSUQyS1lEWXFDVnlkeWs2b3pJOG1YUW1OaVV4TmNJbkhW?=
 =?utf-8?B?N2ZLWjBubjZlOGszQXc5YUZnMnlxZHMwc29UbnJuVTNPaFo5MCtSaytUREd3?=
 =?utf-8?B?K1ZQQVpVeUVUNmU5ZmVYSXBEc1ZTelF0TElJeFFDMG5uUWxKSGlSUkxOdTVa?=
 =?utf-8?B?akk5dHJtbytmTjB2RzBtWllBL3crS2pEV0phTEtwTWRTWTcrSGhpd0hBUXJI?=
 =?utf-8?Q?ZsJNo+X5tc9NoxtjJLpA3Ll8Kog5on2AOXsrUjN?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f07ead86-9c4a-4939-28a9-08d8cc6aa42c
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2021 19:49:26.7541
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hE4uONDzD4tEhL/fBP7wrdopNJ+PXHXT6312MAbtTN/1kLylr79r4lL/Zk5FLewXUUb3DyN633ftLIk6PQmy0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5040
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 2/4/2021 1:10 PM, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member 'xts_key_fallback' not described in 'caam_ctx'
>  drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member 'fallback' not described in 'caam_ctx'
> 
> Cc: "Horia Geantă" <horia.geanta@nxp.com>
> Cc: Aymen Sghaier <aymen.sghaier@nxp.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/crypto/caam/caamalg_qi2.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/crypto/caam/caamalg_qi2.c b/drivers/crypto/caam/caamalg_qi2.c
> index a780e627838ae..22e45c5bf2023 100644
> --- a/drivers/crypto/caam/caamalg_qi2.c
> +++ b/drivers/crypto/caam/caamalg_qi2.c
> @@ -71,6 +71,8 @@ struct caam_skcipher_alg {
>   * @adata: authentication algorithm details
>   * @cdata: encryption algorithm details
>   * @authsize: authentication tag (a.k.a. ICV / MAC) size
> + * @xts_key_fallback: whether to set the fallback key
true if fallback tfm needs to be used due to unsupported xts key lengths.

> + * @fallback: the fallback key
xts fallback tfm

Horia