Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp901614pxb; Tue, 9 Feb 2021 16:06:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJxHbamrnEEtSZdt1fwhhq9RHR4CHe1RHyfXeerEswL+VZwzeHuXOooS/VC+o3cnVBoSr8a2 X-Received: by 2002:a17:906:398c:: with SMTP id h12mr198927eje.469.1612915580774; Tue, 09 Feb 2021 16:06:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612915580; cv=none; d=google.com; s=arc-20160816; b=UXGALQNHFXGyyZI/1oDOKy4s8NiQQuVhXmCAxrdHTp3VCZVI9fbiVcgyFMXgDJPsr8 CKuPOou+nGRG2sc8FlNtUNYmeicxySKJpLy3wifWFK93n57baY1coIfBLQXkvKV/qsbO y3Tw2yZJQhqhiCZ/yafxjCR2DPcSpm9EJhpvfSdNO5PopVVBjW1vN778mv1Ojb8PofVO WqonuRs1nb/BYx9QtzN6eleBkCyeV15YpPwVHKxZJyoBhNSIfX61xinmP83r6EG8M3/d fFsrrcYXgHxhoAF/yQnImWBknDJTpjF2uiUQxlHwtc83JChzSfoaCsfCjh7vFqvu+WQk KuIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:dkim-signature; bh=bf6rDz3RThopKOO26affWvf/n+6BrP/JogTONi+OpqA=; b=PyrdOK9oSNa1tTa4xzvWBRekr8RSuhCPeDHbphmrAqjiXAzyJaS0TrXAPPZGpHSBMx v8y6wVukCumNU9ymktPWnxEPOuvqJdGjxCUaM4Zc0N0pivNkjnKIYPrznyWrTZgAS7kS UlObJm9hpC2wtPB8hcoti6afe1bDUdClzuDTv4K3/xV2TebRRNI6cXvJjMBJFaqTw2fK e0xpLpcEvLwm49NnToIUedSQQdpZjjO/eQJB10JfoKJQOf3e5YdZDCmRmyhxH6nx215Z tuvcsZcIc9Gx3Xdxiy9pMEyuBRveFyrDM3o5Bc99gyztm9de5iV5MqWdZ/ln/lKAdftr mibg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YIJm3wB0; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h14si141269ejt.198.2021.02.09.16.05.38; Tue, 09 Feb 2021 16:06:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YIJm3wB0; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234804AbhBJAEA (ORCPT + 99 others); Tue, 9 Feb 2021 19:04:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233918AbhBIWzS (ORCPT ); Tue, 9 Feb 2021 17:55:18 -0500 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C09EC061793 for ; Tue, 9 Feb 2021 14:54:38 -0800 (PST) Received: by mail-pj1-x102b.google.com with SMTP id gx20so21885pjb.1 for ; Tue, 09 Feb 2021 14:54:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bf6rDz3RThopKOO26affWvf/n+6BrP/JogTONi+OpqA=; b=YIJm3wB0iZOPAF0MaJ1SWN/AYK/Ini8e/XquSFspgckgSgIyqTp91o+LVOh46Cf7nM JxXCWt2OiBKwx1TLlH3VCTh1qEiJ9IFagFSbhicXYw5twJxwAl1OAQLWzf+pLxGlE9ic 6fTTAvKAmDF6Sb2Y1NFqPJOfVndVJudE1eGKDDjV5cwVfJaCsqt8KavAV1pfvTZcNMz4 oiMD5n9EH7Sl3Xwu1wRknY39gF9lg6SlBMAprHijJJzaPuFqyEpsqYEHTSQUw2DujPI2 iiEuc1y1Ale3i/ebqqtxlqHyqH4IHIaO/18H7uWN3AFDv+gxS1+DkkYvplVg7sJcSo3a XTyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=bf6rDz3RThopKOO26affWvf/n+6BrP/JogTONi+OpqA=; b=H/f8igimhCd8hq8vdms5IgSRu5NDP+YZpUmsIA0KxqwG8D1BBnj43SBEJWcPKNcSmG JhVuugT9FdPF8cB+7vieJBgi3FhHd2T4c0f9zXqpSHBFL9+UB+cvMhVCTP+haSndVoWj sLJB8fr2k7LJsNQQBvdYu11Tl6kKAham0TpMMp1VnFqYNMv3IX3l5Hstlb9HMQKzGDeM BN19LVYuIPYvLBDs4FHKkgy3wpYlou2cKchgB8faulhXIJwREReOg9dyc0olM4HMOk1L GYUVonVafPZhE1d6YVUh6rgUjc1woqMUCRIIpuhefti3OA3N541Mevbdj7b0bqmAy/AR rfYw== X-Gm-Message-State: AOAM531ImBf5ucV6MQjTYcfi+NOQIUvJi1zUsiaa3nPRoWyxMLMdOPv5 UTiwqreF9ZfmqR5v0wRr7KU= X-Received: by 2002:a17:90b:1650:: with SMTP id il16mr117711pjb.97.1612911277775; Tue, 09 Feb 2021 14:54:37 -0800 (PST) Received: from [10.67.49.228] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id y26sm15242pgk.42.2021.02.09.14.54.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Feb 2021 14:54:37 -0800 (PST) Subject: Re: [PATCH] hwrng: bcm2835 - remove redundant null check To: Tian Tao , rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com Cc: linux-crypto@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <1612851911-57937-1-git-send-email-tiantao6@hisilicon.com> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <90d50456-2693-bb01-2ae6-0da53c0f456d@gmail.com> Date: Tue, 9 Feb 2021 14:54:34 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1612851911-57937-1-git-send-email-tiantao6@hisilicon.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 2/8/21 10:25 PM, Tian Tao wrote: > clk_prepare_enable() and clk_disable_unprepare() will check > NULL clock parameter, so It is not necessary to add additional checks. > > Signed-off-by: Tian Tao I don't believe this is going to work unless you also change devm_clk_get() to devm_clk_get_optional() which will deal with -ENOENT and return NULL in that case, once you do that we can remove the NULL pointer checks. -- Florian