Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp946507pxb; Tue, 9 Feb 2021 17:36:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJySg5220wZ1/bO18vmju/5a3ztTs7Yt/+0mWea3ataR9zllv6Qc0fXb3rYAubytyioQJHio X-Received: by 2002:a17:906:30cd:: with SMTP id b13mr552704ejb.336.1612920995520; Tue, 09 Feb 2021 17:36:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612920995; cv=none; d=google.com; s=arc-20160816; b=X/OLQD1miCgoa49tO2Ivqaij/4nBPsfkeKlXHWRotAWsP+AzYv+O6w1IIOj795rd9O UyvFTypD475aLK+keKEELw+xHQWbmjNc6meRc7pme6bAEMGbR2nbIyOdJgLniDk8aw1P +RwEDwezZIlNUhVtgKCXH8Ryqy1pNvwESnDP/kNmvFjX6mCIcGWX/vMW1Ce00Kw/7KfO yco5zhvwyKb477scALVnHxyQ1ctjcIj9YmqJm5R/+3oomotCnlXZIQyQwuerDmt4HO+5 Hvna6pysAdfR78yJdFU4Qbq3521CDTTXWUbXgVw3EAXguf8ysnha+8w6h9KSO4ksJcuy rtow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=t6voKTk6/OdOzOuPgN0xYWNzCZPSi7LG5qfSMC9hkY0=; b=NW8NhwYJefhUPEeglUE2Tvz6FQzCj5DKIoOVQaHXt/kCRjhLPHhdekFL6KvN5hVEkf Gv5NNtO1Pauih4D7K4Zt0ja3FZQoBPdIWwESIH5KHbjYHfMC0pTVIgbACPHq9P5oHHeo r6xKJguAXvel492/b36igmGiyelYmDH0TY6N13W5MZ3dc8q5yaqjmqKWyg2C2DrQdNrk aO2xr+AH/nmf9jd1rt4lu/J3DC9A6Ak33uahdHMGZ1y+dOdDuYvw3XOv1MxTq4GlwO5c jgdufZPPPhII4LRg5DkF820KJcHeKUTjF4lLW1svcBtBJPiz2hdBL6FWI/lqSKO82wbc kuEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ump3YhBM; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a1si360765edj.524.2021.02.09.17.36.05; Tue, 09 Feb 2021 17:36:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ump3YhBM; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234059AbhBJBfi (ORCPT + 99 others); Tue, 9 Feb 2021 20:35:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233968AbhBJBdc (ORCPT ); Tue, 9 Feb 2021 20:33:32 -0500 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C161BC0613D6 for ; Tue, 9 Feb 2021 17:32:52 -0800 (PST) Received: by mail-pl1-x631.google.com with SMTP id b8so300471plh.12 for ; Tue, 09 Feb 2021 17:32:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=t6voKTk6/OdOzOuPgN0xYWNzCZPSi7LG5qfSMC9hkY0=; b=Ump3YhBMnDO6jOwbzAYdSdwi+bxYNZoVhs1d7kKrZcMxTs6PGLNTpwTuNk5bOETuA8 USrvPZo9BBRCr3cLqHbLUCN9nB4DT253/NxqYBg7aKS5ugqRK8Dwtkh4wImZq36FXFtf BqKr8byaMDB6nQ4RDMNrWYGqCA4zqvo6BrZ4PKLtwOg7WSuN070wpz8zBisKU619vV8O dCos8kBnDXRkLJPpXZl7r+QzYwZyBuYfT3gXOCn1LY34XuQoe9jx+j2FygwYhAH99cWT 47/fysUZ1Zw+CUE4jc5VQjOAQd8bEP/s4pyip5P54E0yNb3aXmS+jODmJrys7qKaxl3S j5rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=t6voKTk6/OdOzOuPgN0xYWNzCZPSi7LG5qfSMC9hkY0=; b=darskbZTmkQ3j0+fMwnT0B7OCSyTU+OCedp+z8sJ2avKiqb2DGSJ0SbZfeWjPrxvRQ 8OVFl55HyqcEpsE75q71GCEf55GPcpuYDALVvshPBWbT8rDPFp9KYgC2jwOHE84jXv6g SLPuruO0Rer3UXs7cnPt0rhxwf14vmhgiWkD/Y84Tj2dI0nHJTPW2GMinXk61i8BB3/e /oeG7jOzb9wdRG7JVyeq1tk+n1lSU5ywIMwxuxiSDFeCwYHvHORektGJbQP9tbSRr7Iu mlbDiKMvcEoG3t4VWbEPPTzPbRq0n6OX6l+1977Md8irLTG0JAFsy/WZZYqk/uJ8GmWZ sGAg== X-Gm-Message-State: AOAM533O0Wppo7jjOsX/URfeHfp0pmvqcMhzR9j4uJjPKIne20gAFSMl 0hY2hLvZQx05xosMFyizkO1UhaIAQcM= X-Received: by 2002:a17:90a:cd06:: with SMTP id d6mr731958pju.86.1612920772287; Tue, 09 Feb 2021 17:32:52 -0800 (PST) Received: from [10.230.29.30] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id z22sm171027pfa.41.2021.02.09.17.32.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Feb 2021 17:32:51 -0800 (PST) Subject: Re: [PATCH v2] hwrng: bcm2835 - remove redundant null check To: Tian Tao , sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, nsaenzjulienne@suse.de Cc: linux-crypto@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <1612919698-60261-1-git-send-email-tiantao6@hisilicon.com> From: Florian Fainelli Message-ID: <08a9cc3c-2bee-4fce-ff79-05499b11f903@gmail.com> Date: Tue, 9 Feb 2021 17:32:54 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <1612919698-60261-1-git-send-email-tiantao6@hisilicon.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 2/9/2021 5:14 PM, Tian Tao wrote: > clk_prepare_enable() and clk_disable_unprepare() will check > NULL clock parameter, so It is not necessary to add additional checks. > > Signed-off-by: Tian Tao Acked-by: Florian Fainelli Thanks for the quick spin! -- Florian