Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1139298pxb; Wed, 10 Feb 2021 00:38:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJzYGgU18we+mjyiwbL7bA3D5Iqjw/Zxc5zC/c8bccc0G8wbWljrtHqR3/sJFnBR9KeolM7h X-Received: by 2002:a05:6402:451:: with SMTP id p17mr2204623edw.248.1612946294189; Wed, 10 Feb 2021 00:38:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612946294; cv=none; d=google.com; s=arc-20160816; b=AIeZLP3v3UwWhYiyE78rkAOmyRVDuIUD4NiMiZRxPFZRY0d2InIyp4oNlIC/IA21M8 RAtb1ZOJZ3MOx2OxAVaVQAnyvZFF4VMu6jaNlKMSV+T46tSbS8oP4PFHi77Dxb9e3cia Xz2r5/OyYwkQoV/zT3jrm3GavR6SRHB5vXvimCzFSKjI3CyFA0PUAKJnt8FdXP30dGIu NGBjT7knAjL9cAXOSU/jPaWf8PRPsuL3OkQu2HrDOS0cEu7/Wm46mysRQ018beXoxyEG WnTsH6XDzA5U7w2SXn+wPDZ1gP/rrlMPL+nAdmIrYeEvfD7iWflZAUUB8fNDJHp8XumE 7uXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=1GF18YjC6UBRm2TyWYESB7N3idbwsMePHx132WFd+3s=; b=L0LL29RUe/pL/W/+9iTSJwv7TTfjbOav6Pla68BFRsu7Ze4L9g+LYR6z8yLlPFgSDY 2/7rmNdDV6WxknbIcRwBEt4zi6FUQFAt2dN1MEGyXhqrzxe09dVZNvo0Q9r4dMlmhUcZ Qz7V4iR+OYmgmZV7r52F1P8apjxUGanVVFKxvnXKIuseSqKGDZrjyPbhOViRCzYzhhYG sdqaMAXojZpkkCREHK+urI2k0fSJpOmtK22wNk2d3iZqacN67hRvCuEFxMLepxRWuyQw cjmxb5NfURmub5xigY1K0r0S1oWl88MrmaOUO54Hhkp/Fta7IfT8AUCZRRSaalllMCvg /sXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gv44si959804ejc.44.2021.02.10.00.37.51; Wed, 10 Feb 2021 00:38:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230471AbhBJGx0 (ORCPT + 99 others); Wed, 10 Feb 2021 01:53:26 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:49902 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230156AbhBJGxM (ORCPT ); Wed, 10 Feb 2021 01:53:12 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1l9jLs-0000uS-0W; Wed, 10 Feb 2021 17:51:53 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Wed, 10 Feb 2021 17:51:51 +1100 Date: Wed, 10 Feb 2021 17:51:51 +1100 From: Herbert Xu To: Lee Jones Cc: linux-kernel@vger.kernel.org, Alexandre Belloni , Andreas Westin , Atul Gupta , Aymen Sghaier , Ayush Sawal , Benjamin Herrenschmidt , Berne Hebark , Breno =?iso-8859-1?Q?Leit=E3o?= , Daniele Alessandrelli , "David S. Miller" , Declan Murphy , "Gustavo A. R. Silva" , Harsh Jain , Henrique Cerri , Horia =?utf-8?Q?Geant=C4=83?= , Jitendra Lulla , Joakim Bech , Jonas Linde , Jonathan Cameron , Kent Yoder , linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ludovic Desroches , Manoj Malviya , Michael Ellerman , M R Gowda , Nayna Jain , Nicolas Ferre , Niklas Hernaeus , Paul Mackerras , Paulo Flabiano Smorigo , Rob Rice , Rohit Maheshwari , Shujuan Chen , Takashi Iwai , Tudor Ambarus , Vinay Kumar Yadav , Zaibo Xu Subject: Re: [PATCH 00/20] Rid W=1 warnings in Crypto Message-ID: <20210210065151.GA15914@gondor.apana.org.au> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Feb 04, 2021 at 11:09:40AM +0000, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > This is set 1 of 2 sets required to fully clean Crypto. > > Lee Jones (20): > crypto: hisilicon: sec_drv: Supply missing description for > 'sec_queue_empty()'s 'queue' param > crypto: bcm: util: Repair a couple of documentation formatting issues > crypto: chelsio: chcr_core: File headers are not good candidates for > kernel-doc > crypto: ux500: hash: hash_core: Fix worthy kernel-doc headers and > remove others > crypto: bcm: spu: Fix formatting and misspelling issues > crypto: keembay: ocs-hcu: Fix incorrectly named functions/structs > crypto: bcm: spu2: Fix a whole host of kernel-doc misdemeanours > crypto: ux500: cryp: Demote some conformant non-kernel headers fix > another > crypto: ux500: cryp_irq: File headers are not good kernel-doc > candidates > crypto: chelsio: chcr_algo: Fix a couple of kernel-doc issues caused > by doc-rot > crypto: ux500: cryp_core: Fix formatting issue and add description for > 'session_id' > crypto: atmel-ecc: Struct headers need to start with keyword 'struct' > crypto: bcm: cipher: Provide description for 'req' and fix formatting > issues > crypto: caam: caampkc: Provide the name of the function > crypto: caam: caamalg_qi2: Supply a couple of 'fallback' related > descriptions > crypto: vmx: Source headers are not good kernel-doc candidates > crypto: nx: nx-aes-cbc: Headers comments should not be kernel-doc > crypto: nx: nx_debugfs: Header comments should not be kernel-doc > crypto: nx: Demote header comment and add description for 'nbytes' > crypto: cavium: nitrox_isr: Demote non-compliant kernel-doc headers Thanks for doing this. But please don't split the patches at the file level. Instead split them at the driver level. For example, all of your bcm changes should be one patch. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt