Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1140395pxb; Wed, 10 Feb 2021 00:40:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJxj5bYm7PSw1neYv4X+f4zRxgh9QtYpv4k44ao84Xds4SZnwo007ZoyuPR/pYcPstLcpjdS X-Received: by 2002:a17:906:a2c9:: with SMTP id by9mr1895048ejb.546.1612946440380; Wed, 10 Feb 2021 00:40:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612946440; cv=none; d=google.com; s=arc-20160816; b=iUg1/uGVMS0Ydi5bTgmaqBcFw4haSTmJrAZUVlPOVYXZc8AsjSJn5O8T9P2A84d/2S sa6lOW774zJtC8OQOLYt5MdVwi4hPaaDusNhXlHa5qCz4QPf6zG+mDo+YarD2Flwc+Ge xfNrMB9GWpzwmJIZgv3kkfzWfk+OiBj650eafUsFH6XOOSruQQ8ZX3E1/W1rLRbqRw5b dDofNUo17TrcD4V/mSymspo4c1tZCjbow/r1bvEe6UVrFk9nJ7Egm63dYPKcTXozw5Jp K04gP7VnZfwNgbXC1GLhnXfAkh2oYWbR5fAwphYEfrjHsXubDa6NGevsUkBEusXmp1E5 lI8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=0s8juaWP8OgfjO3xb7ougizMUdhCW5FRMglSaRh3arc=; b=ryua7DbbfkmY0SpZ026ErURkFH0FmZd5g7yLVtapb9Hi91o+yMJNZCrc321GPKgXPK CcZw+v9PX78CfGXakzk7ZGCMvnLhMRgtUxTHgPie4iw9R+/rIEmEOYNwMFXVtOnRlvTL Z6FCkncIExTZA2RoCCA7ZamYgW1ivYrwKX708gSDMTfsSrHl9NWL6Qama2uB84EBax+C peUm9PyNxGZoRFvR16N//bKewPI/0p5T4TkxHb2uDOS8jRiwfZmlq25S1H/w/p0B84Mf rG++mcc+2w7Mhr3kRcCoMWiw0NgA+DMuoSoq6ytfXFZ8x/oWoc6q+meCpwRlTDPx2SWQ romA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i17si837222ejg.646.2021.02.10.00.40.16; Wed, 10 Feb 2021 00:40:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232537AbhBJHiE (ORCPT + 99 others); Wed, 10 Feb 2021 02:38:04 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:12904 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232478AbhBJHiD (ORCPT ); Wed, 10 Feb 2021 02:38:03 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DbBQ26cQCzjKgL for ; Wed, 10 Feb 2021 15:35:54 +0800 (CST) Received: from localhost.localdomain (10.175.102.38) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.498.0; Wed, 10 Feb 2021 15:36:54 +0800 From: Wei Yongjun To: Hulk Robot , Daniele Alessandrelli , Mike Healy , Herbert Xu CC: Wei Yongjun , Subject: [PATCH -next] crypto: keembay-ocs-aes - Fix error return code in kmb_ocs_aes_probe() Date: Wed, 10 Feb 2021 07:45:27 +0000 Message-ID: <20210210074527.867400-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Originating-IP: [10.175.102.38] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fix to return negative error code -ENOMEM from the error handling case instead of 0, as done elsewhere in this function. Fixes: 885743324513 ("crypto: keembay - Add support for Keem Bay OCS AES/SM4") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/crypto/keembay/keembay-ocs-aes-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/keembay/keembay-ocs-aes-core.c b/drivers/crypto/keembay/keembay-ocs-aes-core.c index b6b25d994af3..2ef312866338 100644 --- a/drivers/crypto/keembay/keembay-ocs-aes-core.c +++ b/drivers/crypto/keembay/keembay-ocs-aes-core.c @@ -1649,8 +1649,10 @@ static int kmb_ocs_aes_probe(struct platform_device *pdev) /* Initialize crypto engine */ aes_dev->engine = crypto_engine_alloc_init(dev, true); - if (!aes_dev->engine) + if (!aes_dev->engine) { + rc = -ENOMEM; goto list_del; + } rc = crypto_engine_start(aes_dev->engine); if (rc) {