Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [PATCH v3 1/2] dt-bindings: rng: bcm2835: document reset support
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <1614108850.556529.4116106.nullmailer@robh.at.kernel.org>
Date:   Tue, 23 Feb 2021 21:48:32 +0100
Cc:     Guenter Roeck <linux@roeck-us.net>,
        linux-rpi-kernel@lists.infradead.org,
        Matt Mackall <mpm@selenic.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        =?utf-8?B?Ik7DrWNvbGFzIEYuIFIuIEEuIFByYWRvIg==?= 
        <nfraprado@protonmail.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-crypto@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com,
        Philipp Zabel <p.zabel@pengutronix.de>,
        linux-kernel@vger.kernel.org,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Rikard Falkeborn <rikard.falkeborn@gmail.com>,
        Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
        linux-arm-kernel@lists.infradead.org,
        Scott Branden <sbranden@broadcom.com>,
        Mark Brown <broonie@kernel.org>, Ray Jui <rjui@broadcom.com>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        Stefan Wahren <stefan.wahren@i2se.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <D1C5E1F2-42EC-4716-9740-1DDA8DE6CE8D@gmail.com>
References: <20210222194510.14004-1-noltari@gmail.com>
 <20210223170006.29558-1-noltari@gmail.com>
 <20210223170006.29558-2-noltari@gmail.com>
 <1614108850.556529.4116106.nullmailer@robh.at.kernel.org>
To:     Rob Herring <robh@kernel.org>
Precedence: bulk

Hi Rob,

> El 23 feb 2021, a las 20:34, Rob Herring <robh@kernel.org> escribi=C3=B3=
:
>=20
> On Tue, 23 Feb 2021 18:00:05 +0100, =C3=81lvaro Fern=C3=A1ndez Rojas =
wrote:
>> Some devices may need to perform a reset before using the RNG, such =
as the
>> BCM6368.
>>=20
>> Signed-off-by: =C3=81lvaro Fern=C3=A1ndez Rojas <noltari@gmail.com>
>> ---
>> v3: make resets required if brcm,bcm6368-rng.
>> v2: document reset support.
>>=20
>> .../devicetree/bindings/rng/brcm,bcm2835.yaml   | 17 =
+++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>=20
>=20
> My bot found errors running 'make dt_binding_check' on your patch:
>=20
> yamllint warnings/errors:
>=20
> dtschema/dtc warnings/errors:
> =
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rng/b=
rcm,bcm2835.example.dt.yaml: rng@10004180: 'resets' does not match any =
of the regexes: 'pinctrl-[0-9]+'
> 	=46rom schema: =
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rng/b=
rcm,bcm2835.yaml

I don=E2=80=99t get what=E2=80=99s wrong here...

>=20
> See https://patchwork.ozlabs.org/patch/1443582
>=20
> This check can fail if there are any dependencies. The base for a =
patch
> series is generally the most recent rc1.
>=20
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up =
to
> date:
>=20
> pip3 install dtschema --upgrade
>=20
> Please check and re-submit.
>=20

Best regards,
=C3=81lvaro.=