Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2944856pxb; Sun, 28 Feb 2021 19:30:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJxT6tipzmLxCLaxst6heoQAeJrxN6Hz52QS2DL0h7txLFgGr2C/v7WELobQ53NEgBt4GX6U X-Received: by 2002:a17:906:115a:: with SMTP id i26mr14543923eja.10.1614569451739; Sun, 28 Feb 2021 19:30:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614569451; cv=none; d=google.com; s=arc-20160816; b=BXrL54gT6zowM0EY3bsHDLQZnxnSFyixV9Z1j3vXYKryYOFz0aWcDZBQL2Q06a8dHr AlJAGcE7tIJ8tX7Rl7N2Fbe1IwuS8EKwMGEmFVcx7kuyhJgXEKOFBaVWldOl55Bvpzq9 DBo51SfSJ17pe4wjmlNCNTP9/X2o3faE1TP1WbUIczPnAaC82j2HlGg7DL0SyJ7EHq/X 6uNB8gTTZhLIUkFs0jc3+pDTcOf+kNx/LCz1/T0t8Pcb8RGSR9hEiSQkLajkUAb+F0iI lTGdE4i3H/9FbCCuvzy8/POKUHusUA8FomLMhEFtElptA5BxqqyOwxF4Y/K8y3v3enoM nGpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=7rEg8fRvgBs5jOCAoIcuYGVb+VamVLGnXJEOldhDEkU=; b=v6o2ZFHcIyWuJeuuwnW0kzNxxCZLpDIEi1HbdkCws5LoxBancO8lGHCsH/yC1Y4JHa Snp2EE6ZKig79+r6ZHPXnKjsBeP42jIa7y+Y1f09X4ERI6aefTTD0ypIfeEz80E3TaCZ +4BDu9a97tGQNy7Q2f0RW3Jawwhn/f1+VsLsx7oQ3dzdoe9gS5yc0M8126bS7BH1PgU6 QSyink1q4oB/cC5szVYJtEI7vxBzW8KKzyvsYlTl2L7uUBfWTIQKHyfsBrLjdDJVRe8c nh0ZCzZFxHl2rhu5w2MDu5VDSt1ekvfRQnGTkgOUvvGfcCZ6Hzq6KaEwUS+YJPvk9Mlb Km2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g11si11843517ejt.597.2021.02.28.19.30.18; Sun, 28 Feb 2021 19:30:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231756AbhCACnq (ORCPT + 99 others); Sun, 28 Feb 2021 21:43:46 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:13011 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231835AbhCACnp (ORCPT ); Sun, 28 Feb 2021 21:43:45 -0500 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DpkzP2DpTzjTZb; Mon, 1 Mar 2021 10:41:21 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Mon, 1 Mar 2021 10:42:58 +0800 From: Tian Tao To: , , CC: Subject: [PATCH] hwrng: cctrng - Use device-managed registration API Date: Mon, 1 Mar 2021 10:43:48 +0800 Message-ID: <1614566628-52886-1-git-send-email-tiantao6@hisilicon.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Use devm_hwrng_register to get rid of manual unregistration. Signed-off-by: Tian Tao --- drivers/char/hw_random/cctrng.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/char/hw_random/cctrng.c b/drivers/char/hw_random/cctrng.c index 7a293f2..0efb37a 100644 --- a/drivers/char/hw_random/cctrng.c +++ b/drivers/char/hw_random/cctrng.c @@ -585,7 +585,7 @@ static int cctrng_probe(struct platform_device *pdev) atomic_set(&drvdata->pending_hw, 1); /* registration of the hwrng device */ - rc = hwrng_register(&drvdata->rng); + rc = devm_hwrng_register(dev, &drvdata->rng); if (rc) { dev_err(dev, "Could not register hwrng device.\n"); goto post_pm_err; @@ -618,8 +618,6 @@ static int cctrng_remove(struct platform_device *pdev) dev_dbg(dev, "Releasing cctrng resources...\n"); - hwrng_unregister(&drvdata->rng); - cc_trng_pm_fini(drvdata); cc_trng_clk_fini(drvdata); -- 2.7.4