Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Mar 2021 09:39:27 -0800
From:   Eric Biggers <ebiggers@kernel.org>
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
        syzbot+12cf5fbfdeba210a89dd@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] crypto: api - check for ERR pointers in
 crypto_destroy_tfm()
Message-ID: <YD54T+WRkGIrpuTM@sol.localdomain>
References: <20210302075530.29315-1-ardb@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210302075530.29315-1-ardb@kernel.org>
Precedence: bulk

On Tue, Mar 02, 2021 at 08:55:30AM +0100, Ard Biesheuvel wrote:
> diff --git a/include/crypto/hash.h b/include/crypto/hash.h
> index 13f8a6a54ca8..f065dbe2205c 100644
> --- a/include/crypto/hash.h
> +++ b/include/crypto/hash.h
> @@ -281,6 +281,8 @@ static inline struct crypto_tfm *crypto_ahash_tfm(struct crypto_ahash *tfm)
>  /**
>   * crypto_free_ahash() - zeroize and free the ahash handle
>   * @tfm: cipher handle to be freed
> + *
> + * If @tfm is a NULL or error pointer, this function does nothing.
>   */
>  static inline void crypto_free_ahash(struct crypto_ahash *tfm)
>  {

You missed crypto_free_shash().

Otherwise this looks good, feel free to add:

Reviewed-by: Eric Biggers <ebiggers@google.com>

- Eric