Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [PATCH v4 2/2] hwrng: bcm2835: add reset support
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <cb7e29012e15ff10916374f911c74430fc3f5b32.camel@pengutronix.de>
Date:   Wed, 3 Mar 2021 15:06:48 +0100
Cc:     Matt Mackall <mpm@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Rob Herring <robh+dt@kernel.org>,
        Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com,
        Mark Brown <broonie@kernel.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        =?utf-8?B?Ik7DrWNvbGFzIEYuIFIuIEEuIFByYWRvIg==?= 
        <nfraprado@protonmail.com>,
        Rikard Falkeborn <rikard.falkeborn@gmail.com>,
        Stefan Wahren <stefan.wahren@i2se.com>,
        linux-crypto@vger.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <7B6F49A9-A31D-4126-8CB1-11EE3B2B7950@gmail.com>
References: <20210223160131.29053-1-noltari@gmail.com>
 <20210224082230.29015-1-noltari@gmail.com>
 <20210224082230.29015-3-noltari@gmail.com>
 <cb7e29012e15ff10916374f911c74430fc3f5b32.camel@pengutronix.de>
To:     Philipp Zabel <p.zabel@pengutronix.de>
Precedence: bulk

Hi Philipp,

> El 3 mar 2021, a las 14:52, Philipp Zabel <p.zabel@pengutronix.de> =
escribi=C3=B3:
>=20
> Hi =C3=81lvaro,
>=20
> On Wed, 2021-02-24 at 09:22 +0100, =C3=81lvaro Fern=C3=A1ndez Rojas =
wrote:
> [...]
>> @@ -115,6 +121,8 @@ static void bcm2835_rng_cleanup(struct hwrng =
*rng)
>> 	/* disable rng hardware */
>> 	rng_writel(priv, 0, RNG_CTRL);
>>=20
>> +	reset_control_rearm(priv->reset);
>> +
>> 	if (!IS_ERR(priv->clk))
>> 		clk_disable_unprepare(priv->clk);
>> }
>> @@ -159,6 +167,10 @@ static int bcm2835_rng_probe(struct =
platform_device *pdev)
>> 	if (PTR_ERR(priv->clk) =3D=3D -EPROBE_DEFER)
>> 		return -EPROBE_DEFER;
>>=20
>> +	priv->reset =3D devm_reset_control_get_optional_exclusive(dev, =
NULL);
>> +	if (IS_ERR(priv->reset))
>> +		return PTR_ERR(priv->reset);
>> +
>> 	priv->rng.name =3D pdev->name;
>> 	priv->rng.init =3D bcm2835_rng_init;
>> 	priv->rng.read =3D bcm2835_rng_read;
>=20
> That doesn't seem right. reset_control_rearm() doesn't do anything if
> the reset control is exclusive. Either the reset control should be
> requested as shared, or the _rearm should be removed.

In only added reset_control_rearm() because Florian requested it=E2=80=A6
I think it=E2=80=99s not needed, so we can use v3, since it was the only =
change between v3 and v4...

>=20
> regards
> Philipp

Best regards,
=C3=81lvaro.=