Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [PATCH v3 1/2] dt-bindings: rng: bcm2835: document reset support
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <d6e5b3be7e2add03b8d00a931b7fe254cd39077e.camel@suse.de>
Date:   Thu, 4 Mar 2021 13:18:22 +0100
Cc:     Matt Mackall <mpm@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Rob Herring <robh+dt@kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Mark Brown <broonie@kernel.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        =?utf-8?B?Ik7DrWNvbGFzIEYuIFIuIEEuIFByYWRvIg==?= 
        <nfraprado@protonmail.com>,
        Rikard Falkeborn <rikard.falkeborn@gmail.com>,
        Stefan Wahren <stefan.wahren@i2se.com>,
        linux-crypto@vger.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <419CC9A9-1C14-4D44-8305-3F7DFF656C1F@gmail.com>
References: <20210222194510.14004-1-noltari@gmail.com>
 <20210223170006.29558-1-noltari@gmail.com>
 <20210223170006.29558-2-noltari@gmail.com>
 <d6e5b3be7e2add03b8d00a931b7fe254cd39077e.camel@suse.de>
To:     Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Precedence: bulk


> El 4 mar 2021, a las 13:07, Nicolas Saenz Julienne =
<nsaenzjulienne@suse.de> escribi=C3=B3:
>=20
> Hi Alvaro,
>=20
> On Tue, 2021-02-23 at 18:00 +0100, =C3=81lvaro Fern=C3=A1ndez Rojas =
wrote:
>> Some devices may need to perform a reset before using the RNG, such =
as the
>> BCM6368.
>>=20
>> Signed-off-by: =C3=81lvaro Fern=C3=A1ndez Rojas <noltari@gmail.com>
>> ---
>>  v3: make resets required if brcm,bcm6368-rng.
>>  v2: document reset support.
>>=20
>>  .../devicetree/bindings/rng/brcm,bcm2835.yaml   | 17 =
+++++++++++++++++
>>  1 file changed, 17 insertions(+)
>>=20
>> diff --git a/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml =
b/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml
>> index c147900f9041..11c23e1f6988 100644
>> --- a/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml
>> +++ b/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml
>> @@ -37,6 +37,21 @@ required:
>> =20
>>=20
>>  additionalProperties: false
>=20
> I can't claim I fully understand all the meta stuff in shemas, so I =
generally
> just follow the patterns already available out there.

Well, that makes two of us :).

> That said, shoudln't this be at the end, just before the examples?

I don=E2=80=99t know but I can move it there =C2=AF\_(=E3=83=84)_/=C2=AF

> Maybe the cause of that odd warning
> you got there?

Which odd warning?
I don=E2=80=99t get any warnings when running (or at least warnings =
related to rig, because I get warnings related to other yamls):
make dt_binding_check =
DT_SCHEMA_FILES=3DDocumentation/devicetree/bindings/rng/brcm,bcm2835.yaml

>=20
>> +if:
>> +  properties:
>> +    compatible:
>> +      enum:
>> +        - brcm,bcm6368-rng
>> +then:
>> +  properties:
>> +    resets:
>> +      maxItems: 1
>> +  required:
>> +    - resets
>=20
> I belive you can't really make a property required when the bindings =
for
> 'brcm,bcm6368-rng' were already defined. This will break the schema =
for those
> otherwise correct devicetrees.

Why not?
Wouldn=E2=80=99t just be required for brcm,bcm6368-rng?

Anyway, I can omit this, since it would be the same for clocks and those =
aren=E2=80=99t required either.

>=20
>> +else:
>> +  properties:
>> +    resets: false
>> +
>>  examples:
>>    - |
>>      rng@7e104000 {
>> @@ -58,4 +73,6 @@ examples:
>> =20
>>=20
>>          clocks =3D <&periph_clk 18>;
>>          clock-names =3D "ipsec";
>> +
>> +        resets =3D <&periph_rst 4>;
>>      };
>=20
> Regards,
> Nicolas

Best regards,
=C3=81lvaro.=