Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [PATCH] hwrng: bcm2835: set quality to 1000
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <b0cf1be0-4c7c-57ee-fea5-789fe215b85d@gmail.com>
Date:   Fri, 5 Mar 2021 07:26:29 +0100
Cc:     Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Andrew Lunn <andrew@lunn.ch>, Matt Mackall <mpm@selenic.com>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com,
        Rikard Falkeborn <rikard.falkeborn@gmail.com>,
        linux-crypto@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Stijn Tintel <stijn@linux-ipv6.be>, ynezz@true.cz
Content-Transfer-Encoding: quoted-printable
Message-Id: <6D1459DF-A7E1-422C-AA05-655156AEBA23@gmail.com>
References: <20210220174741.23665-1-noltari@gmail.com>
 <YDFeao/bOxvoXI9D@lunn.ch> <9b86c773-7153-1e18-472a-f66b01c83173@gmail.com>
 <20210303092019.GB8134@gondor.apana.org.au>
 <66AED5A4-3227-47CA-A4A2-B5AD6A571AAC@gmail.com>
 <c76c82668142710ba5a7a8454759c9aa2423d72f.camel@suse.de>
 <b0cf1be0-4c7c-57ee-fea5-789fe215b85d@gmail.com>
To:     Florian Fainelli <f.fainelli@gmail.com>
Precedence: bulk

Hi Florian,

> El 4 mar 2021, a las 23:28, Florian Fainelli <f.fainelli@gmail.com> =
escribi=C3=B3:
>=20
> On 3/4/21 7:11 AM, Nicolas Saenz Julienne wrote:
>> On Wed, 2021-03-03 at 10:29 +0100, =C3=81lvaro Fern=C3=A1ndez Rojas =
wrote:
>>> Hi Herbert,
>>>=20
>>>> El 3 mar 2021, a las 10:20, Herbert Xu =
<herbert@gondor.apana.org.au> escribi=C3=B3:
>>>>=20
>>>> On Sat, Feb 20, 2021 at 08:12:45PM +0100, =C3=81lvaro Fern=C3=A1ndez =
Rojas wrote:
>>>>>=20
>>>>> I ran rngtest and this is what I got:
>>>>=20
>>>> This is meaningless except for sources that have not been whitened.
>>>>=20
>>>> Your justification needs to be based on what the hardware does or
>>>> is documented to do.
>>>=20
>>> Ok, so I guess that we=E2=80=99re never setting that value to =
anything since there=E2=80=99s
>>> no public documentation about that =C2=AF\_(=E3=83=84)_/=C2=AF.
>>=20
>> @Florian, is there a way you might be able to get the official value?
>=20
> I will be looking into the documentation this weekend and let you know
> whether we can change the driver's quality accordingly.

Could you do that for iproc-rng200.c too?

> --=20
> Florian

Best regards,
=C3=81lvaro.=