Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp130814pxf; Wed, 10 Mar 2021 02:16:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJzEtgdF0eqGUghHK48m/gBdhN/QhDprRjRQ3aAv7+G1uhDKRyiTJcBxJlpu0PiGOK3GRNoi X-Received: by 2002:a17:906:d19b:: with SMTP id c27mr2813269ejz.304.1615371398876; Wed, 10 Mar 2021 02:16:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615371398; cv=none; d=google.com; s=arc-20160816; b=PXqImPKD9IrhpST9A89B/agnCal+sTeN0xMlpZeT90dUplVy55XHXywgW3bL86tPHM VbFKOnwzc7xs5xiqSxgdNy01FKPetPynksTCLq2AFfiqqfPfdEbJvCnS497Vdc6mXwEJ r6NHZiLQZy7RrlEas8hfUaiSXyQ6gk3zArt/5gGdNTRMWmK11uOAGIyprwP+sMNxxaVp YXcYUuu8iIrQyPSJQG2WaTTVmMuTs2MEn1hZFTJ3PY4ybARGxDLO5C6iES/DzWJSlDTu WVJiF6WmqTJHJEteA12t7GFkK1seANXxx/GQV3Jf9lPUUFJXkKaXdWmi09MyZe8vQQEP oAcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=r1oqaP53pihAuZHDpWJxm05WX9b8XQ8YS83fYHQru/0=; b=TcBHbh38oP569uOfmnkYpOJsNd9ScQFJD+U5SpzLZ4og3K0a/aUayUS1cgm4HprwEy tJ6EO126MXV36LgKLV1szJ4EpJ5rNC0aL1Dof/tIza0lWVmgmCkJqPsTRJ0l1HtFU4kF MDPZP/g4oZevZrkYkaEHIa0Kr2dXrqA5WY085BfcwfG4cbXpWRxXQad9VaEoFsVEkEKj x4qiRXDDuAv6R7rfGEc29FlIc4rQmZcEtes7fuDSHL4HCdxtqgSk3sbKjxDyg0hNVsOz k+4neV9DTl6R3BvbBohTlrJZiN8Mz6DlRvhyHrPqu8d7WMPnDEOrhUtk0RwVUOIAXJXO J0vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Oql+tZpc; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bx25si11860355edb.242.2021.03.10.02.16.16; Wed, 10 Mar 2021 02:16:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Oql+tZpc; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229609AbhCJKO7 (ORCPT + 99 others); Wed, 10 Mar 2021 05:14:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:39600 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232455AbhCJKOd (ORCPT ); Wed, 10 Mar 2021 05:14:33 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 31EF164FE1; Wed, 10 Mar 2021 10:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615371273; bh=AQOCCL6rIDn2boPRQjjrINvBOEJeoxQkH35pdSjfI2w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Oql+tZpcT0dTn+i57Sbfe5YQjExenoOqH5W0z9Vydsqr3o9DiyLGLXOJtmh/9DTSe Aok7IhJ750RXBuWjiKqBFELyEkkzW5RjGcvXplSykGo0QIdk18aYk6bixC5JZhJMlL sznX85930k/LSke1RSgtn/VIqz4vUsQKWExnGXOYzpuFsTraDRuk7wU3EgYeERC2Gy OxwBnJyXpD7OTWOJnpzFqlOBqL/hdzX+sEkKYL/YrnMvIb7BLmEv6M5Lp6tF9f17BY mvJB/bZZZxNL29bP0c09vqn1bBUZcY00WcSg23hfIk7d650NJCJlB/q5d3rnk9gpVw AXNFdgXRsq9+A== From: Ard Biesheuvel To: linux-crypto@vger.kernel.org Cc: herbert@gondor.apana.org.au, Ard Biesheuvel , Geert Uytterhoeven , Nicolas Pitre , Eric Biggers , Linus Walleij Subject: [PATCH v3 2/2] crypto: arm/chacha-scalar - switch to common rev_l macro Date: Wed, 10 Mar 2021 11:14:21 +0100 Message-Id: <20210310101421.173689-3-ardb@kernel.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210310101421.173689-1-ardb@kernel.org> References: <20210310101421.173689-1-ardb@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Drop the local definition of a byte swapping macro and use the common one instead. Signed-off-by: Ard Biesheuvel Reviewed-by: Nicolas Pitre Reviewed-by: Geert Uytterhoeven Reviewed-by: Linus Walleij Reviewed-by: Eric Biggers --- arch/arm/crypto/chacha-scalar-core.S | 43 ++++++-------------- 1 file changed, 13 insertions(+), 30 deletions(-) diff --git a/arch/arm/crypto/chacha-scalar-core.S b/arch/arm/crypto/chacha-scalar-core.S index 2985b80a45b5..083fe1ab96d0 100644 --- a/arch/arm/crypto/chacha-scalar-core.S +++ b/arch/arm/crypto/chacha-scalar-core.S @@ -41,32 +41,15 @@ X14 .req r12 X15 .req r14 -.macro __rev out, in, t0, t1, t2 -.if __LINUX_ARM_ARCH__ >= 6 - rev \out, \in -.else - lsl \t0, \in, #24 - and \t1, \in, #0xff00 - and \t2, \in, #0xff0000 - orr \out, \t0, \in, lsr #24 - orr \out, \out, \t1, lsl #8 - orr \out, \out, \t2, lsr #8 -.endif -.endm - -.macro _le32_bswap x, t0, t1, t2 +.macro _le32_bswap_4x a, b, c, d, tmp #ifdef __ARMEB__ - __rev \x, \x, \t0, \t1, \t2 + rev_l \a, \tmp + rev_l \b, \tmp + rev_l \c, \tmp + rev_l \d, \tmp #endif .endm -.macro _le32_bswap_4x a, b, c, d, t0, t1, t2 - _le32_bswap \a, \t0, \t1, \t2 - _le32_bswap \b, \t0, \t1, \t2 - _le32_bswap \c, \t0, \t1, \t2 - _le32_bswap \d, \t0, \t1, \t2 -.endm - .macro __ldrd a, b, src, offset #if __LINUX_ARM_ARCH__ >= 6 ldrd \a, \b, [\src, #\offset] @@ -200,7 +183,7 @@ add X1, X1, r9 add X2, X2, r10 add X3, X3, r11 - _le32_bswap_4x X0, X1, X2, X3, r8, r9, r10 + _le32_bswap_4x X0, X1, X2, X3, r8 ldmia r12!, {r8-r11} eor X0, X0, r8 eor X1, X1, r9 @@ -216,7 +199,7 @@ ldmia r12!, {X0-X3} add X6, r10, X6, ror #brot add X7, r11, X7, ror #brot - _le32_bswap_4x X4, X5, X6, X7, r8, r9, r10 + _le32_bswap_4x X4, X5, X6, X7, r8 eor X4, X4, X0 eor X5, X5, X1 eor X6, X6, X2 @@ -231,7 +214,7 @@ add r1, r1, r9 // x9 add r6, r6, r10 // x10 add r7, r7, r11 // x11 - _le32_bswap_4x r0, r1, r6, r7, r8, r9, r10 + _le32_bswap_4x r0, r1, r6, r7, r8 ldmia r12!, {r8-r11} eor r0, r0, r8 // x8 eor r1, r1, r9 // x9 @@ -245,7 +228,7 @@ add r3, r9, r3, ror #drot // x13 add r4, r10, r4, ror #drot // x14 add r5, r11, r5, ror #drot // x15 - _le32_bswap_4x r2, r3, r4, r5, r9, r10, r11 + _le32_bswap_4x r2, r3, r4, r5, r9 ldr r9, [sp, #72] // load LEN eor r2, r2, r0 // x12 eor r3, r3, r1 // x13 @@ -301,7 +284,7 @@ add X1, X1, r9 add X2, X2, r10 add X3, X3, r11 - _le32_bswap_4x X0, X1, X2, X3, r8, r9, r10 + _le32_bswap_4x X0, X1, X2, X3, r8 stmia r14!, {X0-X3} // Save keystream for x4-x7 @@ -311,7 +294,7 @@ add X5, r9, X5, ror #brot add X6, r10, X6, ror #brot add X7, r11, X7, ror #brot - _le32_bswap_4x X4, X5, X6, X7, r8, r9, r10 + _le32_bswap_4x X4, X5, X6, X7, r8 add r8, sp, #64 stmia r14!, {X4-X7} @@ -323,7 +306,7 @@ add r1, r1, r9 // x9 add r6, r6, r10 // x10 add r7, r7, r11 // x11 - _le32_bswap_4x r0, r1, r6, r7, r8, r9, r10 + _le32_bswap_4x r0, r1, r6, r7, r8 stmia r14!, {r0,r1,r6,r7} __ldrd r8, r9, sp, 144 __ldrd r10, r11, sp, 152 @@ -331,7 +314,7 @@ add r3, r9, r3, ror #drot // x13 add r4, r10, r4, ror #drot // x14 add r5, r11, r5, ror #drot // x15 - _le32_bswap_4x r2, r3, r4, r5, r9, r10, r11 + _le32_bswap_4x r2, r3, r4, r5, r9 stmia r14, {r2-r5} // Stack: ks0-ks15 unused0-unused7 x0-x15 OUT IN LEN -- 2.30.1