Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1387675pxf; Fri, 12 Mar 2021 08:23:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJzmu7y/QrhCVIxkKxoxj0a4sowXK4DKYi0RxLqSk/iPDaVGjlsnnOXDYzbZwfzMhF2a+CWR X-Received: by 2002:aa7:dbd3:: with SMTP id v19mr14912257edt.314.1615566230129; Fri, 12 Mar 2021 08:23:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615566230; cv=none; d=google.com; s=arc-20160816; b=bfqAPga8MzIwC2qXSJ0ULiUrWcGeKof9aF+0qsI39sd/q9U5jLdsHSNeTvepypGj8/ gDq0jiBMZmPyIJ5WdFwyTDuTIIct9hBuPD4z7kdPl64scu1P8LVO6x6wrfoH7DGXZpIo vdg59AsFa/UOdq2zO4x+OmrBG7bUdFeifKR76nOZJQl2yRyz9t2GdabfEoXkIWI/n6h4 nQXRNtI1Pkvyoqu0Fel/SdfrooXBot3EmS81CS+Q650InmJE/YDR0awJTecjC8BIGi5R IbrI/GAO7ugzYqyLVjxxfyZ2er+2EZYplkU5nGTD5V6BvUEYPnyjdwwozmSVDb2zSVzy xseA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=A2UZVq4RWM1EK4WKKShJf3qblovDef5sWEZC7pI0LcQ=; b=ftF+tDgVn+xwYSsYc/1YWzVfFABj/loPlk7ToU5SqnsxSGNRkBCf3Q/K53Rfs6W+E3 4YjR28hprLblGxESNvmPniooDpb1ZUPPioTwnHf7I5G9nh3Td+EbwB7OQWjaK0j0/C9X 9Jpjyjs7q36Gsi53u/LjSu9bgjCvXYGhviNJpJ1XJH3hTskmCd5iNCaFtBVImtnMCXk1 aY75pGt501iezpl0/ZiI9BHOmq4t3I9H5d7GZMJXxuPsHM+nAlu9CoW9K0DPIo6Egs04 MZD0GgJirZUBXT6srdG3Lrs2G3/IwdvVFaPaem6V0cCLNWS+E7msFjjhQU0NDl37Bys9 8TpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kdNrQCA0; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o22si4567910eje.560.2021.03.12.08.23.26; Fri, 12 Mar 2021 08:23:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kdNrQCA0; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231925AbhCLQWw (ORCPT + 99 others); Fri, 12 Mar 2021 11:22:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232130AbhCLQWZ (ORCPT ); Fri, 12 Mar 2021 11:22:25 -0500 Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97795C061574; Fri, 12 Mar 2021 08:22:25 -0800 (PST) Received: by mail-qv1-xf31.google.com with SMTP id by2so4493281qvb.11; Fri, 12 Mar 2021 08:22:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=A2UZVq4RWM1EK4WKKShJf3qblovDef5sWEZC7pI0LcQ=; b=kdNrQCA0SX7W8OuOXyJxWnj9EIQirUIR/ddyqiXJ4mtchy+yrtIZR/Kj+HSiciBUvh rHGxieqlfUL4Zg9lQ7qm1zeBtoz71elWwVkp1KLPUNKJX+WLfo4uTo6zYOpKY48htU4+ 4MdIcHbesAgRRadsWK2CK3p3zNJUhn+aqs4CYchGqDaNh30MSMVsFJG41XGKI4LRB9y+ KBuIgkM59FzI69cz/9BXGdafuHFyDBxo9Rc4//jPoJSpi5j/LXZPyX17xlD5nyoCG7Um khZY9ZOY2DXinI8+rStAvu4Hy1pCAHsRYlmF2tprlu9aLJQcSirPRtECkCmn1hd15uiT qHog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=A2UZVq4RWM1EK4WKKShJf3qblovDef5sWEZC7pI0LcQ=; b=MbCiF7US1ZUma+xuZy3aAihlqJEq1c4jWhEsgFLRGlk/j3mPaTxkyFBc8WkNM+qCcl UZ0JNWKX7Y7Y5r5rQcQKGXBRhOEmw+4n6SklBKLPXjcX79vvmAzpfphTEUdBdfSLxj1o UUhEmawHk1Abm1L/NcOP/rfEBWMiaLnnfKpTDoXvrkb4R+692ub4X4GJiw0eYFiLT8Ea 95HV35048Tu6AvEov6lSKvCmRKrFPwdlbmU7LTeiTeYIWBFIkWRw+tAspPXU7otM8Ovt CTNJpTI9gayZhre36uo0EdQgRwpKhGFvtNMIOJBRqX0u0mscnGlIZNLjHanIalFnA0Jk fefw== X-Gm-Message-State: AOAM532iTr5w6IMQjqbOzZ1mFZ44tgXxqiPZ8XWFy/ixgssE6wu3c1ms J9g9g4N8y1ZDCO9+oTmnnjc= X-Received: by 2002:ad4:4581:: with SMTP id x1mr13144164qvu.9.1615566144660; Fri, 12 Mar 2021 08:22:24 -0800 (PST) Received: from tong-desktop.local ([2601:5c0:c200:27c6:b9e0:c84:da81:d749]) by smtp.googlemail.com with ESMTPSA id e15sm4178623qti.79.2021.03.12.08.22.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 08:22:24 -0800 (PST) From: Tong Zhang To: Giovanni Cabiddu , Herbert Xu , "David S. Miller" , Andy Shevchenko , Wojciech Ziemba , Fiona Trahe , Tong Zhang , qat-linux@intel.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 0/2] crypto: qat: fix couple crashes duing error handling Date: Fri, 12 Mar 2021 11:22:01 -0500 Message-Id: <20210312162203.2416149-1-ztong0001@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org There are a couple of issues in qat error handling. Those drivers tries to release resources that is not initialized. This patch series tries to fix crashes caused by incorrect error handling. v2: removed excessive dump in commit log as suggested by Andy Shevchenko v3: collect tags as suggested by Andy Shevchenko Tong Zhang (2): crypto: qat - dont release uninitialized resources crypto: qat: ADF_STATUS_PF_RUNNING should be set after adf_dev_init drivers/crypto/qat/qat_c3xxxvf/adf_drv.c | 4 ++-- drivers/crypto/qat/qat_c62xvf/adf_drv.c | 4 ++-- drivers/crypto/qat/qat_common/adf_vf_isr.c | 17 +++++++++++++---- drivers/crypto/qat/qat_dh895xccvf/adf_drv.c | 4 ++-- 4 files changed, 19 insertions(+), 10 deletions(-) -- 2.25.1