Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp676570pxf; Thu, 18 Mar 2021 09:08:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1f+j71UUQ+4kbURZQ8WlZetahzDV691H+6tXWh0djfX6GeLl974z8R2pNJiZxFE2OgINp X-Received: by 2002:a17:906:3f87:: with SMTP id b7mr41615574ejj.139.1616083689960; Thu, 18 Mar 2021 09:08:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616083689; cv=none; d=google.com; s=arc-20160816; b=caffvx4s45arFapppoWHM9x3mN6Mz7L1QyDNtaMCXvGazhMDI5AcxroFHp1W1Wad9f ksDnSgk0l9ST428549+puOGzQptywrl3kDCP9+nTS6Stvs9fliIgMH+LfnjeMTQz12Eo EtuHroH8X3Pdhvy39+lbG16S6K8j6zQpAHEVZ/SQ9b5AQMEV5URDDv64L+CoMweFC/Ch z2yMPFJXi3XunFwxtD0IUH50bcFH/LOqfmF81Jo3bxhpEPl7KMP474iGOR7/d9Ouq+rP /lupIuYxl8QQB6v0hZXga++DI7zqJbiC0Q36GYG1vtrtqzmOm8ET+AYyqnjhHgQJIRm2 XUWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=BRnZv77JqRCKnUHMogMw0V6iKSdgtj6bwXjGQYC0D4w=; b=H5rXCK5UZ8+T/0hjx4mhYuYVN6l57ddg0AbTui51Ci61X6YVzsxeJOU2QUfOLw3SP5 330rf6ZPwHJi2uawoL0Y2pVK4aQxgQjLKWiOVdlng9iJ7fZyPD1kpzIH0L+o4w3K+K7G rIwtkKZOzu+xAo9YBssZU2F34b6el6ti1aEzXZtu2VYsndKTzWr2E/43/2l49ebXHMio LAM9gDbwheGz0bfuv4wQYwmDhjHdNFinOVji/tcgSVmKYE4Z0HFqDNXNq5M7POBPSXno GnvlWAXqy46lRFUUKS7Ys7+pggGCajnWXCyVZYKA2w+UZy61ymFUe6V3nuzfgtix6wv6 1mlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p20si1844978ejd.442.2021.03.18.09.07.45; Thu, 18 Mar 2021 09:08:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230425AbhCRQGw (ORCPT + 99 others); Thu, 18 Mar 2021 12:06:52 -0400 Received: from mga09.intel.com ([134.134.136.24]:46879 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230260AbhCRQGs (ORCPT ); Thu, 18 Mar 2021 12:06:48 -0400 IronPort-SDR: scMWyt5MBOuxNU831d0pZeu7S8XxwFEw9MZqrUc2uXIAvmes5whhF6Gl+MZ/JEsYvYWb8YhygW uqqvFlV0b2Vw== X-IronPort-AV: E=McAfee;i="6000,8403,9927"; a="189806617" X-IronPort-AV: E=Sophos;i="5.81,259,1610438400"; d="scan'208";a="189806617" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2021 09:06:37 -0700 IronPort-SDR: uLQTgUwqiXZMjBnMSdm38gP/D5GlyDgT17VBRbK8DuOkh15ZBSt8DaiYew9rpwQabpFnca2cbF BVCK8s0vaMbw== X-IronPort-AV: E=Sophos;i="5.81,259,1610438400"; d="scan'208";a="389294311" Received: from silpixa00400314.ir.intel.com (HELO silpixa00400314) ([10.237.222.51]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2021 09:06:33 -0700 Date: Thu, 18 Mar 2021 16:06:30 +0000 From: Giovanni Cabiddu To: Tong Zhang Cc: Herbert Xu , "David S. Miller" , Andy Shevchenko , Wojciech Ziemba , Fiona Trahe , qat-linux@intel.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] crypto: qat - dont release uninitialized resources Message-ID: References: <20210312162203.2416149-1-ztong0001@gmail.com> <20210312162203.2416149-2-ztong0001@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 - Collinstown Industrial Park, Leixlip, County Kildare - Ireland Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Mar 18, 2021 at 03:53:03PM +0000, Giovanni Cabiddu wrote: > On Fri, Mar 12, 2021 at 11:22:02AM -0500, Tong Zhang wrote: > > adf_vf_isr_resource_alloc() is not unwinding correctly when error > > happens and it trys to release uninitialized resources. ^^^^ Typo: perhaps 'tries'? Regards, -- Giovanni