Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp690314pxf; Thu, 18 Mar 2021 09:22:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzIK5gPfc8r01+51VTEbKAB2YbQLwaYtEYKZ6Bv7Ts6tvcXO8c6ytwF+33WhCu1/TUIRf0a X-Received: by 2002:a05:6402:2d0:: with SMTP id b16mr4731687edx.194.1616084576999; Thu, 18 Mar 2021 09:22:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616084576; cv=none; d=google.com; s=arc-20160816; b=a5raC/v4boCwCgS5SuFCOo6vpwJuH7uy7RpxqokjaA9iRPjx59xdx9teG5z1o9ZnNq jnFndWaK1w4CxbIWA8McuRKxpdHVauMPbg2P6iDiN67PsANMCO9o3ptbUHIxYSxjXS87 pI139Z0EHfMyVTNrI20jDpiPnT8lOSA4Xk2DejlkCwaXi00A/DXRQTUb1+wbfr4wkGe3 mal7D7L6HGZi+rqn/yCulXuNWj0pTNnttJkbdbXzIYiGaZpb3cbg03WeghD1zUC0+6Vn yYQ7oJCKyuFSbIUUnSt47p6j/We4atuzhK6xxv7e3iqLULgjkAEe+HKsGwPGx5O6MZTW GOjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=7VgRXV2jiSQknwo24vXmP8SBaCgfC+hQjO+51l0g2/k=; b=d+bhjRLxjbF78dTZUo/leuuK/0zNqXZ7WZXgn2Au2td/DYe52DyePoRoErja2bfGAI OKAQU6Cbay5khR9YzoD64PFR2FnYlJclo8PDojwqIy/mb2jbhu35gQlRaCUMk4z7ZQeH 4uYRJ8fvYIyYqJ2CnaulHyHC5vM+K1z7FY5CBoBc9EvOxYBAi9tmeldOqtklb507yR9p GsF3ZXM17FhQ/gt8ZI1bjeJDcdS2JNRMdffinFtStljR2Vnuphe/n5DyXF8HHwJtArlH HR1G9nv41x6as0KwFFHFedyyVFeBdLMc7cdmjDYt+LBDQ4HJ86siC92cnWdy6XEFvPam V6WQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bJBC+Juo; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a7si2215733edb.607.2021.03.18.09.22.29; Thu, 18 Mar 2021 09:22:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bJBC+Juo; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232114AbhCRQV5 (ORCPT + 99 others); Thu, 18 Mar 2021 12:21:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231129AbhCRQVq (ORCPT ); Thu, 18 Mar 2021 12:21:46 -0400 Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8BECC06174A; Thu, 18 Mar 2021 09:21:45 -0700 (PDT) Received: by mail-qt1-x82b.google.com with SMTP id f12so4505652qtq.4; Thu, 18 Mar 2021 09:21:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=7VgRXV2jiSQknwo24vXmP8SBaCgfC+hQjO+51l0g2/k=; b=bJBC+JuohpQjJ+K8y5G7q9pE3ICUnO3iOh5uuiz+UFBgu2FWPQE67qbC1UbBkd6kiM TYN4xt0MTMKllMcDX7jgCjAgfJSsNzo3IfRfe3Q1wtKFIVZSoQF1NZHa3PlqcbYgRRsW SLYr5Ustul95K9g6M8PU1UixV4JBbOSM1ZqoDFChY3PEjmwae/qDnPNWR9yVd3/z+uus yhzQz3lhc5hHxijFdgBWllAAy9jnjMxQs1Og5d+L8lS/Q192LfTXotY0wgmcFQyAqCwq kHnTGCpFAWLFfYbmwsn8XhZEjYndJ1FRoYn+PP60blNwfU9INFwE2u0jlqFonE5nGZND c/Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7VgRXV2jiSQknwo24vXmP8SBaCgfC+hQjO+51l0g2/k=; b=hk5OUFqBaIUZVAuVPJZDNNK5jOGApqpmuzCgM+twwvP+gJ1gnbYLzd+3BVy+6HrCag rX0QKlGfidIPXc4GXLxr2qwgJ2oDxZ9heyouwg2HJr2woXlYVweRaFx+xr2doxbXonYQ fCyyPS2+1hrbLJlffwhkqhxFlpes+ShAO/Ysqss7Pk3QnspvNw9fCCXordFPIXjomfUF JH7TLsHbzsL2Haq1ukLt3r7ECGnEDpdMOwSNfdZHdrM3oBQC+xVv6iXAor4vAyPUd1e9 0JYosz65ObGvR09qAFeCJIztqXIjCUjfUmUo4H788nQH1B6SUqkeFAjzOAzVhWD4u60j 4O8w== X-Gm-Message-State: AOAM531uIdG5QN2xEkWAmXOEu5piqI+K43pkjTWdUM8ds4OFEoAOQK3e aWzagGEJ0EBYHqayMBwX6dM= X-Received: by 2002:ac8:5510:: with SMTP id j16mr4423751qtq.339.1616084505202; Thu, 18 Mar 2021 09:21:45 -0700 (PDT) Received: from tong-desktop.local ([2601:5c0:c200:27c6:d4e9:423a:4aca:b208]) by smtp.googlemail.com with ESMTPSA id d14sm2230722qkg.33.2021.03.18.09.21.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 09:21:44 -0700 (PDT) From: Tong Zhang To: Giovanni Cabiddu , Herbert Xu , "David S. Miller" , Andy Shevchenko , Tong Zhang , Fiona Trahe , Tadeusz Struk , qat-linux@intel.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Wojciech Ziemba Subject: [PATCH v4 0/2] crypto: qat: fix couple crashes duing error handling Date: Thu, 18 Mar 2021 12:21:03 -0400 Message-Id: <20210318162105.378239-1-ztong0001@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org There are a couple of issues in qat error handling. Those drivers tries to release resources that is not initialized. This patch series tries to fix crashes caused by incorrect error handling. v2: removed excessive dump in commit log as suggested by Andy Shevchenko v3: collect tags as suggested by Andy Shevchenko v4: fix commit log typos Tong Zhang (2): crypto: qat - dont release uninitialized resources crypto: qat: ADF_STATUS_PF_RUNNING should be set after adf_dev_init drivers/crypto/qat/qat_c3xxxvf/adf_drv.c | 4 ++-- drivers/crypto/qat/qat_c62xvf/adf_drv.c | 4 ++-- drivers/crypto/qat/qat_common/adf_vf_isr.c | 17 +++++++++++++---- drivers/crypto/qat/qat_dh895xccvf/adf_drv.c | 4 ++-- 4 files changed, 19 insertions(+), 10 deletions(-) -- 2.25.1