Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp925530pxf; Thu, 25 Mar 2021 18:18:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmw8ncY0mwc6wCwcF2d9y6XfbqOBUy5qDmm5y13HzbAuz2dAec9xAJQKnZeDFoO8k+4CKy X-Received: by 2002:a17:906:2bc3:: with SMTP id n3mr12726391ejg.418.1616721532200; Thu, 25 Mar 2021 18:18:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616721532; cv=none; d=google.com; s=arc-20160816; b=w/0rbqG0DyiWjJiDLWDOd5TR9QdR4AZ+jtVzwuPxCAiUkJJB6tBCSFAO1ILIfoaLf3 3Hk/IC1aexH/BjNYIbaygXuz6ylIOnK6hHctRBeLtN+rnV+JUzx9fe/iZmOZBEhAAoPH x6/zC1yOqTJQQGWyTBze73RuAt5Ckt9KIQOH7DDa9J7qfUc8GoDVpsj6rdZr9Cv3BLCn 6rzhXnbon0jKLQST5wd6rubBhxc9ABn1nVzSJahZJ1riF0o6EnQVSU9e0vFNriCS1PKh rLIKIAQHWmcDnc9U+4YDtKZljTJ/BP0BNI5jHPFvRvp1v+bRByh0YwarSu/r6K/omlkf eL6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=MGjwqEaEvHX8sEUhohbNW2Nn7K5x77bXlKUdyYV9avY=; b=GWvGuzg2AnzY3gVzdyUsN+9QMG97qR4oMMvm6IOLT6PYRC3SL/XNLsF/I4NEdXwDBm gI9ddJWVk/GpMxuh13CPcZGx5/rhobEKx7C0oYLH4fyIMTt76KnuB7axrf0cRHIm0JO7 N3h4IETjjZtjT2Wd3gFxA9vFYDI4QvhggrRtGjdE293HyrSb6Hbmr9q58TJeUeb40y/3 I18M97iOG9qYdN2YLCcYM6CWMl73n1zFF+h5QPmR8aXBQpleZpiX6bzCH95PCZUpbT1v 1GwNR092AouVxQftojfjN4g7zlRJrZPsJ4QOVswm3Im2dZk95f6ODvGzrFSoTnQqxcSn 09ZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kk8si5522145ejc.404.2021.03.25.18.18.16; Thu, 25 Mar 2021 18:18:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229993AbhCZBRe (ORCPT + 99 others); Thu, 25 Mar 2021 21:17:34 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:14138 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229972AbhCZBRJ (ORCPT ); Thu, 25 Mar 2021 21:17:09 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4F63sg6Gs5znWW6; Fri, 26 Mar 2021 09:14:31 +0800 (CST) Received: from huawei.com (10.67.165.24) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.498.0; Fri, 26 Mar 2021 09:16:58 +0800 From: Kai Ye To: CC: , , , Subject: [PATCH] crypto: hisilicon/qm - delete redundant code Date: Fri, 26 Mar 2021 09:14:32 +0800 Message-ID: <1616721272-47909-1-git-send-email-yekai13@huawei.com> X-Mailer: git-send-email 2.8.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org The memory not needed to clear that will be freed. and the memset is useless after the dma is freed. Signed-off-by: Kai Ye --- drivers/crypto/hisilicon/qm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c index 13cb421..88a6c6f 100644 --- a/drivers/crypto/hisilicon/qm.c +++ b/drivers/crypto/hisilicon/qm.c @@ -2527,7 +2527,6 @@ void hisi_qm_uninit(struct hisi_qm *qm) hisi_qm_cache_wb(qm); dma_free_coherent(dev, qm->qdma.size, qm->qdma.va, qm->qdma.dma); - memset(&qm->qdma, 0, sizeof(qm->qdma)); } qm_irq_unregister(qm); -- 2.8.1