Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp928456pxf; Thu, 25 Mar 2021 18:24:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOrZtlc1BN8yiIu8t/h+DIl/FhnLX3sUJ9Ky0i93DAOTjgS/xqZSKX4bXs7mMDZcOHDm8w X-Received: by 2002:aa7:c916:: with SMTP id b22mr12386221edt.299.1616721866598; Thu, 25 Mar 2021 18:24:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616721866; cv=none; d=google.com; s=arc-20160816; b=qzvoFeYMG7+td7i67tPUf5WEmIJH70AUPYhT/UHRT3ODb3/v5uYgK94Mj/hIiV4qO8 fc+HcSuncylpM0nbGRhapfYbZRV8rJhkQBOtoxxuEpiHy1lCwn6DTsZMVA2o/TRl4pf6 kuLGg3Mifooa2Okb94mfe61loowXlZvhUjuZ1yLo/fzuPr7IMs6snYOa7pyQiG2w/87v B0aPHVUTbS//SazY6yi6CF0e+ieiGY4o/bihbPLoF39nHxs4qLvKFSjYUhHZW5+cmTX9 TF0z6tH54cNx2mHYfRO3LF6jS9gxt5N/WvXA/KdyrOoaaqWbOCliWSXWvV91YDUGA5DW dfUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=EDS3Nh/l8bWWVR/09LRKk2Q8hdo/EAtilbw2KxgmJW4=; b=jdlWl3ax0dsvNZR+fhcmwS16EsKNTEqmeSjJ3pS8NfmgXFoVM1aV3RhBhxZMklOuPl vwvoO2XYQiPR3AiAFJr0WdsvXsPytrvo9d1M2o7YUVYhbAw/1MCdnjZiR8d9RTy1sEhR VAtDCs8u4EZGHfC/o5IIeuh+Ri6RnskfiPXqFZNCRdquunHdX24rcZO+/0UnhmJwDJow abdf7C9oGQIrGgDz+t2Y577lmxNNK1lV+qoY0EW38F1hma678kN1893Mk5kwh/U43ZsH jnJ7ndkjtgWkUzf2H/StyOO90Il7XB8e6qJKPO4B/TzH5KvLIZHGHZnQanhQXcNbwh23 Y5Cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p10si5350326ejg.131.2021.03.25.18.24.03; Thu, 25 Mar 2021 18:24:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230018AbhCZBXb (ORCPT + 99 others); Thu, 25 Mar 2021 21:23:31 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:14547 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230013AbhCZBX0 (ORCPT ); Thu, 25 Mar 2021 21:23:26 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4F640z2lCYzPm6m; Fri, 26 Mar 2021 09:20:51 +0800 (CST) Received: from huawei.com (10.67.165.24) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Fri, 26 Mar 2021 09:23:16 +0800 From: Kai Ye To: CC: , , , Subject: [PATCH 2/3] crypto: qce - use memzero_explicit() for clearing data Date: Fri, 26 Mar 2021 09:20:47 +0800 Message-ID: <1616721648-56258-3-git-send-email-yekai13@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1616721648-56258-1-git-send-email-yekai13@huawei.com> References: <1616721648-56258-1-git-send-email-yekai13@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org use memzero_explicit instead of memset to clear sensitive data. Signed-off-by: Kai Ye --- drivers/crypto/qce/sha.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/qce/sha.c b/drivers/crypto/qce/sha.c index 61c418c..cb9b3da 100644 --- a/drivers/crypto/qce/sha.c +++ b/drivers/crypto/qce/sha.c @@ -415,6 +415,7 @@ static int qce_ahash_hmac_setkey(struct crypto_ahash *tfm, const u8 *key, ret = crypto_wait_req(crypto_ahash_digest(req), &wait); + memzero_explicit(buf, keylen + QCE_MAX_ALIGN_SIZE); kfree(buf); err_free_req: ahash_request_free(req); -- 2.8.1