Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1171101pxf; Fri, 26 Mar 2021 02:35:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy80u8RHsjcjydipFCwlGmFqrlZDfeHqhxYvWdiYdD+xKfZQtHz4LbMHUMe+lY5Qoj+4zSW X-Received: by 2002:aa7:dd99:: with SMTP id g25mr13623417edv.230.1616751328983; Fri, 26 Mar 2021 02:35:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616751328; cv=none; d=google.com; s=arc-20160816; b=ZqiAihRdBnND2oRjMTLFGD/q4p75zTD1hNVivj+FNfjPeSWpXkbCkimuVv1FTGJkzA AZdoSdckKqmEFLazV6OH7LLdq1FXeGt/NDihBI02v6xeguBInSaMzCG/xGLvH7h4DTBo tYHF+QNEtPhJCAwuB+D0l3mikRt8wtWU11PX7leu6cVMirWQJ+KQOR0c2rVYqVtG2pqY TV0H/8Sb7EsN9GPnfN4RKrxtagYr8TbpPkmcLul80gnMhozWe44JjX+AUBwkh/NC5r88 g+0gSS+33tlBqltyA6ntm5RG755wl1IMiEhJPk6RljnP++HCg7/tyj77PmXF/c7aGoHt +Ceg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=iOxU/4L4tNWTqsBXjIhYRSmufDapoEOVTAEcqdZsyZc=; b=ooO4eYfRr2lcPPV/ucgPKHjRsLdjHDaIYjZXei06QZeBMoOsWyeceHfJf+Yw+HJsCi CyGuFIYlU31EyKzCdTHxtHl7yJOqtSmwWahMkUygiFWeobsOm+WUgzPRtGUqYjLiOCZq J/8VLgWfg0mNZj0tXUxlGycI7TkGxL4yxhCIG9PEHTyHanGVugwJ2UEIlTY+DU4bpIsf WqNAioGNnJzoHdLdobsvxWsPmJUOocefaIH0quXeJ9Yk7EHms7zxF7fBCpKZzmB02rJF w1tj0wxLfIwjDmV5i8TKINOlU/efoSFPK3VwBQ0EmpHfheUE41sPMNr3kRrpxpelpuCt Csig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u12si6811565eda.90.2021.03.26.02.35.05; Fri, 26 Mar 2021 02:35:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230297AbhCZJeB (ORCPT + 99 others); Fri, 26 Mar 2021 05:34:01 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:35500 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230179AbhCZJdZ (ORCPT ); Fri, 26 Mar 2021 05:33:25 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1lPiqD-0003Zw-66; Fri, 26 Mar 2021 20:33:18 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 26 Mar 2021 20:33:17 +1100 Date: Fri, 26 Mar 2021 20:33:17 +1100 From: Herbert Xu To: Hui Tang Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, xuzaibo@huawei.com, wangzhou1@hisilicon.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: hisilicon/hpre - fix "hpre_ctx_init" resource leak Message-ID: <20210326093316.GM12658@gondor.apana.org.au> References: <1616150727-11907-1-git-send-email-tanghui20@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1616150727-11907-1-git-send-email-tanghui20@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Mar 19, 2021 at 06:45:27PM +0800, Hui Tang wrote: > When calling "hpre_ctx_set" fails, stop and put qp, > otherwise will leak qp resource. > > Signed-off-by: Hui Tang > --- > drivers/crypto/hisilicon/hpre/hpre_crypto.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt